From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 19A35EB64DD for ; Thu, 6 Jul 2023 13:55:46 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232700AbjGFNzo (ORCPT ); Thu, 6 Jul 2023 09:55:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35158 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231366AbjGFNzm (ORCPT ); Thu, 6 Jul 2023 09:55:42 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 27F851BE3; Thu, 6 Jul 2023 06:55:20 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id C5F022277F; Thu, 6 Jul 2023 13:55:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1688651718; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XwvMPHSu7xNFjpf/tkeHJ2SIRv1M+NRRDyqHqUcYkIo=; b=b8SqHJVH9ALTskCt9O4rsNLoxpn3giYYrUMszctCcLJzKuGK9qE6uTm/tMYNWgjUAHjQhi x7VCChMaj+XVwZeae7io/NSGjoxG2PUDDTC8NAr0dKTW6Nit5G0/tBlBMyhBMaYBVorEdH R6Ft4HK5XXzEuj+9b6ZnGkRDv+EbHIg= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1688651718; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=XwvMPHSu7xNFjpf/tkeHJ2SIRv1M+NRRDyqHqUcYkIo=; b=513F7K7OruLAfUOTXjNW+VYK3b+OMtcbnip4h6ypWcVNegk2gI7J34PZjwGK72GjQ8lJWp 71MH2jekxP2yh4BQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id B66C7138EE; Thu, 6 Jul 2023 13:55:18 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id rAOlLMbHpmTHZAAAMHmgww (envelope-from ); Thu, 06 Jul 2023 13:55:18 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 54CC3A0707; Thu, 6 Jul 2023 15:55:18 +0200 (CEST) Date: Thu, 6 Jul 2023 15:55:18 +0200 From: Jan Kara To: Jeff Layton Cc: Christian Brauner , Mike Marshall , Martin Brandenburg , Al Viro , Jan Kara , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, devel@lists.orangefs.org Subject: Re: [PATCH v2 65/92] orangefs: convert to ctime accessor functions Message-ID: <20230706135518.xjfzcvf224wfypeg@quack3> References: <20230705185755.579053-1-jlayton@kernel.org> <20230705190309.579783-1-jlayton@kernel.org> <20230705190309.579783-63-jlayton@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20230705190309.579783-63-jlayton@kernel.org> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed 05-07-23 15:01:30, Jeff Layton wrote: > In later patches, we're going to change how the inode's ctime field is > used. Switch to using accessor functions instead of raw accesses of > inode->i_ctime. > > Signed-off-by: Jeff Layton Looks good. Feel free to add: Reviewed-by: Jan Kara Honza > --- > fs/orangefs/namei.c | 2 +- > fs/orangefs/orangefs-utils.c | 6 +++--- > 2 files changed, 4 insertions(+), 4 deletions(-) > > diff --git a/fs/orangefs/namei.c b/fs/orangefs/namei.c > index 77518e248cf7..c9dfd5c6a097 100644 > --- a/fs/orangefs/namei.c > +++ b/fs/orangefs/namei.c > @@ -421,7 +421,7 @@ static int orangefs_rename(struct mnt_idmap *idmap, > ret); > > if (new_dentry->d_inode) > - new_dentry->d_inode->i_ctime = current_time(new_dentry->d_inode); > + inode_set_ctime_current(d_inode(new_dentry)); > > op_release(new_op); > return ret; > diff --git a/fs/orangefs/orangefs-utils.c b/fs/orangefs/orangefs-utils.c > index 46b7dcff18ac..0a9fcfdf552f 100644 > --- a/fs/orangefs/orangefs-utils.c > +++ b/fs/orangefs/orangefs-utils.c > @@ -361,11 +361,11 @@ int orangefs_inode_getattr(struct inode *inode, int flags) > downcall.resp.getattr.attributes.atime; > inode->i_mtime.tv_sec = (time64_t)new_op-> > downcall.resp.getattr.attributes.mtime; > - inode->i_ctime.tv_sec = (time64_t)new_op-> > - downcall.resp.getattr.attributes.ctime; > + inode_set_ctime(inode, > + (time64_t)new_op->downcall.resp.getattr.attributes.ctime, > + 0); > inode->i_atime.tv_nsec = 0; > inode->i_mtime.tv_nsec = 0; > - inode->i_ctime.tv_nsec = 0; > > /* special case: mark the root inode as sticky */ > inode->i_mode = type | (is_root_handle(inode) ? S_ISVTX : 0) | > -- > 2.41.0 > -- Jan Kara SUSE Labs, CR