From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B4FA8EB64D9 for ; Thu, 6 Jul 2023 19:02:10 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229613AbjGFTCK (ORCPT ); Thu, 6 Jul 2023 15:02:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37716 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229522AbjGFTCJ (ORCPT ); Thu, 6 Jul 2023 15:02:09 -0400 Received: from mail-il1-f181.google.com (mail-il1-f181.google.com [209.85.166.181]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0FA111AE; Thu, 6 Jul 2023 12:02:08 -0700 (PDT) Received: by mail-il1-f181.google.com with SMTP id e9e14a558f8ab-34574eb05f4so3924305ab.0; Thu, 06 Jul 2023 12:02:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688670127; x=1691262127; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=yHyEaPrZCKQByAh3DFl+UnNETs5AwZcjbcPbdv9JJW8=; b=lmNsfV7WSyNs1OYQGl6F+KLWmR/NYN0xzDnzf852zg/QEIC0q8lkMpyRd7BWZ3TNCQ 9axPmcQ3wa4gu+LfLSBQb51JMu4kKEgcDldBoOEj3y5+glvV7vdItMF3n1f2bRKgCsqT O0YDI/+CtvDPGHBhLp3T5+gX61taXqzvt6Gxrbx5Uk8WUhC0wLJ/sY3DDKcG8h9zKrxL P97K/VxPkcoBzjyoPJ0OvxInY7efxZPFyqltjFslkWu8HBYAkUKZaafKc/HHEXqmsDCO ybSNYoSDRvjRGfdR1cOvYsUVx7Leot8RiCwmddMNF4ZcIoOM8EQdbroVgSkWoFvRwFNS O28g== X-Gm-Message-State: ABy/qLZfCJMpdh4+g5Iptz2Kr5UHicB1zFW+Dv+NhBCIrw4QA7kZxKWX YNI5LUazm2yCv9soF5ioug== X-Google-Smtp-Source: APBJJlFbADYE6+hk4uSXwI2HJZPLgzAEGH3jTEX9QJwf2mycuUE2+lpXa4xdL1M7WZg+jYHFc5CghQ== X-Received: by 2002:a92:c9d1:0:b0:345:787a:cb27 with SMTP id k17-20020a92c9d1000000b00345787acb27mr2839568ilq.21.1688670127186; Thu, 06 Jul 2023 12:02:07 -0700 (PDT) Received: from robh_at_kernel.org ([64.188.179.250]) by smtp.gmail.com with ESMTPSA id z11-20020a92cd0b000000b0033a50ad8176sm703067iln.18.2023.07.06.12.02.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jul 2023 12:02:06 -0700 (PDT) Received: (nullmailer pid 154245 invoked by uid 1000); Thu, 06 Jul 2023 19:02:04 -0000 Date: Thu, 6 Jul 2023 13:02:04 -0600 From: Rob Herring To: Radhey Shyam Pandey Cc: andersson@kernel.org, mathieu.poirier@linaro.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, michal.simek@amd.com, ben.levinsky@amd.com, tanmay.shah@amd.com, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, git@amd.com Subject: Re: [PATCH v2] dt-bindings: remoteproc: add Tightly Coupled Memory (TCM) bindings Message-ID: <20230706190204.GA144696-robh@kernel.org> References: <1687892226-3784452-1-git-send-email-radhey.shyam.pandey@amd.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1687892226-3784452-1-git-send-email-radhey.shyam.pandey@amd.com> Precedence: bulk List-ID: X-Mailing-List: linux-remoteproc@vger.kernel.org On Wed, Jun 28, 2023 at 12:27:06AM +0530, Radhey Shyam Pandey wrote: > Introduce bindings for TCM memory address space on AMD-xilinx Zynq > UltraScale+ platform. As of now TCM addresses are hardcoded in xilinx > remoteproc driver. This binding will help in defining TCM in device-tree > and make it's access platform agnostic and data-driven from the driver. > > Tightly-coupled memories(TCMs) are low-latency memory that provides > predictable instruction execution and predictable data load/store > timing. Each Cortex-R5F processor contains two 64-bit wide 64 KB memory > banks on the ATCM and BTCM ports, for a total of 128 KB of memory. > > The TCM resources(reg and power-domain) are documented in each R5 node. > It also extends the examples for TCM split and lockstep modes. > > Signed-off-by: Radhey Shyam Pandey > --- > Changes for v2: > - Add ranges property to r5fss cluster node. > - Use regex "^r5f(@[0-9a-f]+|-[a-f0-9]+)$". > - Drop address/size-cells and ranges from r5f core node. > - Mention "reg" and "reg names" as r5f core node required properties. > - Mention address/size-cells and ranges as r5fss required node properties. > - Modify commit description to remove ranges from R5 node. > - Rename r5f node labels(r5f_0 -> r5f_0_split/lockstep and > r5f_1->r5f_1_split/lockstep) > > The inspiration for integrating TCM nodes in R5 nodes is taken from > "5ee79c2ed5bd dt-bindings: remoteproc: Add bindings for R5F subsystem > on TI K3 SoCs".Once the binding is reviewed/accepted will send out > driver changes in follow-up series. > --- > .../remoteproc/xlnx,zynqmp-r5fss.yaml | 90 +++++++++++++++++-- > 1 file changed, 83 insertions(+), 7 deletions(-) > > diff --git a/Documentation/devicetree/bindings/remoteproc/xlnx,zynqmp-r5fss.yaml b/Documentation/devicetree/bindings/remoteproc/xlnx,zynqmp-r5fss.yaml > index 9f677367dd9f..958044b08e86 100644 > --- a/Documentation/devicetree/bindings/remoteproc/xlnx,zynqmp-r5fss.yaml > +++ b/Documentation/devicetree/bindings/remoteproc/xlnx,zynqmp-r5fss.yaml > @@ -20,6 +20,17 @@ properties: > compatible: > const: xlnx,zynqmp-r5fss > > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 1 > + > + ranges: > + description: | > + Standard ranges definition providing address translations for > + local R5F TCM address spaces to bus addresses. > + > xlnx,cluster-mode: > $ref: /schemas/types.yaml#/definitions/uint32 > enum: [0, 1, 2] > @@ -37,7 +48,7 @@ properties: > 2: single cpu mode > > patternProperties: > - "^r5f-[a-f0-9]+$": > + "^r5f(@[0-9a-f]+|-[a-f0-9]+)$": If reg is required, then you don't need '-[a-f0-9]+'. Though new required properties is an ABI change which needs justification. > type: object > description: | > The RPU is located in the Low Power Domain of the Processor Subsystem. > @@ -54,8 +65,19 @@ patternProperties: > compatible: > const: xlnx,zynqmp-r5f > > + reg: > + items: > + - description: Address and Size of the ATCM internal memory region > + - description: Address and Size of the BTCM internal memory region Drop 'Address and Size of ' > + > + reg-names: > + items: > + - const: atcm > + - const: btcm > + > power-domains: > - maxItems: 1 > + minItems: 1 > + maxItems: 3 > > mboxes: > minItems: 1 > @@ -102,31 +124,85 @@ patternProperties: > required: > - compatible > - power-domains > + - reg > + - reg-names > > unevaluatedProperties: false > > required: > - compatible > + - "#address-cells" > + - "#size-cells" > + - ranges > > additionalProperties: false > > examples: > - | > - remoteproc { > + #include > + > + //Split mode configuration > + remoteproc@ffe00000 { > + compatible = "xlnx,zynqmp-r5fss"; > + xlnx,cluster-mode = <0>; > + > + #address-cells = <1>; > + #size-cells = <1>; > + ranges = <0x0 0xffe00000 0x10000>, <0x20000 0xffe20000 0x10000>, > + <0x0 0xffe90000 0x10000>, <0x20000 0xffeb0000 0x10000>; > + > + r5f_0_split: r5f@ffe00000 { > + compatible = "xlnx,zynqmp-r5f"; > + reg = <0xffe00000 0x10000>, <0xffe20000 0x10000>; > + reg-names = "atcm", "btcm"; > + power-domains = <&zynqmp_firmware PD_RPU_0>, > + <&zynqmp_firmware PD_R5_0_ATCM>, > + <&zynqmp_firmware PD_R5_0_BTCM>; > + memory-region = <&rproc_0_fw_image>, <&rpu0vdev0buffer>, <&rpu0vdev0vring0>, <&rpu0vdev0vring1>; > + mboxes = <&ipi_mailbox_rpu0 0>, <&ipi_mailbox_rpu0 1>; > + mbox-names = "tx", "rx"; > + }; > + > + r5f_1_split: r5f@ffe90000 { > + compatible = "xlnx,zynqmp-r5f"; > + reg = <0xffe90000 0x10000>, <0xffeb0000 0x10000>; > + reg-names = "atcm", "btcm"; > + power-domains = <&zynqmp_firmware PD_RPU_1>, > + <&zynqmp_firmware PD_R5_1_ATCM>, > + <&zynqmp_firmware PD_R5_1_BTCM>; > + memory-region = <&rproc_1_fw_image>, <&rpu1vdev0buffer>, <&rpu1vdev0vring0>, <&rpu1vdev0vring1>; > + mboxes = <&ipi_mailbox_rpu1 0>, <&ipi_mailbox_rpu1 1>; > + mbox-names = "tx", "rx"; > + }; > + }; > + > + - | > + //Lockstep configuration > + remoteproc@ffe00000 { > compatible = "xlnx,zynqmp-r5fss"; > xlnx,cluster-mode = <1>; > > - r5f-0 { > + #address-cells = <1>; > + #size-cells = <1>; > + ranges = <0x0 0xffe00000 0x20000>, <0x20000 0xffe20000 0x20000>; > + > + r5f_0_lockstep: r5f@ffe00000 { > compatible = "xlnx,zynqmp-r5f"; > - power-domains = <&zynqmp_firmware 0x7>; > + reg = <0xffe00000 0x20000>, <0xffe20000 0x20000>; > + reg-names = "atcm", "btcm"; > + power-domains = <&zynqmp_firmware PD_RPU_0>, > + <&zynqmp_firmware PD_R5_0_ATCM>, > + <&zynqmp_firmware PD_R5_0_BTCM>; > memory-region = <&rproc_0_fw_image>, <&rpu0vdev0buffer>, <&rpu0vdev0vring0>, <&rpu0vdev0vring1>; > mboxes = <&ipi_mailbox_rpu0 0>, <&ipi_mailbox_rpu0 1>; > mbox-names = "tx", "rx"; > }; > > - r5f-1 { > + r5f_1_lockstep: r5f@ffe90000 { > compatible = "xlnx,zynqmp-r5f"; > - power-domains = <&zynqmp_firmware 0x8>; > + reg = <0xffe90000 0x10000>, <0xffeb0000 0x10000>; > + reg-names = "atcm", "btcm"; > + power-domains = <&zynqmp_firmware PD_RPU_1>; > memory-region = <&rproc_1_fw_image>, <&rpu1vdev0buffer>, <&rpu1vdev0vring0>, <&rpu1vdev0vring1>; > mboxes = <&ipi_mailbox_rpu1 0>, <&ipi_mailbox_rpu1 1>; > mbox-names = "tx", "rx"; > -- > 2.25.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 82064EB64DC for ; Thu, 6 Jul 2023 19:02:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=EG+bLMkM8/UgOW0mGMQcOihPqrutDgPjtE38htWkhNw=; b=3lrjmn27gI4Cy9 kPayweNerZ1ZWqs2hl7KCOGXQXzV8w48HL5Zn8OwgB6ltQkRxPogOVrlmoZBorBVcVHCcSFpoK9Pw 8vT5gdiAbXD6Dna8hSFeWEuEcI2CFBGYwVpQlSJxicbptRxlouynCxazbpjFtg0oUnfndCzgVGIeG otdsz8wdw9pTMxErqKXob0beJi/bmM48r4uFsNLgFpuc4DGVOFneVHmt113LUKtw9xjQ8CpA/sjdo MssLcppEVL+XApkVLJRNFa/orPSdVxEAuqgKAvTukADYvvQOagpfJxR7AChvUxY4H6JleggFYF+ix CwSiImXU81B9sONipalw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qHUF3-002SsW-2N; Thu, 06 Jul 2023 19:02:13 +0000 Received: from mail-il1-f174.google.com ([209.85.166.174]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qHUEz-002SrI-31 for linux-arm-kernel@lists.infradead.org; Thu, 06 Jul 2023 19:02:11 +0000 Received: by mail-il1-f174.google.com with SMTP id e9e14a558f8ab-345e55a62d8so3860755ab.3 for ; Thu, 06 Jul 2023 12:02:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688670127; x=1691262127; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=yHyEaPrZCKQByAh3DFl+UnNETs5AwZcjbcPbdv9JJW8=; b=ULl0LSsZxOBM51L01dxEqbzbD+2uakEG83ALxW+g2ICkMo5ZFJzfxe6FALTVsmhaM6 jyySILPrHyMR0ozmqIiZnm/CbSfWp+6i8HqR0f7huK61IJFNslmhKrzHDhbeef72f5xD hinGElVvaM21xW48jhc3XivKbm1slDQMTNjR4AKlHoSMZISOxu8gWY2gPzH9Zzg2cPuB W/CP97UwaA5FIbLqSiIb2Buhh8Y6m8I9MTmXFvqGCNewk3zZLUP0UyRRxNm2gwc80dzd qrEojyS8teMXhZSBKlvAsm1VeF2bcwAgoxsMqVPlp/0aeQu5ugcyzDo7nksi8AEWNBzo 7+zA== X-Gm-Message-State: ABy/qLa2BebKAYawvJ5OGRJ/ZRZiZ4leGbNf/2mSe0ESzu+HmzHKveq2 T2BTJs7XQCbLKtkXYfAVvA== X-Google-Smtp-Source: APBJJlFbADYE6+hk4uSXwI2HJZPLgzAEGH3jTEX9QJwf2mycuUE2+lpXa4xdL1M7WZg+jYHFc5CghQ== X-Received: by 2002:a92:c9d1:0:b0:345:787a:cb27 with SMTP id k17-20020a92c9d1000000b00345787acb27mr2839568ilq.21.1688670127186; Thu, 06 Jul 2023 12:02:07 -0700 (PDT) Received: from robh_at_kernel.org ([64.188.179.250]) by smtp.gmail.com with ESMTPSA id z11-20020a92cd0b000000b0033a50ad8176sm703067iln.18.2023.07.06.12.02.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 06 Jul 2023 12:02:06 -0700 (PDT) Received: (nullmailer pid 154245 invoked by uid 1000); Thu, 06 Jul 2023 19:02:04 -0000 Date: Thu, 6 Jul 2023 13:02:04 -0600 From: Rob Herring To: Radhey Shyam Pandey Cc: andersson@kernel.org, mathieu.poirier@linaro.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, michal.simek@amd.com, ben.levinsky@amd.com, tanmay.shah@amd.com, linux-remoteproc@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, git@amd.com Subject: Re: [PATCH v2] dt-bindings: remoteproc: add Tightly Coupled Memory (TCM) bindings Message-ID: <20230706190204.GA144696-robh@kernel.org> References: <1687892226-3784452-1-git-send-email-radhey.shyam.pandey@amd.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1687892226-3784452-1-git-send-email-radhey.shyam.pandey@amd.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230706_120209_972089_6C43600E X-CRM114-Status: GOOD ( 23.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Jun 28, 2023 at 12:27:06AM +0530, Radhey Shyam Pandey wrote: > Introduce bindings for TCM memory address space on AMD-xilinx Zynq > UltraScale+ platform. As of now TCM addresses are hardcoded in xilinx > remoteproc driver. This binding will help in defining TCM in device-tree > and make it's access platform agnostic and data-driven from the driver. > > Tightly-coupled memories(TCMs) are low-latency memory that provides > predictable instruction execution and predictable data load/store > timing. Each Cortex-R5F processor contains two 64-bit wide 64 KB memory > banks on the ATCM and BTCM ports, for a total of 128 KB of memory. > > The TCM resources(reg and power-domain) are documented in each R5 node. > It also extends the examples for TCM split and lockstep modes. > > Signed-off-by: Radhey Shyam Pandey > --- > Changes for v2: > - Add ranges property to r5fss cluster node. > - Use regex "^r5f(@[0-9a-f]+|-[a-f0-9]+)$". > - Drop address/size-cells and ranges from r5f core node. > - Mention "reg" and "reg names" as r5f core node required properties. > - Mention address/size-cells and ranges as r5fss required node properties. > - Modify commit description to remove ranges from R5 node. > - Rename r5f node labels(r5f_0 -> r5f_0_split/lockstep and > r5f_1->r5f_1_split/lockstep) > > The inspiration for integrating TCM nodes in R5 nodes is taken from > "5ee79c2ed5bd dt-bindings: remoteproc: Add bindings for R5F subsystem > on TI K3 SoCs".Once the binding is reviewed/accepted will send out > driver changes in follow-up series. > --- > .../remoteproc/xlnx,zynqmp-r5fss.yaml | 90 +++++++++++++++++-- > 1 file changed, 83 insertions(+), 7 deletions(-) > > diff --git a/Documentation/devicetree/bindings/remoteproc/xlnx,zynqmp-r5fss.yaml b/Documentation/devicetree/bindings/remoteproc/xlnx,zynqmp-r5fss.yaml > index 9f677367dd9f..958044b08e86 100644 > --- a/Documentation/devicetree/bindings/remoteproc/xlnx,zynqmp-r5fss.yaml > +++ b/Documentation/devicetree/bindings/remoteproc/xlnx,zynqmp-r5fss.yaml > @@ -20,6 +20,17 @@ properties: > compatible: > const: xlnx,zynqmp-r5fss > > + "#address-cells": > + const: 1 > + > + "#size-cells": > + const: 1 > + > + ranges: > + description: | > + Standard ranges definition providing address translations for > + local R5F TCM address spaces to bus addresses. > + > xlnx,cluster-mode: > $ref: /schemas/types.yaml#/definitions/uint32 > enum: [0, 1, 2] > @@ -37,7 +48,7 @@ properties: > 2: single cpu mode > > patternProperties: > - "^r5f-[a-f0-9]+$": > + "^r5f(@[0-9a-f]+|-[a-f0-9]+)$": If reg is required, then you don't need '-[a-f0-9]+'. Though new required properties is an ABI change which needs justification. > type: object > description: | > The RPU is located in the Low Power Domain of the Processor Subsystem. > @@ -54,8 +65,19 @@ patternProperties: > compatible: > const: xlnx,zynqmp-r5f > > + reg: > + items: > + - description: Address and Size of the ATCM internal memory region > + - description: Address and Size of the BTCM internal memory region Drop 'Address and Size of ' > + > + reg-names: > + items: > + - const: atcm > + - const: btcm > + > power-domains: > - maxItems: 1 > + minItems: 1 > + maxItems: 3 > > mboxes: > minItems: 1 > @@ -102,31 +124,85 @@ patternProperties: > required: > - compatible > - power-domains > + - reg > + - reg-names > > unevaluatedProperties: false > > required: > - compatible > + - "#address-cells" > + - "#size-cells" > + - ranges > > additionalProperties: false > > examples: > - | > - remoteproc { > + #include > + > + //Split mode configuration > + remoteproc@ffe00000 { > + compatible = "xlnx,zynqmp-r5fss"; > + xlnx,cluster-mode = <0>; > + > + #address-cells = <1>; > + #size-cells = <1>; > + ranges = <0x0 0xffe00000 0x10000>, <0x20000 0xffe20000 0x10000>, > + <0x0 0xffe90000 0x10000>, <0x20000 0xffeb0000 0x10000>; > + > + r5f_0_split: r5f@ffe00000 { > + compatible = "xlnx,zynqmp-r5f"; > + reg = <0xffe00000 0x10000>, <0xffe20000 0x10000>; > + reg-names = "atcm", "btcm"; > + power-domains = <&zynqmp_firmware PD_RPU_0>, > + <&zynqmp_firmware PD_R5_0_ATCM>, > + <&zynqmp_firmware PD_R5_0_BTCM>; > + memory-region = <&rproc_0_fw_image>, <&rpu0vdev0buffer>, <&rpu0vdev0vring0>, <&rpu0vdev0vring1>; > + mboxes = <&ipi_mailbox_rpu0 0>, <&ipi_mailbox_rpu0 1>; > + mbox-names = "tx", "rx"; > + }; > + > + r5f_1_split: r5f@ffe90000 { > + compatible = "xlnx,zynqmp-r5f"; > + reg = <0xffe90000 0x10000>, <0xffeb0000 0x10000>; > + reg-names = "atcm", "btcm"; > + power-domains = <&zynqmp_firmware PD_RPU_1>, > + <&zynqmp_firmware PD_R5_1_ATCM>, > + <&zynqmp_firmware PD_R5_1_BTCM>; > + memory-region = <&rproc_1_fw_image>, <&rpu1vdev0buffer>, <&rpu1vdev0vring0>, <&rpu1vdev0vring1>; > + mboxes = <&ipi_mailbox_rpu1 0>, <&ipi_mailbox_rpu1 1>; > + mbox-names = "tx", "rx"; > + }; > + }; > + > + - | > + //Lockstep configuration > + remoteproc@ffe00000 { > compatible = "xlnx,zynqmp-r5fss"; > xlnx,cluster-mode = <1>; > > - r5f-0 { > + #address-cells = <1>; > + #size-cells = <1>; > + ranges = <0x0 0xffe00000 0x20000>, <0x20000 0xffe20000 0x20000>; > + > + r5f_0_lockstep: r5f@ffe00000 { > compatible = "xlnx,zynqmp-r5f"; > - power-domains = <&zynqmp_firmware 0x7>; > + reg = <0xffe00000 0x20000>, <0xffe20000 0x20000>; > + reg-names = "atcm", "btcm"; > + power-domains = <&zynqmp_firmware PD_RPU_0>, > + <&zynqmp_firmware PD_R5_0_ATCM>, > + <&zynqmp_firmware PD_R5_0_BTCM>; > memory-region = <&rproc_0_fw_image>, <&rpu0vdev0buffer>, <&rpu0vdev0vring0>, <&rpu0vdev0vring1>; > mboxes = <&ipi_mailbox_rpu0 0>, <&ipi_mailbox_rpu0 1>; > mbox-names = "tx", "rx"; > }; > > - r5f-1 { > + r5f_1_lockstep: r5f@ffe90000 { > compatible = "xlnx,zynqmp-r5f"; > - power-domains = <&zynqmp_firmware 0x8>; > + reg = <0xffe90000 0x10000>, <0xffeb0000 0x10000>; > + reg-names = "atcm", "btcm"; > + power-domains = <&zynqmp_firmware PD_RPU_1>; > memory-region = <&rproc_1_fw_image>, <&rpu1vdev0buffer>, <&rpu1vdev0vring0>, <&rpu1vdev0vring1>; > mboxes = <&ipi_mailbox_rpu1 0>, <&ipi_mailbox_rpu1 1>; > mbox-names = "tx", "rx"; > -- > 2.25.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel