From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 66B57EB64D9 for ; Fri, 7 Jul 2023 17:44:15 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7484C8623E; Fri, 7 Jul 2023 19:44:13 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="hqaPKq3V"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id DD2248623E; Fri, 7 Jul 2023 19:44:11 +0200 (CEST) Received: from mail-yw1-x1132.google.com (mail-yw1-x1132.google.com [IPv6:2607:f8b0:4864:20::1132]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 53FAB861A5 for ; Fri, 7 Jul 2023 19:44:09 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-yw1-x1132.google.com with SMTP id 00721157ae682-5728df0a7d9so26734747b3.1 for ; Fri, 07 Jul 2023 10:44:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; t=1688751848; x=1691343848; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=D498sdB6VeFV0XVM6JJe441Dalj8omg4ZVMTqlVCXt8=; b=hqaPKq3V3f3q9/h2rO6jJSmi7dfHyYLBSmWXzfyAuYNemtM043Hmk+su9Sv/sCxPVx HCXQuta1K0GFXARBRNuIsdzexORGtBhqknzL9b5u33ETzkrlp5YCkWlHP5GeapKfr2bQ Fe5AtEsU/EQ73c7mR6DNw9ocqgOBMWFhFYaSw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688751848; x=1691343848; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=D498sdB6VeFV0XVM6JJe441Dalj8omg4ZVMTqlVCXt8=; b=PDzRBYl2grRY1cu91IqqFJfqpBLhlLuTjAs4webSDwAxWmopfza8ohv3+Ff16HmdRM whk2I/2rbjyNrJV8rFM8Rmo5LuWsU3UDSPqdE27CFcit//uZeSBHVDNSNFBMn5muzEqn yfLF6ETBLshbQNucL+X2SPjGfE9umnuyT+/+e6QUIlVm7aIg3BissnObzFJNKqFXfzrj LjsSkvT/AZG6luQdsuKgb6Uf0Hr4QlsIujWKCBwD23+NMISoAmjj1o6Efo5U08aHnqez TZ5PGKOHKoLd/wmTxYHZyNIwp01dKwGp74YQfcT3QPCHk/sTH3QWtddG8IahyC/PviLW dTwA== X-Gm-Message-State: ABy/qLZ3eQLp1d+tChbL7qW4s2ZrULC3gRCTagg0OyYVVhACHGT72Kpu Ywh/fbywpy/QwoTkWGvYHl3QdwMU77ax/rFUJZ/x7w== X-Google-Smtp-Source: APBJJlElDE8Ua9XlJH5GGzJZ9IMGAZp9T84GS/6LKSfsMpNwll7zluHaPK/g4nGVk9xYdiMTEmgvRw== X-Received: by 2002:a81:6a85:0:b0:565:9fc7:9330 with SMTP id f127-20020a816a85000000b005659fc79330mr5206016ywc.17.1688751848067; Fri, 07 Jul 2023 10:44:08 -0700 (PDT) Received: from bill-the-cat (2603-6081-7b00-6400-21ea-8e86-6208-34bf.res6.spectrum.com. [2603:6081:7b00:6400:21ea:8e86:6208:34bf]) by smtp.gmail.com with ESMTPSA id v7-20020a81a547000000b00570253fc3e5sm1152449ywg.105.2023.07.07.10.44.07 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 07 Jul 2023 10:44:07 -0700 (PDT) Date: Fri, 7 Jul 2023 13:44:05 -0400 From: Tom Rini To: Simon Glass Cc: Abdellatif El Khlifi , ilias.apalodimas@linaro.org, nd@arm.com, u-boot@lists.denx.de, Jens Wiklander Subject: Re: [PATCH v14 11/11] arm_ffa: efi: corstone1000: enable MM communication Message-ID: <20230707174405.GF148062@bill-the-cat> References: <20230707144410.228472-1-abdellatif.elkhlifi@arm.com> <20230707144410.228472-12-abdellatif.elkhlifi@arm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="YaQSZXWipO7qov/7" Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.8 at phobos.denx.de X-Virus-Status: Clean --YaQSZXWipO7qov/7 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Jul 07, 2023 at 11:35:05AM -0600, Simon Glass wrote: > Hi Abdellatif, >=20 > On Fri, 7 Jul 2023 at 15:44, Abdellatif El Khlifi > wrote: > > > > turn on EFI MM communication > > > > On corstone1000 platform MM communication between u-boot > > and the secure world (Optee) is done using the FF-A bus. > > > > Signed-off-by: Abdellatif El Khlifi > > Cc: Tom Rini > > Cc: Simon Glass > > Cc: Ilias Apalodimas > > Cc: Jens Wiklander > > > > --- > > > > Changelog: > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > > > > v13: > > > > * remove FF-A config in the defconfig > > (because it's enabled automatically by CONFIG_EFI_MM_COMM_TEE) > > > > v9: > > > > * update copyright string > > > > v8: > > > > * drop OP-TEE configs from Corstone-1000 defconfig > > > > v7: > > > > * improve the definition of FFA_SHARED_MM_BUFFER_ADDR and > > FFA_SHARED_MM_BUFFER_OFFSET > > * update FFA_SHARED_MM_BUFFER_ADDR value > > > > v6: > > > > * corstone-1000: enable optee driver > > * corstone-1000: remove CONFIG_ARM_FFA_EFI_RUNTIME_MODE from the defcon= fig > > > > v4: > > > > * corstone-1000: turn on EFI MM communication > > > > configs/corstone1000_defconfig | 1 + > > include/configs/corstone1000.h | 15 +++++++++++++-- > > 2 files changed, 14 insertions(+), 2 deletions(-) > > > > diff --git a/configs/corstone1000_defconfig b/configs/corstone1000_defc= onfig > > index a8a79fd105..b57e2322c4 100644 > > --- a/configs/corstone1000_defconfig > > +++ b/configs/corstone1000_defconfig > > @@ -65,3 +65,4 @@ CONFIG_EFI_CAPSULE_ON_DISK=3Dy > > CONFIG_EFI_IGNORE_OSINDICATIONS=3Dy > > CONFIG_FWU_MULTI_BANK_UPDATE=3Dy > > CONFIG_ERRNO_STR=3Dy > > +CONFIG_EFI_MM_COMM_TEE=3Dy > > diff --git a/include/configs/corstone1000.h b/include/configs/corstone1= 000.h > > index 3347c11792..4ef1f05e40 100644 > > --- a/include/configs/corstone1000.h > > +++ b/include/configs/corstone1000.h > > @@ -1,9 +1,11 @@ > > /* SPDX-License-Identifier: GPL-2.0+ */ > > /* > > - * (C) Copyright 2022 ARM Limited > > * (C) Copyright 2022 Linaro > > * Rui Miguel Silva > > - * Abdellatif El Khlifi > > + * Copyright 2022-2023 Arm Limited and/or its affiliates > > + * > > + * Authors: > > + * Abdellatif El Khlifi > > * > > * Configuration for Corstone1000. Parts were derived from other ARM > > * configurations. > > @@ -14,6 +16,15 @@ > > > > #include > > > > +#define FFA_SHARED_MM_BUFFER_SIZE SZ_4K /* 4 KB */ > > + > > +/* > > + * shared buffer physical address used for communication between > > + * u-boot and the MM SP > > + */ > > +#define FFA_SHARED_MM_BUFFER_ADDR 0x02000000UL > > +#define FFA_SHARED_MM_BUFFER_OFFSET 0 > > + >=20 > These should be in devicetree properties, shouldn't they? We don't > want things in board config.h files anymore. Wasn't one of the earlier debates on if the whole thing needs to be in device tree, or not, because it's a "discoverable bus" and so Linux wasn't needing one? I don't want to de-rail this series, which I think we're just about otherwise ready to merge, over that debate again. As these values have to match up (I assume) with the other side, are these truly per-board, or SoC dependent? --=20 Tom --YaQSZXWipO7qov/7 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmSoTuIACgkQFHw5/5Y0 tyz/LAv/ZyIhXKFYUsy36BBaCYFhZzcD/lNdrwU9knyB6BTvc9OVW/QLuun4/+53 BxpNJMoOeMUygWzbykiE5XhHUOX9DyeoovXHmQyFjsn6qvQasRIFRnVHK2AXOtcr CYJMd4ne41jMsuwUwc2SsVP8iYgF9l0btFHNbVkobqbm6eItKGigEjRO9N71BfS5 6sVR85X8PFmhPcMJ8GEBrriecKC7f/v9kuczfqa2q0k4cPPdJSzoVVG1B1MpgTJb qK51/tkIXW0vPHtHcG4ilmiYbaxWzsWb43lJIFUoJyv3YX8lldvJ0iVFK/IDooeR MubbfcfM340+j9Z8BFdpxyCBPp7tZ89Zo2LkXfWQfkoDIAZWY1J9JYqlnY2xXp1S 3NccVDR5UbDoSgU6P1KfqmMKGBczymy23EA2Cidfy0LHRfgzf7BhdQNF9CIOdHND dGDqSa219MttW9vfWYtljJXLAythCkOTU0jSctUodvKYnJC0LjTbWFbItt6FKKTx oHThMHi6 =WWMt -----END PGP SIGNATURE----- --YaQSZXWipO7qov/7--