All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jakub Kicinski <kuba@kernel.org>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: "David S. Miller" <davem@davemloft.net>,
	Oliver Neukum <oneukum@suse.com>,
	netdev@vger.kernel.org,
	USB mailing list <linux-usb@vger.kernel.org>
Subject: Re: [PATCH] net: usbnet: Fix WARNING in usbnet_start_xmit/usb_submit_urb
Date: Tue, 11 Jul 2023 13:12:05 -0700	[thread overview]
Message-ID: <20230711131205.53b3e5e4@kernel.org> (raw)
In-Reply-To: <38ff51d4-2734-4dd7-8638-ae2fc8572c0d@rowland.harvard.edu>

On Tue, 11 Jul 2023 13:38:00 -0400 Alan Stern wrote:
> +		u8		ep_addrs[3] = {
> +			info->in + USB_DIR_IN, info->out + USB_DIR_OUT, 0};

With the two-tab indentation and the continuation line starting
half way thru.. this looks highly unusual. Can we use a more
standard kernel formatting in this case?

		u8 ep_addrs[3] = {
			info->in + USB_DIR_IN, info->out + USB_DIR_OUT, 0
		};
-- 
pw-bot: cr

  reply	other threads:[~2023-07-11 20:12 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-15  7:28 [syzbot] WARNING in usbnet_start_xmit/usb_submit_urb syzbot
2021-11-15 14:31 ` Oliver Neukum
2021-12-04 10:18   ` Dmitry Vyukov
2021-11-18 17:20 ` Oliver Neukum
2021-11-18 17:34   ` syzbot
2021-11-25 13:37 ` Oliver Neukum
2021-11-25 13:48   ` syzbot
2021-11-25 17:39   ` [PATCH] usbnet: sanity check for endpoint types kernel test robot
2021-11-25 17:39     ` kernel test robot
2021-12-09 12:03 ` [syzbot] WARNING in usbnet_start_xmit/usb_submit_urb Oliver Neukum
2021-12-09 12:26   ` syzbot
2023-06-23 13:32 ` [syzbot] [usb?] " syzbot
2023-06-23 15:23   ` Alan Stern
2023-06-23 16:07     ` syzbot
2023-06-23 17:16     ` Alan Stern
2023-07-11 12:42       ` Oliver Neukum
2023-07-11 17:38         ` [PATCH] net: usbnet: Fix " Alan Stern
2023-07-11 20:12           ` Jakub Kicinski [this message]
2023-07-12 14:15             ` [PATCH v2] " Alan Stern
2023-07-14  4:00               ` patchwork-bot+netdevbpf

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230711131205.53b3e5e4@kernel.org \
    --to=kuba@kernel.org \
    --cc=davem@davemloft.net \
    --cc=linux-usb@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=oneukum@suse.com \
    --cc=stern@rowland.harvard.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.