All of lore.kernel.org
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@linaro.org>
To: Bjorn Andersson <andersson@kernel.org>,
	Andy Gross <agross@kernel.org>,
	 Michael Turquette <mturquette@baylibre.com>,
	 Stephen Boyd <sboyd@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	 Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	 Conor Dooley <conor+dt@kernel.org>
Cc: Marijn Suijten <marijn.suijten@somainline.org>,
	 linux-arm-msm@vger.kernel.org, linux-clk@vger.kernel.org,
	 linux-kernel@vger.kernel.org, devicetree@vger.kernel.org,
	 Konrad Dybcio <konrad.dybcio@linaro.org>
Subject: [PATCH v2 07/15] clk: qcom: gpucc-sm6115: Add runtime PM
Date: Wed, 29 Nov 2023 19:59:26 +0100	[thread overview]
Message-ID: <20230717-topic-branch_aon_cleanup-v2-7-2a583460ef26@linaro.org> (raw)
In-Reply-To: <20230717-topic-branch_aon_cleanup-v2-0-2a583460ef26@linaro.org>

The GPU_CC block on SM6115 is powered by the VDD_CX rail. We need to
ensure that CX is enabled to prevent unwanted power collapse and that
the reference is dropped when unused so that the system can enter a
firmware-managed lower power state.

Enable runtime PM to keep the power flowing only when necessary.

Signed-off-by: Konrad Dybcio <konrad.dybcio@linaro.org>
---
 drivers/clk/qcom/gpucc-sm6115.c | 19 +++++++++++++++++--
 1 file changed, 17 insertions(+), 2 deletions(-)

diff --git a/drivers/clk/qcom/gpucc-sm6115.c b/drivers/clk/qcom/gpucc-sm6115.c
index 93a50431aef8..b50979ce1cbe 100644
--- a/drivers/clk/qcom/gpucc-sm6115.c
+++ b/drivers/clk/qcom/gpucc-sm6115.c
@@ -8,6 +8,7 @@
 #include <linux/mod_devicetable.h>
 #include <linux/module.h>
 #include <linux/platform_device.h>
+#include <linux/pm_runtime.h>
 #include <linux/regmap.h>
 
 #include <dt-bindings/clock/qcom,sm6115-gpucc.h>
@@ -443,10 +444,21 @@ MODULE_DEVICE_TABLE(of, gpu_cc_sm6115_match_table);
 static int gpu_cc_sm6115_probe(struct platform_device *pdev)
 {
 	struct regmap *regmap;
+	int ret;
+
+	ret = devm_pm_runtime_enable(&pdev->dev);
+	if (ret)
+		return ret;
+
+	ret = pm_runtime_resume_and_get(&pdev->dev);
+	if (ret)
+		return ret;
 
 	regmap = qcom_cc_map(pdev, &gpu_cc_sm6115_desc);
-	if (IS_ERR(regmap))
+	if (IS_ERR(regmap)) {
+		pm_runtime_put(&pdev->dev);
 		return PTR_ERR(regmap);
+	}
 
 	clk_alpha_pll_configure(&gpu_cc_pll0, regmap, &gpu_cc_pll0_config);
 	clk_alpha_pll_configure(&gpu_cc_pll1, regmap, &gpu_cc_pll1_config);
@@ -461,7 +473,10 @@ static int gpu_cc_sm6115_probe(struct platform_device *pdev)
 	qcom_branch_set_clk_en(regmap, 0x1078); /* GPU_CC_AHB_CLK */
 	qcom_branch_set_clk_en(regmap, 0x1060); /* GPU_CC_GX_CXO_CLK */
 
-	return qcom_cc_really_probe(pdev, &gpu_cc_sm6115_desc, regmap);
+	ret = qcom_cc_really_probe(pdev, &gpu_cc_sm6115_desc, regmap);
+	pm_runtime_put(&pdev->dev);
+
+	return ret;
 }
 
 static struct platform_driver gpu_cc_sm6115_driver = {

-- 
2.43.0


  parent reply	other threads:[~2023-11-29 18:59 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-29 18:59 [PATCH v2 00/15] Unregister critical branch clocks + some RPM Konrad Dybcio
2023-11-29 18:59 ` [PATCH v2 01/15] clk: qcom: branch: Add a helper for setting the enable bit Konrad Dybcio
2023-11-29 20:53   ` Bryan O'Donoghue
2023-11-29 18:59 ` [PATCH v2 02/15] clk: qcom: Use qcom_branch_set_clk_en() Konrad Dybcio
2023-11-29 20:59   ` Bryan O'Donoghue
2023-11-29 22:05     ` Konrad Dybcio
2023-11-29 18:59 ` [PATCH v2 03/15] clk: qcom: gcc-sm6375: Unregister critical clocks Konrad Dybcio
2023-11-29 21:08   ` Bryan O'Donoghue
2023-11-29 22:08     ` Konrad Dybcio
2023-11-29 18:59 ` [PATCH v2 04/15] clk: qcom: gcc-sm6375: Add runtime PM Konrad Dybcio
2023-11-29 18:59 ` [PATCH v2 05/15] clk: qcom: gpucc-sm6375: Unregister critical clocks Konrad Dybcio
2023-11-29 21:10   ` Bryan O'Donoghue
2023-11-29 18:59 ` [PATCH v2 06/15] clk: qcom: gpucc-sm6115: " Konrad Dybcio
2023-11-29 21:14   ` Bryan O'Donoghue
2023-11-29 22:09     ` Konrad Dybcio
2023-11-29 18:59 ` Konrad Dybcio [this message]
2023-11-29 18:59 ` [PATCH v2 08/15] clk: qcom: gcc-sm6115: " Konrad Dybcio
2023-11-29 18:59 ` [PATCH v2 09/15] clk: qcom: gcc-sm6115: Add runtime PM Konrad Dybcio
2023-11-29 18:59 ` [PATCH v2 10/15] clk: qcom: gcc-qcm2290: Unregister critical clocks Konrad Dybcio
2023-11-29 18:59 ` [PATCH v2 11/15] clk: qcom: gcc-qcm2290: Add runtime PM Konrad Dybcio
2023-11-29 18:59 ` [PATCH v2 12/15] arm64: dts: qcom: sm6375: Add VDD_CX to GCC Konrad Dybcio
2023-11-29 18:59 ` [PATCH v2 13/15] arm64: dts: qcom: qcm2290: " Konrad Dybcio
2023-11-29 18:59 ` [PATCH v2 14/15] arm64: dts: qcom: sm6115: " Konrad Dybcio
2023-11-29 18:59 ` [PATCH v2 15/15] arm64: dts: qcom: sm6115: Add VDD_CX to GPU_CC Konrad Dybcio

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230717-topic-branch_aon_cleanup-v2-7-2a583460ef26@linaro.org \
    --to=konrad.dybcio@linaro.org \
    --cc=agross@kernel.org \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-clk@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=marijn.suijten@somainline.org \
    --cc=mturquette@baylibre.com \
    --cc=robh+dt@kernel.org \
    --cc=sboyd@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.