On Fri, Jul 21, 2023 at 03:27:33PM +0800, Guo Samin wrote: > -------- 原始信息 -------- > 主题: Re: [PATCH v1 0/2] Add ethernet nodes for StarFive JH7110 SoC > From: Conor Dooley > 收件人: Guo Samin , Rob Herring , Krzysztof Kozlowski , Paul Walmsley , Palmer Dabbelt , Albert Ou , Hal Feng , linux-kernel@vger.kernel.org, linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, netdev@vger.kernel.org > 日期: 2023/7/21 btw, please try and remove this stuff from your mails. > > On 21 July 2023 03:09:19 IST, Guo Samin wrote: > >> There is a question about the configuration of phy that I would like to consult you. > >> > >> Latest on motorcomm PHY V5[1]: Follow Rob Herring's advice > >> motorcomm,rx-xxx-driver-strength Changed to motorcomm,rx-xxx-drv-microamp . > >> V5 has already received a reviewed-by from Andrew Lunn, and it should not change again. > >> > >> Should I submit another pacthes based on riscv-dt-for-next? > > > > Huh, dtbs_check passed for these patches, > > I didn't realise changes to the motorcomm stuff > > were a dep. for this. I'll take a look later. > After discussing with HAL, I have prepared the code and considered adding the following patch to > Motorcomm's patchsetes v6. (To fix some spelling errors in v5[1]) > which will then send patches based on linux-next. What do you think? @Andrew @Conor I think you are better off just sending the dts patch to me, adding a dts patch that will not apply to net-next to your motorcomm driver series will only really cause problems for the netdev patchwork automation. > [1] https://patchwork.kernel.org/project/netdevbpf/cover/20230720111509.21843-1-samin.guo@starfivetech.com I meant to ack this yesterday, but it wasn't in my dt-binding review queue. I'll go do that now.