From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 95619C001DF for ; Wed, 2 Aug 2023 23:14:05 +0000 (UTC) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1qRL23-0004y6-3K; Wed, 02 Aug 2023 19:13:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qRL21-0004xl-7K for qemu-devel@nongnu.org; Wed, 02 Aug 2023 19:13:29 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qRL20-0005Dq-VH; Wed, 02 Aug 2023 19:13:28 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=In-Reply-To:MIME-Version:References:Subject:To:From: Date; bh=sgD1tXjnKUZdMgld/JBx0osppgY+3VfsaOOVO+Id7r0=; b=DSAvudo3c1LzKT664DZ8 qNcniiJTiaEUBkg1KmiNw4mvnSnYJ0w5o44ug7niduwmvYaevPzZ9z9Pi+5QEAUGqDT6iVRTnz2Ht ff9cdLaD8x4R9zyT4lHBM7umvakOW8W+BdL5BFtDHlUd6sDMzeHED8Yz7VghOpWLXggzVbjBOjusD wKAt+kvmFY0v/+ST4QWZDzORJdcv3vcHOT12z1keQ6a1Dt0QkcqhSsFaiabmTc/JkYeGgvyVfEIkx TtVFqKxt3yzEz5ZDAda8By2iMn4sNGIZ3fnKvAJFv+h8tAzaNa3Jg7HDFhLQiGZcS4gxL8jYC7cfl DbC8aFd03DzFHw==; Received: from [2a01:cb19:4a:a400:de41:a9ff:fe47:ec49] (helo=begin) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qRL20-0001U9-Oo; Wed, 02 Aug 2023 19:13:28 -0400 Received: from samy by begin with local (Exim 4.96) (envelope-from ) id 1qRL1w-00AUEy-36; Thu, 03 Aug 2023 01:13:24 +0200 Date: Thu, 3 Aug 2023 01:13:24 +0200 From: Samuel Thibault To: Henrik Carlqvist Cc: qemu-devel@nongnu.org Subject: Re: [PATCH v1] Allowing setting and overriding parameters in smb.conf Message-ID: <20230802231324.b5zk2kf44oqzocel@begin> References: <20230610122912.0fc157de.hc981@poolhem.se> <20230611014751.22f22674.hc94@poolhem.se> <20230620215043.6124c450.hc94@poolhem.se> <20230621201447.712ec73a.hc94@poolhem.se> <20230623203007.56d3d182.hc981@poolhem.se> <20230801232725.4cc838fb.hc981@poolhem.se> <20230802195356.rwibjix3bub7s7qw@begin> <20230803010909.723e2c1f.hc981@poolhem.se> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230803010909.723e2c1f.hc981@poolhem.se> Organization: I am not organized User-Agent: NeoMutt/20170609 (1.8.3) X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Henrik Carlqvist, le jeu. 03 août 2023 01:09:09 +0200, a ecrit: > On Wed, 2 Aug 2023 21:53:56 +0200 > Samuel Thibault wrote: > > > Henrik Carlqvist, le mar. 01 août 2023 23:27:25 +0200, a ecrit: > > > @@ -950,10 +953,11 @@ static int slirp_smb(SlirpState* s, const char > > > *exported_dir, > > > "printing = bsd\n" > > > "disable spoolss = yes\n" > > > "usershare max shares = 0\n" > > > - "[qemu]\n" > > > - "path=%s\n" > > > "read only=no\n" > > > "guest ok=yes\n" > > > + "%s" > > > + "[qemu]\n" > > > + "path=%s\n" > > > > ?This is moving read only and guest ok to the global section? > > Thanks for your quick reply! > > Yes, I thought that would be OK because the [qemu] share will inherit those > settings from the global section. By placing those in the global section it is > possible to override them with later contradicting statements like > "read only=yes\n" in the %s before the [qemu] section. Ok, it would be useful to mention that in the changelog. Thanks, Samuel