All of lore.kernel.org
 help / color / mirror / Atom feed
From: Jeff King <peff@peff.net>
To: git@vger.kernel.org
Subject: [PATCH 0/2] fix git-send-email with recent versions of Term::ReadLine::Gnu
Date: Tue, 8 Aug 2023 14:09:35 -0400	[thread overview]
Message-ID: <20230808180935.GA2096901@coredump.intra.peff.net> (raw)

Using git-send-email with the latest release of Term::ReadLine::Gnu
causes any invocations which prompt more than once to fail. Details are
in the second patch, which fixes it. The first patch cleans up an
obsolete workaround that obscured the root cause of the problem.

The affected version of Term::ReadLine::Gnu is v1.46, which hit Debian
unstable in the past few weeks. So we should consider this for maint
and perhaps even for the -rc candidates, since people will presumably
start running into this more and more.

  [1/2]: send-email: drop FakeTerm hack
  [2/2]: send-email: avoid creating more than one Term::ReadLine object

 git-send-email.perl   | 32 +++++++++++---------------------
 t/t9001-send-email.sh |  5 +++--
 2 files changed, 14 insertions(+), 23 deletions(-)

-Peff

             reply	other threads:[~2023-08-08 19:56 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-08-08 18:09 Jeff King [this message]
2023-08-08 18:14 ` [PATCH 1/2] send-email: drop FakeTerm hack Jeff King
2023-08-08 20:13   ` Taylor Blau
2023-08-08 18:15 ` [PATCH 2/2] send-email: avoid creating more than one Term::ReadLine object Jeff King
2023-08-08 20:16   ` Taylor Blau

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230808180935.GA2096901@coredump.intra.peff.net \
    --to=peff@peff.net \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.