From: Greg KH <gregkh@linuxfoundation.org>
To: "Starke, Daniel" <daniel.starke@siemens.com>
Cc: "linux-serial@vger.kernel.org" <linux-serial@vger.kernel.org>,
"jirislaby@kernel.org" <jirislaby@kernel.org>,
"ilpo.jarvinen@linux.intel.com" <ilpo.jarvinen@linux.intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 09/10] tty: n_gsm: expose configuration and statistics via proc fs
Date: Wed, 16 Aug 2023 08:03:17 +0200 [thread overview]
Message-ID: <2023081644-stiffness-division-215b@gregkh> (raw)
In-Reply-To: <DB9PR10MB588118BBA6BEDC06EEF6FC75E015A@DB9PR10MB5881.EURPRD10.PROD.OUTLOOK.COM>
On Wed, Aug 16, 2023 at 04:51:06AM +0000, Starke, Daniel wrote:
> > Please no, procfs is NOT for driver/device statistics like this, that's
> > what sysfs is for if you really need/want it.
> >
> > What userspace tool is going to read/parse this thing? Where does it
> > live?
> >
> > And what about the security issues involved with all of this new data
> > that you are now exposing to all users? Has it been audited to verify
> > that it is safe to do so?
>
> Thank you for the feedback and patience. I understand your concerns.
> Therefore, please proceed with this patch series by excluding this
> patch #9. Please let me know if you need me to resend the patch series.
You have to resend them, they are long gone from my review queue, and
picking out an individual patch to not apply is difficult with our
existing tools as that is not a normal workflow.
thanks,
greg k-h
next prev parent reply other threads:[~2023-08-16 6:04 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-17 15:56 [PATCH v5 01/10] tty: n_gsm: add restart flag to DLC specific ioctl config D. Starke
2023-05-17 15:56 ` [PATCH v5 02/10] tty: n_gsm: add missing description to structs in gsmmux.h D. Starke
2023-05-17 15:56 ` [PATCH v5 03/10] tty: n_gsm: remove unneeded initialization of ret in gsm_dlci_config D. Starke
2023-05-17 15:56 ` [PATCH v5 04/10] tty: n_gsm: add open_error counter to gsm_mux D. Starke
2023-05-17 15:56 ` [PATCH v5 05/10] tty: n_gsm: increase malformed counter for malformed control frames D. Starke
2023-05-17 15:57 ` [PATCH v5 06/10] tty: n_gsm: increase gsm_mux unsupported counted where appropriate D. Starke
2023-05-17 15:57 ` [PATCH v5 07/10] tty: n_gsm: cleanup gsm_control_command and gsm_control_reply D. Starke
2023-05-17 15:57 ` [PATCH v5 08/10] tty: n_gsm: add DLCI specific rx/tx statistics D. Starke
2023-05-17 15:57 ` [PATCH v5 09/10] tty: n_gsm: expose configuration and statistics via proc fs D. Starke
2023-05-30 11:23 ` Greg KH
2023-08-16 4:51 ` Starke, Daniel
2023-08-16 6:03 ` Greg KH [this message]
2023-05-17 15:57 ` [PATCH v5 10/10] tty: n_gsm: add restart flag to extended ioctl config D. Starke
2023-05-30 11:21 ` [PATCH v5 01/10] tty: n_gsm: add restart flag to DLC specific " Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023081644-stiffness-division-215b@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=daniel.starke@siemens.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.