[PATCH] libkmod: allow to fallback to user-space decompression

From: Andrea Righi <andrea.righi@canonical.com>
To: Lucas De Marchi <lucas.de.marchi@gmail.com>
Cc: Luis Chamberlain <mcgrof@kernel.org>, linux-modules@vger.kernel.org
Subject: [PATCH] libkmod: allow to fallback to user-space decompression
Date: Tue, 29 Aug 2023 14:38:08 +0200	[thread overview]
Message-ID: <20230829123808.325202-1-andrea.righi@canonical.com> (raw)

Fallback to user-space decompression when the kernel cannot allocate
enough memory to perform the decompression.

This can happen with large modules, such as xfs on linux 6.5 for
example, an ENOMEM would be returned and the module fails to load.

It seems more reliable to try again with user-space decompression
rather than reporting an error and failing to load the module.

Fixes: 09c9f8c ("libkmod: Use kernel decompression when available")
Signed-off-by: Andrea Righi <andrea.righi@canonical.com>
---
 libkmod/libkmod-module.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/libkmod/libkmod-module.c b/libkmod/libkmod-module.c
index 585da41..d2d4815 100644
--- a/libkmod/libkmod-module.c
+++ b/libkmod/libkmod-module.c
@@ -978,7 +978,7 @@ KMOD_EXPORT int kmod_module_insert_module(struct kmod_module *mod,
 	}
 
 	err = do_finit_module(mod, flags, args);
-	if (err == -ENOSYS)
+	if (err == -ENOSYS || err == -ENOMEM)
 		err = do_init_module(mod, flags, args);
 
 	if (err < 0)
-- 
2.40.1

