From: Conor Dooley <conor@kernel.org>
To: Binbin Zhou <zhoubinbin@loongson.cn>
Cc: Binbin Zhou <zhoubb.aaron@gmail.com>,
Huacai Chen <chenhuacai@loongson.cn>,
Yinbo Zhu <zhuyinbo@loongson.cn>, Arnd Bergmann <arnd@arndb.de>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Huacai Chen <chenhuacai@kernel.org>,
loongson-kernel@lists.loongnix.cn, soc@kernel.org,
devicetree@vger.kernel.org, linux-pm@vger.kernel.org,
Xuerui Wang <kernel@xen0n.name>,
loongarch@lists.linux.dev, Randy Dunlap <rdunlap@infradead.org>
Subject: Re: [PATCH v2 1/5] soc: loongson: loongson_pm2: Add dependency for INPUT
Date: Thu, 31 Aug 2023 16:17:30 +0100 [thread overview]
Message-ID: <20230831-visor-tutor-b91b872e10d9@spud> (raw)
In-Reply-To: <13f54f2119b99f967c18c6671d7b80c62264d7ef.1693474728.git.zhoubinbin@loongson.cn>
[-- Attachment #1: Type: text/plain, Size: 2445 bytes --]
On Thu, Aug 31, 2023 at 07:43:11PM +0800, Binbin Zhou wrote:
> Since commit 67694c076bd7 ("soc: loongson2_pm: add power management
> support"), the Loongson-2K PM driver was added, but it didn't update the
> Kconfig entry for the INPUT dependency, leading to build errors, so
> update the Kconfig entry to depend on INPUT.
>
> /opt/crosstool/gcc-13.2.0-nolibc/loongarch64-linux/bin/loongarch64-linux-ld:
> drivers/soc/loongson/loongson2_pm.o: in function `loongson2_power_button_init':
> /work/lnx/next/linux-next-20230825/LOONG64/../drivers/soc/loongson/loongson2_pm.c:101:(.text+0x350): undefined reference to `input_allocate_device'
> /opt/crosstool/gcc-13.2.0-nolibc/loongarch64-linux/bin/loongarch64-linux-ld:
> /work/lnx/next/linux-next-20230825/LOONG64/../drivers/soc/loongson/loongson2_pm.c:109:(.text+0x3dc): undefined reference to `input_set_capability'
> /opt/crosstool/gcc-13.2.0-nolibc/loongarch64-linux/bin/loongarch64-linux-ld:
> /work/lnx/next/linux-next-20230825/LOONG64/../drivers/soc/loongson/loongson2_pm.c:111:(.text+0x3e4): undefined reference to `input_register_device'
> /opt/crosstool/gcc-13.2.0-nolibc/loongarch64-linux/bin/loongarch64-linux-ld:
> /work/lnx/next/linux-next-20230825/LOONG64/../drivers/soc/loongson/loongson2_pm.c:125:(.text+0x3fc): undefined reference to `input_free_device'
> /opt/crosstool/gcc-13.2.0-nolibc/loongarch64-linux/bin/loongarch64-linux-ld: drivers/soc/loongson/loongson2_pm.o: in function `input_report_key':
> /work/lnx/next/linux-next-20230825/LOONG64/../include/linux/input.h:425:(.text+0x58c): undefined reference to `input_event'
>
> Reported-by: Randy Dunlap <rdunlap@infradead.org>
> Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn>
> ---
> drivers/soc/loongson/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/soc/loongson/Kconfig b/drivers/soc/loongson/Kconfig
> index 314e13bb3e01..368344943a93 100644
> --- a/drivers/soc/loongson/Kconfig
> +++ b/drivers/soc/loongson/Kconfig
> @@ -20,6 +20,7 @@ config LOONGSON2_GUTS
> config LOONGSON2_PM
> bool "Loongson-2 SoC Power Management Controller Driver"
> depends on LOONGARCH && OF
> + depends on INPUT=y
Your commit message should say why INPUT needs to not be a module.
> help
> The Loongson-2's power management controller was ACPI, supports ACPI
> S2Idle (Suspend To Idle), ACPI S3 (Suspend To RAM), ACPI S4 (Suspend To
> --
> 2.39.3
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2023-08-31 15:17 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-31 11:43 [PATCH v2 0/5] soc: loongson: Fix some issues about loongson_pm2 Binbin Zhou
2023-08-31 11:43 ` [PATCH v2 1/5] soc: loongson: loongson_pm2: Add dependency for INPUT Binbin Zhou
2023-08-31 15:17 ` Conor Dooley [this message]
2023-08-31 11:43 ` [PATCH v2 2/5] dt-bindings: soc: loongson,ls2k-pmc: Use fallbacks for ls2k-pmc compatible Binbin Zhou
2023-08-31 15:18 ` Conor Dooley
2023-08-31 11:43 ` [PATCH v2 3/5] soc: loongson: loongson_pm2: Drop useless of_device_id compatible Binbin Zhou
2023-08-31 15:14 ` Conor Dooley
2023-09-01 3:05 ` Binbin Zhou
2023-09-01 6:32 ` Conor Dooley
2023-08-31 11:43 ` [PATCH v2 4/5] dt-bindings: soc: loongson,ls2k-pmc: Allow syscon-reboot/syscon-poweroff as child Binbin Zhou
2023-09-01 9:06 ` Krzysztof Kozlowski
2023-09-01 9:27 ` Binbin Zhou
2023-09-01 11:44 ` Krzysztof Kozlowski
2023-08-31 11:43 ` [PATCH v2 5/5] soc: loongson: loongson_pm2: Populate children syscon nodes Binbin Zhou
2023-09-26 21:03 ` [PATCH v2 0/5] soc: loongson: Fix some issues about loongson_pm2 patchwork-bot+linux-soc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230831-visor-tutor-b91b872e10d9@spud \
--to=conor@kernel.org \
--cc=arnd@arndb.de \
--cc=chenhuacai@kernel.org \
--cc=chenhuacai@loongson.cn \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@xen0n.name \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-pm@vger.kernel.org \
--cc=loongarch@lists.linux.dev \
--cc=loongson-kernel@lists.loongnix.cn \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
--cc=soc@kernel.org \
--cc=zhoubb.aaron@gmail.com \
--cc=zhoubinbin@loongson.cn \
--cc=zhuyinbo@loongson.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.