From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26868E7D240 for ; Tue, 26 Sep 2023 07:17:54 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229585AbjIZHR6 (ORCPT ); Tue, 26 Sep 2023 03:17:58 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56254 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229513AbjIZHR5 (ORCPT ); Tue, 26 Sep 2023 03:17:57 -0400 Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4E4BDEB for ; Tue, 26 Sep 2023 00:17:50 -0700 (PDT) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ql2KH-0003JD-7I; Tue, 26 Sep 2023 09:17:45 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ql2KG-0093NE-Iq; Tue, 26 Sep 2023 09:17:44 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1ql2KG-004tvU-9J; Tue, 26 Sep 2023 09:17:44 +0200 Date: Tue, 26 Sep 2023 09:17:44 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Aisheng Dong , "daniel.thompson@linaro.org" Cc: "linux-pm@vger.kernel.org" , Jingoo Han , "deller@gmx.de" , "lee@kernel.org" , "linux-fbdev@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "thierry.reding@gmail.com" , "kernel@pengutronix.de" Subject: Re: [PATCH] backlight: pwm_bl: Disable PWM on shutdown and suspend disabled PWM emiting inactive state") Message-ID: <20230926071744.oikg3ndaq6x7yjrw@pengutronix.de> References: <20230322070352.xfwmnqyrao3mifuu@pengutronix.de> <20230322085129.jxxz55tbcxkc6usd@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="7ds4pnxi44iyaelx" Content-Disposition: inline In-Reply-To: <20230322085129.jxxz55tbcxkc6usd@pengutronix.de> X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-pm@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org --7ds4pnxi44iyaelx Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello, On Wed, Mar 22, 2023 at 09:51:29AM +0100, Uwe Kleine-K=F6nig wrote: > Since commit 00e7e698bff1 ("backlight: pwm_bl: Configure pwm only once > per backlight toggle") calling pwm_backlight_power_off() doesn't disable > the PWM any more. However this is necessary to suspend, because PWM > drivers usually refuse to suspend if they are still enabled. >=20 > Also adapt shutdown to disable the PWM for similar reasons. >=20 > Fixes: 00e7e698bff1 ("backlight: pwm_bl: Configure pwm only once per back= light toggle") > Reported-by: Aisheng Dong > Signed-off-by: Uwe Kleine-K=F6nig This patch was never applied but I think it is still needed. I assume it fell through the cracks? Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | --7ds4pnxi44iyaelx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmUShZcACgkQj4D7WH0S /k42Tgf/Tir1DYkvJiUE1QS6MkI16X656C4B4XQbHRwG1pSy2RgetRNm08W+X/j6 nBGthOGckEwMPDATx7U/TP6Me5taUO8otLanBnZholUnGQWL6utcRNCYI+bURrWH meqqPB6qFS74qib1161gTlrvHKkekqqDXuTCznWdSAtQOF4QWwnAguOee6QUHgr+ GLsgwfSBZkogfxffEh0PYdb50ttrFIxd0ZSmoPWDzPgJR27YGtGy5MoQ0Z6//f7z bIdWhTCnIlZqIP7+UIua/1LKNXKYa5YVVWwTpU5fq2pGU5sRhrPgY/qamDwG/QZ4 QNlQ+Wu3YS2IswvekbDn6sTWUipk3w== =Sftu -----END PGP SIGNATURE----- --7ds4pnxi44iyaelx-- From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CD4B5E7D243 for ; Tue, 26 Sep 2023 07:17:56 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1536B10E353; Tue, 26 Sep 2023 07:17:56 +0000 (UTC) Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by gabe.freedesktop.org (Postfix) with ESMTPS id C725510E353 for ; Tue, 26 Sep 2023 07:17:53 +0000 (UTC) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ql2KH-0003JD-7I; Tue, 26 Sep 2023 09:17:45 +0200 Received: from [2a0a:edc0:0:900:1d::77] (helo=ptz.office.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1ql2KG-0093NE-Iq; Tue, 26 Sep 2023 09:17:44 +0200 Received: from ukl by ptz.office.stw.pengutronix.de with local (Exim 4.94.2) (envelope-from ) id 1ql2KG-004tvU-9J; Tue, 26 Sep 2023 09:17:44 +0200 Date: Tue, 26 Sep 2023 09:17:44 +0200 From: Uwe =?utf-8?Q?Kleine-K=C3=B6nig?= To: Aisheng Dong , "daniel.thompson@linaro.org" Subject: Re: [PATCH] backlight: pwm_bl: Disable PWM on shutdown and suspend disabled PWM emiting inactive state") Message-ID: <20230926071744.oikg3ndaq6x7yjrw@pengutronix.de> References: <20230322070352.xfwmnqyrao3mifuu@pengutronix.de> <20230322085129.jxxz55tbcxkc6usd@pengutronix.de> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="7ds4pnxi44iyaelx" Content-Disposition: inline In-Reply-To: <20230322085129.jxxz55tbcxkc6usd@pengutronix.de> X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: ukl@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: dri-devel@lists.freedesktop.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "linux-fbdev@vger.kernel.org" , "linux-pm@vger.kernel.org" , Jingoo Han , "deller@gmx.de" , "lee@kernel.org" , "dri-devel@lists.freedesktop.org" , "thierry.reding@gmail.com" , "kernel@pengutronix.de" Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" --7ds4pnxi44iyaelx Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Hello, On Wed, Mar 22, 2023 at 09:51:29AM +0100, Uwe Kleine-K=F6nig wrote: > Since commit 00e7e698bff1 ("backlight: pwm_bl: Configure pwm only once > per backlight toggle") calling pwm_backlight_power_off() doesn't disable > the PWM any more. However this is necessary to suspend, because PWM > drivers usually refuse to suspend if they are still enabled. >=20 > Also adapt shutdown to disable the PWM for similar reasons. >=20 > Fixes: 00e7e698bff1 ("backlight: pwm_bl: Configure pwm only once per back= light toggle") > Reported-by: Aisheng Dong > Signed-off-by: Uwe Kleine-K=F6nig This patch was never applied but I think it is still needed. I assume it fell through the cracks? Best regards Uwe --=20 Pengutronix e.K. | Uwe Kleine-K=F6nig | Industrial Linux Solutions | https://www.pengutronix.de/ | --7ds4pnxi44iyaelx Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAABCgAdFiEEP4GsaTp6HlmJrf7Tj4D7WH0S/k4FAmUShZcACgkQj4D7WH0S /k42Tgf/Tir1DYkvJiUE1QS6MkI16X656C4B4XQbHRwG1pSy2RgetRNm08W+X/j6 nBGthOGckEwMPDATx7U/TP6Me5taUO8otLanBnZholUnGQWL6utcRNCYI+bURrWH meqqPB6qFS74qib1161gTlrvHKkekqqDXuTCznWdSAtQOF4QWwnAguOee6QUHgr+ GLsgwfSBZkogfxffEh0PYdb50ttrFIxd0ZSmoPWDzPgJR27YGtGy5MoQ0Z6//f7z bIdWhTCnIlZqIP7+UIua/1LKNXKYa5YVVWwTpU5fq2pGU5sRhrPgY/qamDwG/QZ4 QNlQ+Wu3YS2IswvekbDn6sTWUipk3w== =Sftu -----END PGP SIGNATURE----- --7ds4pnxi44iyaelx--