From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3EFA1E7D261 for ; Tue, 26 Sep 2023 08:30:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233837AbjIZIa1 (ORCPT ); Tue, 26 Sep 2023 04:30:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46166 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233835AbjIZIa1 (ORCPT ); Tue, 26 Sep 2023 04:30:27 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E486997; Tue, 26 Sep 2023 01:30:20 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 74622C433C7; Tue, 26 Sep 2023 08:30:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695717020; bh=1KWbLzquAwU/B/ON0zh3ARW1/mjPU9ppWT7SEVnyDnA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gIB7ZMHmyr4U9VrGTW6fb/xRGmazA+QF92yVzfp6wgpcT3RmDa/Vlfyfkx0L3Yx3D nmJRzkkWV/vS8EC8D9q0owAjZgjfwHt2a/ESsN5cmaU4fj2EIeKLPgMinUW7pSEVd0 XPHk6HQl6tNnVSGOYAWhyuvUgAHZFJBYeg5sXENDOm7AQm9Rn3uuWgjmed69whPcxe qYAxknPVHimHuIYYtwKh3PASHTgN1XPW/VjiUG2UWVEETrMA+P00XiscG/AG0xHHE1 chcHV8H6TlCUiQMHL52dC8RsgJxPSoEV+yaJ5f/u4O7zNLfnWI6J8CbwADQYZ2rh0E L9EZhQCGzpjUQ== Date: Tue, 26 Sep 2023 09:30:15 +0100 From: Lee Jones To: Uwe =?iso-8859-1?Q?Kleine-K=F6nig?= Cc: Aisheng Dong , "daniel.thompson@linaro.org" , "linux-pm@vger.kernel.org" , Jingoo Han , "deller@gmx.de" , "linux-fbdev@vger.kernel.org" , "dri-devel@lists.freedesktop.org" , "thierry.reding@gmail.com" , "kernel@pengutronix.de" Subject: Re: [PATCH] backlight: pwm_bl: Disable PWM on shutdown and suspend disabled PWM emiting inactive state") Message-ID: <20230926083015.GD9999@google.com> References: <20230322070352.xfwmnqyrao3mifuu@pengutronix.de> <20230322085129.jxxz55tbcxkc6usd@pengutronix.de> <20230926071744.oikg3ndaq6x7yjrw@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20230926071744.oikg3ndaq6x7yjrw@pengutronix.de> Precedence: bulk List-ID: X-Mailing-List: linux-pm@vger.kernel.org On Tue, 26 Sep 2023, Uwe Kleine-König wrote: > Hello, > > On Wed, Mar 22, 2023 at 09:51:29AM +0100, Uwe Kleine-König wrote: > > Since commit 00e7e698bff1 ("backlight: pwm_bl: Configure pwm only once > > per backlight toggle") calling pwm_backlight_power_off() doesn't disable > > the PWM any more. However this is necessary to suspend, because PWM > > drivers usually refuse to suspend if they are still enabled. > > > > Also adapt shutdown to disable the PWM for similar reasons. > > > > Fixes: 00e7e698bff1 ("backlight: pwm_bl: Configure pwm only once per backlight toggle") > > Reported-by: Aisheng Dong > > Signed-off-by: Uwe Kleine-König > > This patch was never applied but I think it is still needed. I assume it > fell through the cracks? This "patch" was sent half way through a thread and when opened in my mail client looks like a mail reply due to the quotes below the '---'. I'd suggest sending this again. -- Lee Jones [李琼斯]