From: Jakub Kicinski <kuba@kernel.org>
To: Taehee Yoo <ap420073@gmail.com>
Cc: davem@davemloft.net, pabeni@redhat.com, edumazet@google.com,
jiri@resnulli.us, netdev@vger.kernel.org,
syzbot+9bbbacfbf1e04d5221f7@syzkaller.appspotmail.com,
syzbot+1c71587a1a09de7fbde3@syzkaller.appspotmail.com
Subject: Re: [PATCH net v2] net: team: get rid of team->lock in team module
Date: Wed, 4 Oct 2023 06:52:07 -0700 [thread overview]
Message-ID: <20231004065207.5fe143ad@kernel.org> (raw)
In-Reply-To: <20230916131115.488756-1-ap420073@gmail.com>
On Sat, 16 Sep 2023 13:11:15 +0000 Taehee Yoo wrote:
> The purpose of team->lock is to protect the private data of the team
> interface. But RTNL already protects it all well.
> The precise purpose of the team->lock is to reduce contention of
> RTNL due to GENL operations such as getting the team port list, and
> configuration dump.
FTR I like this patch. My understanding is that team has relatively
low adoption (RHEL dropped the support completely?). The granular
lock is not necessary.
We're spending time trying to preserve and unnecessary optimization
in rarely used driver :(
prev parent reply other threads:[~2023-10-04 13:52 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-16 13:11 [PATCH net v2] net: team: get rid of team->lock in team module Taehee Yoo
2023-09-16 16:47 ` Jiri Pirko
2023-09-18 1:16 ` Taehee Yoo
2023-09-18 7:19 ` Jiri Pirko
2023-09-18 7:42 ` Taehee Yoo
2023-09-19 7:40 ` Paolo Abeni
2023-09-19 10:32 ` Jiri Pirko
2023-09-19 10:41 ` Paolo Abeni
2023-10-04 13:52 ` Jakub Kicinski [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231004065207.5fe143ad@kernel.org \
--to=kuba@kernel.org \
--cc=ap420073@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=syzbot+1c71587a1a09de7fbde3@syzkaller.appspotmail.com \
--cc=syzbot+9bbbacfbf1e04d5221f7@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.