From: Marc Kleine-Budde <mkl@pengutronix.de>
To: linux-can@vger.kernel.org
Cc: kernel@pengutronix.de, Marc Kleine-Budde <mkl@pengutronix.de>
Subject: [PATCH v2 05/27] can: at91_can: ECR register: convert to FIELD_GET()
Date: Thu, 05 Oct 2023 09:49:33 +0200 [thread overview]
Message-ID: <20231005-at91_can-rx_offload-v2-5-9987d53600e0@pengutronix.de> (raw)
In-Reply-To: <20231005-at91_can-rx_offload-v2-0-9987d53600e0@pengutronix.de>
Use FIELD_GET() to access the individual fields of the ECR register.
Signed-off-by: Marc Kleine-Budde <mkl@pengutronix.de>
---
drivers/net/can/at91_can.c | 7 +++++--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/net/can/at91_can.c b/drivers/net/can/at91_can.c
index 79eb78b9f8ae..7597da543348 100644
--- a/drivers/net/can/at91_can.c
+++ b/drivers/net/can/at91_can.c
@@ -72,6 +72,9 @@ enum at91_reg {
#define AT91_BR_BRP_MASK GENMASK(22, 16)
#define AT91_BR_SMP BIT(24)
+#define AT91_ECR_REC_MASK GENMASK(8, 0)
+#define AT91_ECR_TEC_MASK GENMASK(23, 16)
+
#define AT91_MMR_PRIO_SHIFT (16)
#define AT91_MID_MIDE BIT(29)
@@ -385,8 +388,8 @@ static int at91_get_berr_counter(const struct net_device *dev,
const struct at91_priv *priv = netdev_priv(dev);
u32 reg_ecr = at91_read(priv, AT91_ECR);
- bec->rxerr = reg_ecr & 0xff;
- bec->txerr = reg_ecr >> 16;
+ bec->rxerr = FIELD_GET(AT91_ECR_REC_MASK, reg_ecr);
+ bec->txerr = FIELD_GET(AT91_ECR_TEC_MASK, reg_ecr);
return 0;
}
--
2.40.1
next prev parent reply other threads:[~2023-10-05 14:26 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-05 7:49 [PATCH v2 00/27] can: at91: add can_state_get_by_berr_counter() helper, cleanup and convert to rx_offload Marc Kleine-Budde
2023-10-05 7:49 ` [PATCH v2 01/27] can: dev: add can_state_get_by_berr_counter() to return the CAN state based on the current error counters Marc Kleine-Budde
2023-10-05 7:49 ` [PATCH v2 02/27] can: at91_can: use a consistent indention Marc Kleine-Budde
2023-10-05 7:49 ` [PATCH v2 03/27] can: at91_can: at91_irq_tx(): remove one level of indention Marc Kleine-Budde
2023-10-05 7:49 ` [PATCH v2 04/27] can: at91_can: BR register: convert to FIELD_PREP() Marc Kleine-Budde
2023-10-05 7:49 ` Marc Kleine-Budde [this message]
2023-10-05 7:49 ` [PATCH v2 06/27] can: at91_can: MMR registers: " Marc Kleine-Budde
2023-10-05 7:49 ` [PATCH v2 07/27] can: at91_can: MID registers: convert access to FIELD_PREP(), FIELD_GET() Marc Kleine-Budde
2023-10-05 7:49 ` [PATCH v2 08/27] can: at91_can: MSR Register: convert to FIELD_PREP() Marc Kleine-Budde
2023-10-05 7:49 ` [PATCH v2 09/27] can: at91_can: MCR " Marc Kleine-Budde
2023-10-05 7:49 ` [PATCH v2 10/27] can: at91_can: add more register definitions Marc Kleine-Budde
2023-10-05 7:49 ` [PATCH v2 11/27] can: at91_can: at91_setup_mailboxes(): update comments Marc Kleine-Budde
2023-10-05 7:49 ` [PATCH v2 12/27] can: at91_can: rename struct at91_priv::{tx_next,tx_echo} to {tx_head,tx_tail} Marc Kleine-Budde
2023-10-05 7:49 ` [PATCH v2 13/27] can: at91_can: at91_set_bittiming(): demote register output to debug level Marc Kleine-Budde
2023-10-05 7:49 ` [PATCH v2 14/27] can: at91_can: at91_chip_start(): don't disable IRQs twice Marc Kleine-Budde
2023-10-05 7:49 ` [PATCH v2 15/27] can: at91_can: at91_open(): forward request_irq()'s return value in case or an error Marc Kleine-Budde
2023-10-05 7:49 ` [PATCH v2 16/27] can: at91_can: add CAN transceiver support Marc Kleine-Budde
2023-10-05 7:49 ` [PATCH v2 17/27] can: at91_can: at91_poll_err(): fold in at91_poll_err_frame() Marc Kleine-Budde
2023-10-05 7:49 ` [PATCH v2 18/27] can: at91_can: at91_poll_err(): increase stats even if no quota left or OOM Marc Kleine-Budde
2023-10-05 7:49 ` [PATCH v2 19/27] can: at91_can: at91_irq_err_frame(): call directly from IRQ handler Marc Kleine-Budde
2023-10-05 7:49 ` [PATCH v2 20/27] can: at91_can: at91_irq_err_frame(): move next to at91_irq_err() Marc Kleine-Budde
2023-10-05 7:49 ` [PATCH v2 21/27] can: at91_can: at91_irq_err(): rename to at91_irq_err_line() Marc Kleine-Budde
2023-10-05 7:49 ` [PATCH v2 22/27] can: at91_can: at91_irq_err_line(): make use of can_state_get_by_berr_counter() Marc Kleine-Budde
2023-10-05 7:49 ` [PATCH v2 23/27] can: at91_can: at91_irq_err_line(): take reg_sr into account for bus off Marc Kleine-Budde
2023-10-05 7:49 ` [PATCH v2 24/27] can: at91_can: at91_irq_err_line(): make use of can_change_state() and can_bus_off() Marc Kleine-Budde
2023-10-05 7:49 ` [PATCH v2 25/27] can: at91_can: at91_irq_err_line(): send error counters with state change Marc Kleine-Budde
2023-10-05 7:49 ` [PATCH v2 26/27] can: at91_can: at91_alloc_can_err_skb() introduce new function Marc Kleine-Budde
2023-10-05 7:49 ` [PATCH v2 27/27] can: at91_can: switch to rx-offload implementation Marc Kleine-Budde
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231005-at91_can-rx_offload-v2-5-9987d53600e0@pengutronix.de \
--to=mkl@pengutronix.de \
--cc=kernel@pengutronix.de \
--cc=linux-can@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.