Re: [RFC PATCH v3 1/3] x86/boot/e820: Expose kexec range update, remove and table update functions

[kernel test robot <lkp@intel.com>]

Hi Stanislav,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build warnings:

[auto build test WARNING on tip/x86/core]
[also build test WARNING on tip/master linus/master tip/auto-latest v6.6-rc4 next-20231005]
[cannot apply to akpm-mm/mm-everything]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Stanislav-Kinsburskii/x86-boot-e820-Expose-kexec-range-update-remove-and-table-update-functions/20231005-062443
base:   tip/x86/core
patch link:    https://lore.kernel.org/r/169645819587.11424.5389114333710932782.stgit%40skinsburskii.
patch subject: [RFC PATCH v3 1/3] x86/boot/e820: Expose kexec range update, remove and table update functions
config: i386-randconfig-003-20231005 (https://download.01.org/0day-ci/archive/20231005/202310051753.cGqR9NNP-lkp@intel.com/config)
compiler: gcc-7 (Ubuntu 7.5.0-6ubuntu2) 7.5.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231005/202310051753.cGqR9NNP-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310051753.cGqR9NNP-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> arch/x86/kernel/e820.c:540:12: warning: no previous declaration for '__e820__range_remove' [-Wmissing-declarations]
    u64 __init __e820__range_remove(struct e820_table *table, u64 start, u64 size, enum e820_type old_type, bool check_type)
               ^~~~~~~~~~~~~~~~~~~~


vim +/__e820__range_remove +540 arch/x86/kernel/e820.c

   539	
 > 540	u64 __init __e820__range_remove(struct e820_table *table, u64 start, u64 size, enum e820_type old_type, bool check_type)
   541	{
   542		int i;
   543		u64 end;
   544		u64 real_removed_size = 0;
   545	
   546		if (size > (ULLONG_MAX - start))
   547			size = ULLONG_MAX - start;
   548	
   549		end = start + size;
   550		printk(KERN_DEBUG "e820: remove [mem %#010Lx-%#010Lx] ", start, end - 1);
   551		if (check_type)
   552			e820_print_type(old_type);
   553		pr_cont("\n");
   554	
   555		for (i = 0; i < table->nr_entries; i++) {
   556			struct e820_entry *entry = &table->entries[i];
   557			u64 final_start, final_end;
   558			u64 entry_end;
   559	
   560			if (check_type && entry->type != old_type)
   561				continue;
   562	
   563			entry_end = entry->addr + entry->size;
   564	
   565			/* Completely covered? */
   566			if (entry->addr >= start && entry_end <= end) {
   567				real_removed_size += entry->size;
   568				memset(entry, 0, sizeof(*entry));
   569				continue;
   570			}
   571	
   572			/* Is the new range completely covered? */
   573			if (entry->addr < start && entry_end > end) {
   574				e820__range_add(end, entry_end - end, entry->type);
   575				entry->size = start - entry->addr;
   576				real_removed_size += size;
   577				continue;
   578			}
   579	
   580			/* Partially covered: */
   581			final_start = max(start, entry->addr);
   582			final_end = min(end, entry_end);
   583			if (final_start >= final_end)
   584				continue;
   585	
   586			real_removed_size += final_end - final_start;
   587	
   588			/*
   589			 * Left range could be head or tail, so need to update
   590			 * the size first:
   591			 */
   592			entry->size -= final_end - final_start;
   593			if (entry->addr < final_start)
   594				continue;
   595	
   596			entry->addr = final_end;
   597		}
   598		return real_removed_size;
   599	}
   600	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki