From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A000AE94118 for ; Fri, 6 Oct 2023 20:52:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233535AbjJFUwK (ORCPT ); Fri, 6 Oct 2023 16:52:10 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39754 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233558AbjJFUwJ (ORCPT ); Fri, 6 Oct 2023 16:52:09 -0400 Received: from mail-ot1-f54.google.com (mail-ot1-f54.google.com [209.85.210.54]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 890A5F4; Fri, 6 Oct 2023 13:52:07 -0700 (PDT) Received: by mail-ot1-f54.google.com with SMTP id 46e09a7af769-6c67060fdfaso1681029a34.2; Fri, 06 Oct 2023 13:52:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696625527; x=1697230327; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=AxA7X0kfXMYgoBV1O1X+yHhp+zy1lafQd7Biqyk0F6I=; b=w7zT9BLoUeSBTR+8fZauwIDkdcKhM7PW8kT9dwPHXsI0mBcGjFpV8iMH6bhI5CDCPw ZKLDeUhyYtjwPzyOB0SjhhOKSdDEfX6wJrJ4YFg1N2+aZRZy9Bv3CLfjvW1vLf1AcMoh DB0dCfWW5+uRZDTkR0T38x+Ir4rPGu8LVVJh4foasAiBZXupT3UhDsBp38uW12UqukWw 1cG/+AUULPnh1iFhP1cFJO4Ukjx0vMND5zjbEQ0dWPvuC8lnZrZvxE7CXpUBFGQFi5Ch f1FOjmADeRvJ4yWuGsUZj54SHTD8QbqmgxhyBq4pHXjkG9Col6/fpr9rPHPuLKbSdqfP 3D7A== X-Gm-Message-State: AOJu0YyG6dfGEPJ5HPRI877Vy+5Pa/C1jaUCiS9XU24/ozHOlzhwLuib Bx9d49On9IWpSqxyrBuh2Q== X-Google-Smtp-Source: AGHT+IHX3H8MRm6KCZ4S+gOcfHJbAyvk4Xms+EtBBj4/O9yoRvZYjP9vx8dfGltszT00mRSHuPIzXA== X-Received: by 2002:a05:6830:442:b0:6c6:42ca:ed52 with SMTP id d2-20020a056830044200b006c642caed52mr9250691otc.30.1696625526665; Fri, 06 Oct 2023 13:52:06 -0700 (PDT) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id n24-20020a9d4d18000000b006bee51de9f6sm679314otf.18.2023.10.06.13.52.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Oct 2023 13:52:05 -0700 (PDT) Received: (nullmailer pid 275984 invoked by uid 1000); Fri, 06 Oct 2023 20:52:04 -0000 Date: Fri, 6 Oct 2023 15:52:04 -0500 From: Rob Herring To: Peter Griffin Cc: krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com, conor+dt@kernel.org, sboyd@kernel.org, tomasz.figa@gmail.com, s.nawrocki@samsung.com, linus.walleij@linaro.org, wim@linux-watchdog.org, linux@roeck-us.net, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, olof@lixom.net, cw00.choi@samsung.com, tudor.ambarus@linaro.org, andre.draszik@linaro.org, semen.protsenko@linaro.org, soc@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-watchdog@vger.kernel.org Subject: Re: [PATCH 19/21] google/gs101: Add dt overlay for oriole board Message-ID: <20231006205204.GA269353-robh@kernel.org> References: <20231005155618.700312-1-peter.griffin@linaro.org> <20231005155618.700312-20-peter.griffin@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231005155618.700312-20-peter.griffin@linaro.org> Precedence: bulk List-ID: X-Mailing-List: linux-gpio@vger.kernel.org On Thu, Oct 05, 2023 at 04:56:16PM +0100, Peter Griffin wrote: > The LK bootloader on Pixel6 searches for a dt overlay in the > dtbo partition with a board_id and board_rev that matches > what is baked into the device. If this overlay is not present > then the phone will bootloop in fastboot and you can't boot > the upstream kernel. > > This commit adds a dtbo for the production oriole variant. > The other pre-production board overlays are not included > at this time. > > Adding the dtbo here allows for a better experience when > building/booting the upstream kernel on Pixel devices > as all the DT required to boot the device will be created > as part of the kernel build process. Rather than having to > fetch the dtbo from some other repo. > > Signed-off-by: Peter Griffin > --- > arch/arm64/boot/dts/google/Makefile | 1 + > arch/arm64/boot/dts/google/gs101-oriole.dtso | 21 ++++++++++++++++++++ > 2 files changed, 22 insertions(+) > create mode 100644 arch/arm64/boot/dts/google/gs101-oriole.dtso > > diff --git a/arch/arm64/boot/dts/google/Makefile b/arch/arm64/boot/dts/google/Makefile > index 6d2026a767d4..3f1761f8daa9 100644 > --- a/arch/arm64/boot/dts/google/Makefile > +++ b/arch/arm64/boot/dts/google/Makefile > @@ -2,5 +2,6 @@ > > dtb-$(CONFIG_ARCH_GOOGLE_TENSOR) += \ > gs101-oriole.dtb \ > + gs101-oriole.dtbo Overlays in the kernel must be able to be applied to a base DT in the kernel. Add a rule to apply this (hint: a '-dtbs' variable does this similar to -objs variables). > diff --git a/arch/arm64/boot/dts/google/gs101-oriole.dtso b/arch/arm64/boot/dts/google/gs101-oriole.dtso > new file mode 100644 > index 000000000000..50832fd94204 > --- /dev/null > +++ b/arch/arm64/boot/dts/google/gs101-oriole.dtso > @@ -0,0 +1,21 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Oriole DVT Device Tree Doesn't DVT mean pre-production? Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 003B6E94114 for ; Fri, 6 Oct 2023 20:52:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Mrmeza/TmJTKho+YEtx+Hs8CT74uzs1koWx7HcfsLKM=; b=iORnoO9Qozc0Rz 0/KRoRRNMRSwbqMUgDudI9emLu45R6Ap7qLMg4TRp9gcRHfBTMOxb4SVqCVkpjcl4DH5HGAeC+GTo G6JFfvnHUpSZSCRtvDUIVPA/VbiTDXaUfkB8LWixy0Tl8NLv9xF/loH2MhLPfGx5jykRJVaVDYhrY YQUwL1ph9klvBgySwCod2rUwi1UxKeqTJZVkahUqIq3Sj5XyXT5pFiaDzKKW4xlPvbi8kEpcBmQE4 CtnFgK6Sfef4pGYR5dgI1o6crbiz4YWTC0xOStLqEaObgjlLQVtBMbaqR1ijYCQTYlXbbutTASPVC cMVLIfU83dMez3IHPbRQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qornv-006Tju-2V; Fri, 06 Oct 2023 20:52:11 +0000 Received: from mail-ot1-f46.google.com ([209.85.210.46]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qorns-006TjV-2k for linux-arm-kernel@lists.infradead.org; Fri, 06 Oct 2023 20:52:10 +0000 Received: by mail-ot1-f46.google.com with SMTP id 46e09a7af769-6b9e478e122so1695395a34.1 for ; Fri, 06 Oct 2023 13:52:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1696625527; x=1697230327; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=AxA7X0kfXMYgoBV1O1X+yHhp+zy1lafQd7Biqyk0F6I=; b=QhB5qQp03TNuzY9Sqjwj3HxxrDxSU7PY+YIYM/HCdCtnT1M4c4C+eZVf+edO0IBC+e 1Cpe0YhasffEwgRvfrMXlh2CvDCBwd24J1p5D66A5r5kJ13G/pfyaenmbekfaGIO5mS/ mf6dRxn+sb42PfdTo1mjOPbpUfPBpXwEuv5c2kjj1+9IqIFNmqPNAaEjABI/mx23GThU inYq11S/i2so2IvMdt+DdLqaaU1wsSoP/xm2/j3aTyekK4tPMSayDU8c0fBGtzxas8kc Ex0zR2vNiiQ5x8j8R8IzlntUFgf2CaXUzylDaJl2zLITBWo4uuLaid57/ave/2T6jXLl 0IUw== X-Gm-Message-State: AOJu0Yxf2VvB8RynbaGUBjfLwmi1JRGQzo60sUFo960nJwa7Gy5JLCIE HsOt+DtWA2tULKXCi5PI4g== X-Google-Smtp-Source: AGHT+IHX3H8MRm6KCZ4S+gOcfHJbAyvk4Xms+EtBBj4/O9yoRvZYjP9vx8dfGltszT00mRSHuPIzXA== X-Received: by 2002:a05:6830:442:b0:6c6:42ca:ed52 with SMTP id d2-20020a056830044200b006c642caed52mr9250691otc.30.1696625526665; Fri, 06 Oct 2023 13:52:06 -0700 (PDT) Received: from robh_at_kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id n24-20020a9d4d18000000b006bee51de9f6sm679314otf.18.2023.10.06.13.52.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Oct 2023 13:52:05 -0700 (PDT) Received: (nullmailer pid 275984 invoked by uid 1000); Fri, 06 Oct 2023 20:52:04 -0000 Date: Fri, 6 Oct 2023 15:52:04 -0500 From: Rob Herring To: Peter Griffin Cc: krzysztof.kozlowski+dt@linaro.org, mturquette@baylibre.com, conor+dt@kernel.org, sboyd@kernel.org, tomasz.figa@gmail.com, s.nawrocki@samsung.com, linus.walleij@linaro.org, wim@linux-watchdog.org, linux@roeck-us.net, catalin.marinas@arm.com, will@kernel.org, arnd@arndb.de, olof@lixom.net, cw00.choi@samsung.com, tudor.ambarus@linaro.org, andre.draszik@linaro.org, semen.protsenko@linaro.org, soc@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-clk@vger.kernel.org, linux-gpio@vger.kernel.org, linux-watchdog@vger.kernel.org Subject: Re: [PATCH 19/21] google/gs101: Add dt overlay for oriole board Message-ID: <20231006205204.GA269353-robh@kernel.org> References: <20231005155618.700312-1-peter.griffin@linaro.org> <20231005155618.700312-20-peter.griffin@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231005155618.700312-20-peter.griffin@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231006_135208_911426_571CF183 X-CRM114-Status: GOOD ( 26.47 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, Oct 05, 2023 at 04:56:16PM +0100, Peter Griffin wrote: > The LK bootloader on Pixel6 searches for a dt overlay in the > dtbo partition with a board_id and board_rev that matches > what is baked into the device. If this overlay is not present > then the phone will bootloop in fastboot and you can't boot > the upstream kernel. > > This commit adds a dtbo for the production oriole variant. > The other pre-production board overlays are not included > at this time. > > Adding the dtbo here allows for a better experience when > building/booting the upstream kernel on Pixel devices > as all the DT required to boot the device will be created > as part of the kernel build process. Rather than having to > fetch the dtbo from some other repo. > > Signed-off-by: Peter Griffin > --- > arch/arm64/boot/dts/google/Makefile | 1 + > arch/arm64/boot/dts/google/gs101-oriole.dtso | 21 ++++++++++++++++++++ > 2 files changed, 22 insertions(+) > create mode 100644 arch/arm64/boot/dts/google/gs101-oriole.dtso > > diff --git a/arch/arm64/boot/dts/google/Makefile b/arch/arm64/boot/dts/google/Makefile > index 6d2026a767d4..3f1761f8daa9 100644 > --- a/arch/arm64/boot/dts/google/Makefile > +++ b/arch/arm64/boot/dts/google/Makefile > @@ -2,5 +2,6 @@ > > dtb-$(CONFIG_ARCH_GOOGLE_TENSOR) += \ > gs101-oriole.dtb \ > + gs101-oriole.dtbo Overlays in the kernel must be able to be applied to a base DT in the kernel. Add a rule to apply this (hint: a '-dtbs' variable does this similar to -objs variables). > diff --git a/arch/arm64/boot/dts/google/gs101-oriole.dtso b/arch/arm64/boot/dts/google/gs101-oriole.dtso > new file mode 100644 > index 000000000000..50832fd94204 > --- /dev/null > +++ b/arch/arm64/boot/dts/google/gs101-oriole.dtso > @@ -0,0 +1,21 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/* > + * Oriole DVT Device Tree Doesn't DVT mean pre-production? Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel