All of lore.kernel.org
 help / color / mirror / Atom feed
From: Viresh Kumar <viresh.kumar@linaro.org>
To: Manivannan Sadhasivam <manivannan.sadhasivam@linaro.org>
Cc: Johan Hovold <johan@kernel.org>,
	Viresh Kumar <vireshk@kernel.org>, Nishanth Menon <nm@ti.com>,
	Stephen Boyd <sboyd@kernel.org>,
	linux-pm@vger.kernel.org,
	Vincent Guittot <vincent.guittot@linaro.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	andersson@kernel.org, krzysztof.kozlowski+dt@linaro.org,
	linux-kernel@vger.kernel.org, robdclark@gmail.com
Subject: Re: [PATCH 2/2] OPP: Disallow "opp-hz" property without a corresponding clk
Date: Wed, 11 Oct 2023 11:18:58 +0530	[thread overview]
Message-ID: <20231011054858.3vvnr76u5enu5lf6@vireshk-i7> (raw)
In-Reply-To: <20230216064727.GA2420@thinkpad>

On 16-02-23, 12:17, Manivannan Sadhasivam wrote:
> Sorry for the delay. I've submitted the dts changes [1] to handle the CPU clocks
> for the rest of the Qcom SoCs.
> 
> For the Qcom GPUs, I've CCed Rob Clark who is the maintainer.
> 
> Rob, here is the background on the issue that is being discussed in this
> thread:
> 
> Viresh submitted a series [2] back in July to improve the OPP framework, but
> that ended up breaking cpufreq on multiple Qcom SoCs. After investigation, it
> was found that the series was expecting the clocks supplied to the OPP end
> devices like CPUs/GPUs to be modeled in DT. But on Qcom platforms even though
> the clocks for these nodes are supplied by a separate entity, like CPUFreq
> (EPSS/OSM) for CPUs and GMU for GPUs, there was no clock property present in
> the respective nodes. And these nodes are using OPP table to switch frequencies
> dynamically.
> 
> While the series was merged with a hack that still allows the OPP nodes without
> clock property in DT, we came to an agreement that the clock hierarchy should
> be modeled properly.
> 
> So I submitted a series [3] that added clock provider support to cpufreq driver
> and sourced the clock from cpufreq node to CPU nodes in DT.
> 
> Likewise, it should be handled for the adreno GPUs whose clock is managed by
> GMU on newer SoCs. Can you take a look at this?

Any update on this ?

-- 
viresh

  reply	other threads:[~2023-10-11  5:49 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-21  6:57 [PATCH 0/2] OPP: Disallow "opp-hz" property without a corresponding clk Viresh Kumar
2022-11-21  6:57 ` [PATCH 1/2] cpufreq: qcom-cpufreq-hw: Register config_clks helper Viresh Kumar
2022-11-21  6:57 ` [PATCH 2/2] OPP: Disallow "opp-hz" property without a corresponding clk Viresh Kumar
2022-11-21  7:22   ` Johan Hovold
2022-11-21  7:38     ` Viresh Kumar
2022-11-21  7:42       ` Johan Hovold
2022-11-21  8:30         ` Viresh Kumar
2022-11-22 13:26           ` Manivannan Sadhasivam
2022-11-24  4:23             ` Viresh Kumar
2022-11-24  5:24               ` Manivannan Sadhasivam
2022-11-21  7:44       ` Manivannan Sadhasivam
2022-11-21  7:39     ` Manivannan Sadhasivam
2023-01-25  4:21       ` Viresh Kumar
2023-02-16  6:47         ` Manivannan Sadhasivam
2023-10-11  5:48           ` Viresh Kumar [this message]
2023-11-15  6:32             ` Viresh Kumar
2023-11-15  7:55               ` Manivannan Sadhasivam
2023-11-15  8:43                 ` Dmitry Baryshkov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231011054858.3vvnr76u5enu5lf6@vireshk-i7 \
    --to=viresh.kumar@linaro.org \
    --cc=andersson@kernel.org \
    --cc=johan@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pm@vger.kernel.org \
    --cc=manivannan.sadhasivam@linaro.org \
    --cc=nm@ti.com \
    --cc=rafael@kernel.org \
    --cc=robdclark@gmail.com \
    --cc=sboyd@kernel.org \
    --cc=vincent.guittot@linaro.org \
    --cc=vireshk@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.