All of
 help / color / mirror / Atom feed
* [PATCH] wifi: mac80211: fix change_address deadlock during unregister
@ 2023-10-12 10:34 Johannes Berg
  0 siblings, 0 replies; only message in thread
From: Johannes Berg @ 2023-10-12 10:34 UTC (permalink / raw)
  To: linux-wireless; +Cc: Johannes Berg, syzbot+25b3a0b24216651bc2af

From: Johannes Berg <>

When using e.g. bonding, and doing a sequence such as

 # iw wlan0 set type __ap
 # ip link add name bond1 type bond
 # ip link set wlan0 master bond1
 # iw wlan0 interface del

we deadlock, since the wlan0 interface removal will cause
bonding to reset the MAC address of wlan0.

The locking would be somewhat difficult to fix, but since
this only happens during removal, we can simply ignore the
MAC address change at this time.

Signed-off-by: Johannes Berg <>
 net/mac80211/iface.c | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/net/mac80211/iface.c b/net/mac80211/iface.c
index 510f8aead4f9..8061119039a3 100644
--- a/net/mac80211/iface.c
+++ b/net/mac80211/iface.c
@@ -298,6 +298,14 @@ static int ieee80211_change_mac(struct net_device *dev, void *addr)
 	struct ieee80211_local *local = sdata->local;
 	int ret;
+	/*
+	 * This happens during unregistration if there's a bond device
+	 * active (maybe other cases?) and we must get removed from it.
+	 * But we really don't care anymore if it's not registered now.
+	 */
+	if (!dev->ieee80211_ptr->registered)
+		return 0;
 	ret = _ieee80211_change_mac(sdata, addr);

^ permalink raw reply related	[flat|nested] only message in thread

only message in thread, other threads:[~2023-10-12 10:34 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-10-12 10:34 [PATCH] wifi: mac80211: fix change_address deadlock during unregister Johannes Berg

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.