All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Uwe Kleine-König" <u.kleine-koenig@pengutronix.de>
To: Stephen Rothwell <sfr@canb.auug.org.au>,
	Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Linux Next Mailing List <linux-next@vger.kernel.org>
Subject: Re: linux-next: build failure after merge of the rtc tree
Date: Mon, 16 Oct 2023 09:11:44 +0200	[thread overview]
Message-ID: <20231016071144.7nklsco5tszvgotw@pengutronix.de> (raw)
In-Reply-To: <20231016151522.06839671@canb.auug.org.au>

[-- Attachment #1: Type: text/plain, Size: 1239 bytes --]

Hello,

On Mon, Oct 16, 2023 at 03:15:22PM +1100, Stephen Rothwell wrote:
> After merging the rtc tree, today's linux-next build (powerpc
> allyesconfig) failed like this:
> 
> drivers/rtc/rtc-at91rm9200.c:561:13: error: 'at91_rtc_remove' defined but not used [-Werror=unused-function]
>   561 | static void at91_rtc_remove(struct platform_device *pdev)
>       |             ^~~~~~~~~~~~~~~
> cc1: all warnings being treated as errors
> 
> Caused by commit
> 
>   48bc8830fbed ("rtc: at91rm9200: Convert to platform remove callback returning void")

Ah, yes, sorry I missed that. That's what my coccinelle patch does (for
reasons unknown to me). For some other patches I noticed that, but this
one slipped through.

> This function lost its __exit attribute (which includes a "used"
> attribute) and exit_p(x) is NULL when not being built with
> CONFIG_MODULE set.  This build has CONFIG_RTC_DRV_AT91RM9200=y

The better fix is to add the __exit again and I see that's what
Alexandre did in his rtc-next already.

Thanks for cleaning up after me,
Uwe

-- 
Pengutronix e.K.                           | Uwe Kleine-König            |
Industrial Linux Solutions                 | https://www.pengutronix.de/ |

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

  parent reply	other threads:[~2023-10-16  7:12 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-16  4:15 linux-next: build failure after merge of the rtc tree Stephen Rothwell
2023-10-16  4:34 ` Alexandre Belloni
2023-10-16  7:11 ` Uwe Kleine-König [this message]
  -- strict thread matches above, loose matches on Subject: below --
2021-09-27  3:10 Stephen Rothwell
2021-09-27  7:16 ` Romain Perier
2021-08-10  5:54 Stephen Rothwell
2020-03-16  5:15 Stephen Rothwell
2020-03-16  6:58 ` Ran Bi
2020-03-16 10:31   ` Alexandre Belloni
2019-10-04  4:37 Stephen Rothwell
2019-02-11  5:24 Stephen Rothwell
2019-02-08  5:55 Stephen Rothwell
2017-05-31  4:33 Stephen Rothwell
2017-05-31  5:45 ` Heiner Kallweit
2017-05-31  7:19   ` Alexandre Belloni
2017-04-10  6:04 Stephen Rothwell
2017-04-10  7:45 ` Hans de Goede
2017-04-11  0:22   ` Stephen Rothwell
2017-04-11  5:55     ` Alexandre Belloni
2017-04-11  7:52       ` Stephen Rothwell
2017-04-14 10:09         ` Alexandre Belloni
2017-04-14 16:33           ` Stephen Rothwell
2016-11-08  6:41 Stephen Rothwell
2016-11-08 22:21 ` Alexandre Belloni
2015-12-17  5:03 Stephen Rothwell
2015-12-17 11:21 ` Alexandre Belloni
2015-12-17 11:21   ` Alexandre Belloni
2015-12-18 15:30   ` Sasha Levin
2015-12-18 16:43     ` Alexandre Belloni
2015-12-22 19:27       ` Alexandre Belloni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231016071144.7nklsco5tszvgotw@pengutronix.de \
    --to=u.kleine-koenig@pengutronix.de \
    --cc=alexandre.belloni@bootlin.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-next@vger.kernel.org \
    --cc=sfr@canb.auug.org.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.