From: Akihiko Odaki <akihiko.odaki@daynix.com>
Cc: qemu-devel@nongnu.org,
Yuri Benditovich <yuri.benditovich@daynix.com>,
Andrew Melnychenko <andrew@daynix.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
Jason Wang <jasowang@redhat.com>,
Akihiko Odaki <akihiko.odaki@daynix.com>
Subject: [PATCH v5 07/21] tap: Shrink zeroed virtio-net header
Date: Tue, 17 Oct 2023 13:09:13 +0900 [thread overview]
Message-ID: <20231017040932.62997-8-akihiko.odaki@daynix.com> (raw)
In-Reply-To: <20231017040932.62997-1-akihiko.odaki@daynix.com>
tap prepends a zeroed virtio-net header when writing a packet to a
tap with virtio-net header enabled but not in use. This only happens
when s->host_vnet_hdr_len == sizeof(struct virtio_net_hdr).
Signed-off-by: Akihiko Odaki <akihiko.odaki@daynix.com>
---
net/tap.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/net/tap.c b/net/tap.c
index 668d69c0de..4c1eb92076 100644
--- a/net/tap.c
+++ b/net/tap.c
@@ -118,7 +118,7 @@ static ssize_t tap_receive_iov(NetClientState *nc, const struct iovec *iov,
TAPState *s = DO_UPCAST(TAPState, nc, nc);
const struct iovec *iovp = iov;
struct iovec iov_copy[iovcnt + 1];
- struct virtio_net_hdr_mrg_rxbuf hdr = { };
+ struct virtio_net_hdr hdr = { };
if (s->host_vnet_hdr_len && !s->using_vnet_hdr) {
iov_copy[0].iov_base = &hdr;
--
2.42.0
next prev parent reply other threads:[~2023-10-17 4:10 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-17 4:09 [PATCH v5 00/21] virtio-net RSS/hash report fixes and improvements Akihiko Odaki
2023-10-17 4:09 ` [PATCH v5 01/21] tap: Remove tap_probe_vnet_hdr_len() Akihiko Odaki
2023-10-17 4:09 ` [PATCH v5 02/21] tap: Remove qemu_using_vnet_hdr() Akihiko Odaki
2023-10-17 4:09 ` [PATCH v5 03/21] net: Move virtio-net header length assertion Akihiko Odaki
2023-10-17 4:09 ` [PATCH v5 04/21] net: Remove receive_raw() Akihiko Odaki
2023-10-27 6:49 ` Jason Wang
2023-10-27 7:52 ` Akihiko Odaki
2023-10-30 3:06 ` Jason Wang
2023-10-30 4:03 ` Akihiko Odaki
2023-10-30 4:08 ` Jason Wang
2023-10-30 4:16 ` Akihiko Odaki
2023-10-17 4:09 ` [PATCH v5 05/21] tap: Remove tap_receive() Akihiko Odaki
2023-10-17 4:09 ` [PATCH v5 06/21] net: Remove flag propagation Akihiko Odaki
2023-10-17 4:09 ` Akihiko Odaki [this message]
2023-10-17 4:09 ` [PATCH v5 08/21] virtio-net: Copy header only when necessary Akihiko Odaki
2023-10-17 4:09 ` [PATCH v5 09/21] virtio-net: Disable RSS on reset Akihiko Odaki
2023-10-17 4:09 ` [PATCH v5 10/21] virtio-net: Unify the logic to update NIC state for RSS Akihiko Odaki
2023-10-17 4:09 ` [PATCH v5 11/21] virtio-net: Return an error when vhost cannot enable RSS Akihiko Odaki
2023-10-27 7:07 ` Jason Wang
2023-10-27 7:54 ` Akihiko Odaki
2023-10-30 3:44 ` Jason Wang
2023-10-29 22:15 ` Yuri Benditovich
2023-10-17 4:09 ` [PATCH v5 12/21] virtio-net: Always set populate_hash Akihiko Odaki
2023-10-27 7:08 ` Jason Wang
2023-10-27 7:57 ` Akihiko Odaki
2023-10-17 4:09 ` [PATCH v5 13/21] virtio-net: Do not clear VIRTIO_NET_F_RSS Akihiko Odaki
2023-10-17 4:09 ` [PATCH v5 14/21] virtio-net: Do not write hashes to peer buffer Akihiko Odaki
2023-10-17 4:09 ` [PATCH v5 15/21] virtio-net: Do not clear VIRTIO_NET_F_HASH_REPORT Akihiko Odaki
2023-10-27 7:14 ` Jason Wang
2023-10-27 8:07 ` Akihiko Odaki
2023-10-29 21:56 ` Yuri Benditovich
2023-10-30 3:59 ` Akihiko Odaki
2023-10-17 4:09 ` [PATCH v5 16/21] ebpf: Fix RSS error handling Akihiko Odaki
2023-10-17 4:09 ` [PATCH v5 17/21] ebpf: Use standard section name Akihiko Odaki
2023-10-17 4:09 ` [PATCH v5 18/21] ebpf: Simplify error handling Akihiko Odaki
2023-10-17 4:09 ` [PATCH v5 19/21] ebpf: Return 0 when configuration fails Akihiko Odaki
2023-10-17 4:09 ` [PATCH v5 20/21] ebpf: Refactor tun_rss_steering_prog() Akihiko Odaki
2023-10-17 4:09 ` [PATCH v5 21/21] ebpf: Add a separate target for skeleton Akihiko Odaki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20231017040932.62997-8-akihiko.odaki@daynix.com \
--to=akihiko.odaki@daynix.com \
--cc=andrew@daynix.com \
--cc=jasowang@redhat.com \
--cc=mst@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=yuri.benditovich@daynix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.