Re: [RFC PATCH v1 08/10] mm/prmem: Implement Persistent Ramdisk instances.

From: kernel test robot <lkp@intel.com>
To: madvenka@linux.microsoft.com
Cc: oe-kbuild-all@lists.linux.dev
Subject: Re: [RFC PATCH v1 08/10] mm/prmem: Implement Persistent Ramdisk instances.
Date: Wed, 18 Oct 2023 00:39:03 +0800	[thread overview]
Message-ID: <202310180013.sbQM5SPM-lkp@intel.com> (raw)
In-Reply-To: <20231016233215.13090-9-madvenka@linux.microsoft.com>

Hi,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build warnings:

[auto build test WARNING on 2dde18cd1d8fac735875f2e4987f11817cc0bc2c]

url:    https://github.com/intel-lab-lkp/linux/commits/madvenka-linux-microsoft-com/mm-prmem-Allocate-memory-during-boot-for-storing-persistent-data/20231017-194340
base:   2dde18cd1d8fac735875f2e4987f11817cc0bc2c
patch link:    https://lore.kernel.org/r/20231016233215.13090-9-madvenka%40linux.microsoft.com
patch subject: [RFC PATCH v1 08/10] mm/prmem: Implement Persistent Ramdisk instances.
config: m68k-allyesconfig (https://download.01.org/0day-ci/archive/20231018/202310180013.sbQM5SPM-lkp@intel.com/config)
compiler: m68k-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231018/202310180013.sbQM5SPM-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202310180013.sbQM5SPM-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/block/brd.c:323:13: warning: no previous prototype for 'brd_parse' [-Wmissing-prototypes]
     323 | void __init brd_parse(void)
         |             ^~~~~~~~~

vim +/brd_parse +323 drivers/block/brd.c

   322	
 > 323	void __init brd_parse(void)
   324	{
   325		unsigned long		size;
   326		char			*cur, *tmp;
   327		int			i = 0;
   328	
   329		if (!CONFIG_BLK_DEV_PRAM_MAX || !prd_sizes)
   330			return;
   331	
   332		/* Parse persistent ram disk sizes. */
   333		cur = prd_sizes;
   334		do {
   335			/* Get the size of a ramdisk. Sanity check it. */
   336			size = memparse(cur, &tmp);
   337			if (cur == tmp || !size) {
   338				pr_warn("%s: Memory value expected\n", __func__);
   339				return;
   340			}
   341			cur = tmp;
   342	
   343			/* Add the ramdisk size. */
   344			prd_data[i++].size = size;
   345	
   346		} while (*cur++ == ',' && i < CONFIG_BLK_DEV_PRAM_MAX);
   347	}
   348	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki