All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Jouni Högander" <jouni.hogander@intel.com>
To: intel-xe@lists.freedesktop.org
Cc: "Jouni Högander" <jouni.hogander@intel.com>,
	"Jani Nikula" <jani.nikula@intel.com>,
	"Luca Coelho" <luciano.coelho@intel.com>
Subject: [Intel-xe] [PATCH 11/31] drm/i915/display: Move panel_use_ssc module parameter under display
Date: Fri, 27 Oct 2023 10:58:58 +0300	[thread overview]
Message-ID: <20231027075918.2206862-12-jouni.hogander@intel.com> (raw)
In-Reply-To: <20231027075918.2206862-1-jouni.hogander@intel.com>

Signed-off-by: Jouni Högander <jouni.hogander@intel.com>
Acked-by: Jani Nikula <jani.nikula@intel.com>
Reviewed-by: Luca Coelho <luciano.coelho@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20231024124109.384973-8-jouni.hogander@intel.com
(cherry picked from commit 94232d1637c5675f19a434e5118d0d6718ee310a)
---
 drivers/gpu/drm/i915/display/intel_display_params.c | 4 ++++
 drivers/gpu/drm/i915/display/intel_display_params.h | 1 +
 drivers/gpu/drm/i915/display/intel_panel.c          | 4 ++--
 drivers/gpu/drm/i915/i915_params.c                  | 4 ----
 drivers/gpu/drm/i915/i915_params.h                  | 1 -
 5 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_display_params.c b/drivers/gpu/drm/i915/display/intel_display_params.c
index 91e2b5056d63..0813adfa5651 100644
--- a/drivers/gpu/drm/i915/display/intel_display_params.c
+++ b/drivers/gpu/drm/i915/display/intel_display_params.c
@@ -34,6 +34,10 @@ intel_display_param_named_unsafe(lvds_channel_mode, int, 0400,
 	 "Specify LVDS channel mode "
 	 "(0=probe BIOS [default], 1=single-channel, 2=dual-channel)");
 
+intel_display_param_named_unsafe(panel_use_ssc, int, 0400,
+	"Use Spread Spectrum Clock with panels [LVDS/eDP] "
+	"(default: auto from VBT)");
+
 intel_display_param_named_unsafe(enable_fbc, int, 0400,
 	"Enable frame buffer compression for power savings "
 	"(default: -1 (use per-chip default))");
diff --git a/drivers/gpu/drm/i915/display/intel_display_params.h b/drivers/gpu/drm/i915/display/intel_display_params.h
index 09bd6614b813..ceed4af192c9 100644
--- a/drivers/gpu/drm/i915/display/intel_display_params.h
+++ b/drivers/gpu/drm/i915/display/intel_display_params.h
@@ -26,6 +26,7 @@ struct drm_i915_private;
 #define INTEL_DISPLAY_PARAMS_FOR_EACH(param) \
 	param(char *, vbt_firmware, NULL, 0400) \
 	param(int, lvds_channel_mode, 0, 0400) \
+	param(int, panel_use_ssc, -1, 0600) \
 	param(int, enable_fbc, -1, 0600) \
 	param(int, enable_psr, -1, 0600) \
 	param(bool, psr_safest_params, false, 0400) \
diff --git a/drivers/gpu/drm/i915/display/intel_panel.c b/drivers/gpu/drm/i915/display/intel_panel.c
index 483beedac5b8..0d8e5320a4f8 100644
--- a/drivers/gpu/drm/i915/display/intel_panel.c
+++ b/drivers/gpu/drm/i915/display/intel_panel.c
@@ -46,8 +46,8 @@
 
 bool intel_panel_use_ssc(struct drm_i915_private *i915)
 {
-	if (i915->params.panel_use_ssc >= 0)
-		return i915->params.panel_use_ssc != 0;
+	if (i915->display.params.panel_use_ssc >= 0)
+		return i915->display.params.panel_use_ssc != 0;
 	return i915->display.vbt.lvds_use_ssc &&
 		!intel_has_quirk(i915, QUIRK_LVDS_SSC_DISABLE);
 }
diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/drm/i915/i915_params.c
index ea55cc2c4854..4123424b2c2e 100644
--- a/drivers/gpu/drm/i915/i915_params.c
+++ b/drivers/gpu/drm/i915/i915_params.c
@@ -72,10 +72,6 @@ i915_param_named_unsafe(enable_dc, int, 0400,
 	"(-1=auto [default]; 0=disable; 1=up to DC5; 2=up to DC6; "
 	"3=up to DC5 with DC3CO; 4=up to DC6 with DC3CO)");
 
-i915_param_named_unsafe(panel_use_ssc, int, 0400,
-	"Use Spread Spectrum Clock with panels [LVDS/eDP] "
-	"(default: auto from VBT)");
-
 i915_param_named_unsafe(vbt_sdvo_panel_type, int, 0400,
 	"Override/Ignore selection of SDVO panel mode in the VBT "
 	"(-2=ignore, -1=auto [default], index in VBT BIOS table)");
diff --git a/drivers/gpu/drm/i915/i915_params.h b/drivers/gpu/drm/i915/i915_params.h
index 03ec2c2b589d..0bd365889e73 100644
--- a/drivers/gpu/drm/i915/i915_params.h
+++ b/drivers/gpu/drm/i915/i915_params.h
@@ -47,7 +47,6 @@ struct drm_printer;
  */
 #define I915_PARAMS_FOR_EACH(param) \
 	param(int, modeset, -1, 0400) \
-	param(int, panel_use_ssc, -1, 0600) \
 	param(int, vbt_sdvo_panel_type, -1, 0400) \
 	param(int, enable_dc, -1, 0400) \
 	param(bool, enable_dpt, true, 0400) \
-- 
2.34.1


  parent reply	other threads:[~2023-10-27  8:00 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-10-27  7:58 [Intel-xe] [PATCH 00/31] Backport display parameter patches Jouni Högander
2023-10-27  7:58 ` [Intel-xe] [PATCH 01/31] Revert "FIXME: drm/i915: xe doesn't have i915_modparams.verbose_state_checks" Jouni Högander
2023-10-27  7:58 ` [Intel-xe] [PATCH 02/31] drm/i915: convert INTEL_DISPLAY_ENABLED() into a function Jouni Högander
2023-10-27  7:58 ` [Intel-xe] [PATCH 03/31] drm/i915: separate display runtime info init Jouni Högander
2023-10-27  7:58 ` [Intel-xe] [PATCH 04/31] drm/i915: separate subplatform init and runtime feature init Jouni Högander
2023-10-27  7:58 ` [Intel-xe] [PATCH 05/31] drm/i915/display: Add framework to add parameters specific to display Jouni Högander
2023-10-27  7:58 ` [Intel-xe] [PATCH 06/31] drm/i915/display: Dump also display parameters Jouni Högander
2023-10-27  7:58 ` [Intel-xe] [PATCH 07/31] drm/i915/display: Move enable_fbc module parameter under display Jouni Högander
2023-10-27  7:58 ` [Intel-xe] [PATCH 08/31] drm/i915/display: Move psr related module parameters " Jouni Högander
2023-10-27  7:58 ` [Intel-xe] [PATCH 09/31] drm/i915/display: Move vbt_firmware module parameter " Jouni Högander
2023-10-27  7:58 ` [Intel-xe] [PATCH 10/31] drm/i915/display: Move lvds_channel_mode " Jouni Högander
2023-10-27  7:58 ` Jouni Högander [this message]
2023-10-27  7:58 ` [Intel-xe] [PATCH 12/31] drm/i915/display: Move vbt_sdvo_panel_type " Jouni Högander
2023-10-27  7:59 ` [Intel-xe] [PATCH 13/31] drm/i915/display: Move enable_dc " Jouni Högander
2023-10-27  7:59 ` [Intel-xe] [PATCH 14/31] drm/i915/display: Move enable_dpt " Jouni Högander
2023-10-27  7:59 ` [Intel-xe] [PATCH 15/31] drm/i915/display: Move enable_sagv " Jouni Högander
2023-10-27  7:59 ` [Intel-xe] [PATCH 16/31] drm/i915/display: Move disable_power_well " Jouni Högander
2023-10-27  7:59 ` [Intel-xe] [PATCH 17/31] drm/i915/display: Move enable_ips " Jouni Högander
2023-10-27  7:59 ` [Intel-xe] [PATCH 18/31] drm/i915/display: Move invert_brightness " Jouni Högander
2023-10-27  7:59 ` [Intel-xe] [PATCH 19/31] drm/i915/display: Move edp_vswing " Jouni Högander
2023-10-27  7:59 ` [Intel-xe] [PATCH 20/31] drm/i915/display: Move enable_dpcd_backlight " Jouni Högander
2023-10-27  7:59 ` [Intel-xe] [PATCH 21/31] drm/i915/display: Move load_detect_test " Jouni Högander
2023-10-27  7:59 ` [Intel-xe] [PATCH 22/31] drm/i915/display: Move force_reset_modeset_test " Jouni Högander
2023-10-27  7:59 ` [Intel-xe] [PATCH 23/31] drm/i915/display: Move disable_display " Jouni Högander
2023-10-27  7:59 ` [Intel-xe] [PATCH 24/31] drm/i915/display: Use device parameters instead of module in I915_STATE_WARN Jouni Högander
2023-10-27  7:59 ` [Intel-xe] [PATCH 25/31] drm/i915/display: Move verbose_state_checks under display Jouni Högander
2023-10-27  7:59 ` [Intel-xe] [PATCH 26/31] drm/i915/display: Move nuclear_pageflip " Jouni Högander
2023-10-27  7:59 ` [Intel-xe] [PATCH 27/31] drm/i915/display: Move enable_dp_mst " Jouni Högander
2023-10-27  7:59 ` [Intel-xe] [PATCH 28/31] fixup! drm/xe/display: Implement display support Jouni Högander
2023-10-27  7:59 ` [Intel-xe] [PATCH 29/31] " Jouni Högander
2023-10-27  7:59 ` [Intel-xe] [PATCH 30/31] " Jouni Högander
2023-10-27  7:59 ` [Intel-xe] [PATCH 31/31] " Jouni Högander
2023-10-27  8:03 ` [Intel-xe] ✓ CI.Patch_applied: success for Backport display parameter patches Patchwork
2023-10-27  8:04 ` [Intel-xe] ✗ CI.checkpatch: warning " Patchwork
2023-10-27  8:05 ` [Intel-xe] ✓ CI.KUnit: success " Patchwork
2023-10-27  8:13 ` [Intel-xe] ✓ CI.Build: " Patchwork
2023-10-27  8:13 ` [Intel-xe] ✓ CI.Hooks: " Patchwork
2023-10-27  8:14 ` [Intel-xe] ✗ CI.checksparse: warning " Patchwork
2023-10-27  8:42 ` [Intel-xe] ✓ CI.BAT: success " Patchwork
2023-10-27  8:47 ` [Intel-xe] [PATCH 00/31] " Jani Nikula
2023-10-30  6:50   ` Hogander, Jouni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231027075918.2206862-12-jouni.hogander@intel.com \
    --to=jouni.hogander@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=jani.nikula@intel.com \
    --cc=luciano.coelho@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.