From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 36A8F12E51 for ; Sun, 29 Oct 2023 22:54:58 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="YnmNtxG8" Received: by smtp.kernel.org (Postfix) with ESMTPSA id F2808C433CA; Sun, 29 Oct 2023 22:54:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1698620098; bh=9IB4jibcd1bRPkDCXBfrMALn/uwVsE1uo1hzrNtcqdA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YnmNtxG86mgc4DTzk2Yyvcd7rQvOi4DY5q+PKC8UpZQYxpOltjlsh5y5+mRec4Fe8 GMlubFX5u/4qB6EvdiHGIx0dGITqB2Mr3ygHvRo2iq434b10k2nL2LyfP+E50JsPae IhlJ6IoM3nYE2tgPW9Exb8IQaDo93rsvUWUEHaaDoRnJ54oN4/6jLY12hpC88uPsDZ TWrlQcQ6BSWwIZbi57auT4Yg+j2kGqEDOP6DImLkG2/zXx0tJoIaSUTEeDxwnWYt/6 im2NJOool3GrWMV4aIbY+akT02qxhQUuagDNsfPuVDP1HbMzEvoPXmQ5OrgoZDKyHR 5hi2P4eSOIA8Q== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Konstantin Komarov , Sasha Levin , ntfs3@lists.linux.dev Subject: [PATCH AUTOSEL 6.5 10/52] fs/ntfs3: Do not allow to change label if volume is read-only Date: Sun, 29 Oct 2023 18:52:57 -0400 Message-ID: <20231029225441.789781-10-sashal@kernel.org> X-Mailer: git-send-email 2.42.0 In-Reply-To: <20231029225441.789781-1-sashal@kernel.org> References: <20231029225441.789781-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: ntfs3@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.5.9 Content-Transfer-Encoding: 8bit From: Konstantin Komarov [ Upstream commit e52dce610a2d53bf2b5e94a8843c71cb73a91ea5 ] Signed-off-by: Konstantin Komarov Signed-off-by: Sasha Levin --- fs/ntfs3/super.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/fs/ntfs3/super.c b/fs/ntfs3/super.c index 055c3764af26e..9d84f66e6a458 100644 --- a/fs/ntfs3/super.c +++ b/fs/ntfs3/super.c @@ -498,7 +498,12 @@ static ssize_t ntfs3_label_write(struct file *file, const char __user *buffer, struct super_block *sb = pde_data(file_inode(file)); struct ntfs_sb_info *sbi = sb->s_fs_info; ssize_t ret = count; - u8 *label = kmalloc(count, GFP_NOFS); + u8 *label; + + if (sb_rdonly(sb)) + return -EROFS; + + label = kmalloc(count, GFP_NOFS); if (!label) return -ENOMEM; -- 2.42.0