From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from lindbergh.monkeyblade.net (lindbergh.monkeyblade.net [23.128.96.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2AF5B468F for ; Mon, 13 Nov 2023 07:04:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=none Received: from metis.whiteo.stw.pengutronix.de (metis.whiteo.stw.pengutronix.de [IPv6:2a0a:edc0:2:b01:1d::104]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 550BB10EB for ; Sun, 12 Nov 2023 23:04:51 -0800 (PST) Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r2Qzx-0001wn-TD; Mon, 13 Nov 2023 08:04:41 +0100 Received: from [2a0a:edc0:2:b01:1d::c0] (helo=ptx.whiteo.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r2Qzv-008gAp-J9; Mon, 13 Nov 2023 08:04:39 +0100 Received: from sha by ptx.whiteo.stw.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1r2Qzv-001lKu-GQ; Mon, 13 Nov 2023 08:04:39 +0100 Date: Mon, 13 Nov 2023 08:04:39 +0100 From: Sascha Hauer To: Stefan Wahren Cc: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Shawn Guo , kernel@pengutronix.de, Fabio Estevam , linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org Subject: Re: [PATCH] gpio: mxc: implement get_direction callback Message-ID: <20231113070439.GL3359458@pengutronix.de> References: <20231112192428.6832-1-wahrenst@gmx.net> Precedence: bulk X-Mailing-List: linux-gpio@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231112192428.6832-1-wahrenst@gmx.net> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-gpio@vger.kernel.org Hi Stefan, On Sun, Nov 12, 2023 at 08:24:28PM +0100, Stefan Wahren wrote: > gpiolib's gpiod_get_direction() function returns an erro if > .get_direction callback is not defined. > > The patch implements the callback for IMX platform which is useful > for debugging and also the kernel docs about struct gpio_chip > recommends it. > > Inspired by drivers/gpio/gpio-mxs.c > > Signed-off-by: Stefan Wahren > --- > drivers/gpio/gpio-mxc.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/drivers/gpio/gpio-mxc.c b/drivers/gpio/gpio-mxc.c > index 4cb455b2bdee..ad8a4c73d47b 100644 > --- a/drivers/gpio/gpio-mxc.c > +++ b/drivers/gpio/gpio-mxc.c > @@ -418,6 +418,18 @@ static void mxc_update_irq_chained_handler(struct mxc_gpio_port *port, bool enab > } > } > > +static int mxc_gpio_get_direction(struct gpio_chip *gc, unsigned int offset) > +{ > + struct mxc_gpio_port *port = gpiochip_get_data(gc); > + u32 dir; > + > + dir = readl(port->base + GPIO_GDIR); > + if (dir & BIT(offset)) > + return GPIO_LINE_DIRECTION_OUT; > + > + return GPIO_LINE_DIRECTION_IN; > +} > + > static int mxc_gpio_probe(struct platform_device *pdev) > { > struct device_node *np = pdev->dev.of_node; > @@ -490,6 +502,7 @@ static int mxc_gpio_probe(struct platform_device *pdev) > port->gc.request = mxc_gpio_request; > port->gc.free = mxc_gpio_free; > port->gc.to_irq = mxc_gpio_to_irq; > + port->gc.get_direction = mxc_gpio_get_direction; The driver passes port->base + GPIO_GDIR as *dirout argument to bgpio_init(). This should result in the .get_direction hook already being set to bgpio_get_dir() in the bgpio code. Doesn't this work as expected? Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7DE50C4332F for ; Mon, 13 Nov 2023 07:05:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tnyZBm9TLQibwEjSxFVKf5t+eehUs5v8l3pq2X5hoAk=; b=fuXYFHsmtpaR2f BIb4zao3mhPOlgvWAYPqeEPwpTOXFh7on7fFANwzO4I0nPZD5NDyri7zJv/F5ExSNDDNjFYhFzhNN CWm5CAPH48ydHwmCQERdPEtuXsd2/XzPjuoyUXNxKHGnnB7E9dFDbgx20cU7VjJKNq7rwdf2irIEw 2glVN4uyqUD7XOPR8om1zy2O0o3vWdkPCkvFILySQncBj08SebVyR7Qw+RfvyXFy2Kq0aVZ91n4Lw 5T5aPgr/NV9mNV5qv9tAMzGD+TmZpZybQ8cHLCc+IKWD4XMMbv+Nj+jh1hefPxJkEGhsWT8cpJ+yo F/YfegLJauYz9qSf2iiw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r2R0D-00DPUC-1y; Mon, 13 Nov 2023 07:04:57 +0000 Received: from metis.whiteo.stw.pengutronix.de ([2a0a:edc0:2:b01:1d::104]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r2R09-00DPTc-2F for linux-arm-kernel@lists.infradead.org; Mon, 13 Nov 2023 07:04:55 +0000 Received: from drehscheibe.grey.stw.pengutronix.de ([2a0a:edc0:0:c01:1d::a2]) by metis.whiteo.stw.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1r2Qzx-0001wn-TD; Mon, 13 Nov 2023 08:04:41 +0100 Received: from [2a0a:edc0:2:b01:1d::c0] (helo=ptx.whiteo.stw.pengutronix.de) by drehscheibe.grey.stw.pengutronix.de with esmtps (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1r2Qzv-008gAp-J9; Mon, 13 Nov 2023 08:04:39 +0100 Received: from sha by ptx.whiteo.stw.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1r2Qzv-001lKu-GQ; Mon, 13 Nov 2023 08:04:39 +0100 Date: Mon, 13 Nov 2023 08:04:39 +0100 From: Sascha Hauer To: Stefan Wahren Cc: Linus Walleij , Bartosz Golaszewski , Andy Shevchenko , Shawn Guo , kernel@pengutronix.de, Fabio Estevam , linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org, linux-gpio@vger.kernel.org Subject: Re: [PATCH] gpio: mxc: implement get_direction callback Message-ID: <20231113070439.GL3359458@pengutronix.de> References: <20231112192428.6832-1-wahrenst@gmx.net> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231112192428.6832-1-wahrenst@gmx.net> X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2a0a:edc0:0:c01:1d::a2 X-SA-Exim-Mail-From: sha@pengutronix.de X-SA-Exim-Scanned: No (on metis.whiteo.stw.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231112_230453_738231_E0E56183 X-CRM114-Status: GOOD ( 28.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Stefan, On Sun, Nov 12, 2023 at 08:24:28PM +0100, Stefan Wahren wrote: > gpiolib's gpiod_get_direction() function returns an erro if > .get_direction callback is not defined. > > The patch implements the callback for IMX platform which is useful > for debugging and also the kernel docs about struct gpio_chip > recommends it. > > Inspired by drivers/gpio/gpio-mxs.c > > Signed-off-by: Stefan Wahren > --- > drivers/gpio/gpio-mxc.c | 13 +++++++++++++ > 1 file changed, 13 insertions(+) > > diff --git a/drivers/gpio/gpio-mxc.c b/drivers/gpio/gpio-mxc.c > index 4cb455b2bdee..ad8a4c73d47b 100644 > --- a/drivers/gpio/gpio-mxc.c > +++ b/drivers/gpio/gpio-mxc.c > @@ -418,6 +418,18 @@ static void mxc_update_irq_chained_handler(struct mxc_gpio_port *port, bool enab > } > } > > +static int mxc_gpio_get_direction(struct gpio_chip *gc, unsigned int offset) > +{ > + struct mxc_gpio_port *port = gpiochip_get_data(gc); > + u32 dir; > + > + dir = readl(port->base + GPIO_GDIR); > + if (dir & BIT(offset)) > + return GPIO_LINE_DIRECTION_OUT; > + > + return GPIO_LINE_DIRECTION_IN; > +} > + > static int mxc_gpio_probe(struct platform_device *pdev) > { > struct device_node *np = pdev->dev.of_node; > @@ -490,6 +502,7 @@ static int mxc_gpio_probe(struct platform_device *pdev) > port->gc.request = mxc_gpio_request; > port->gc.free = mxc_gpio_free; > port->gc.to_irq = mxc_gpio_to_irq; > + port->gc.get_direction = mxc_gpio_get_direction; The driver passes port->base + GPIO_GDIR as *dirout argument to bgpio_init(). This should result in the .get_direction hook already being set to bgpio_get_dir() in the bgpio code. Doesn't this work as expected? Sascha -- Pengutronix e.K. | | Steuerwalder Str. 21 | http://www.pengutronix.de/ | 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 | Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 | _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel