Re: [PATCH v6 4/9] landlock: Add IOCTL access right

From: kernel test robot <lkp@intel.com>
To: "Günther Noack" <gnoack@google.com>
Cc: oe-kbuild-all@lists.linux.dev
Subject: Re: [PATCH v6 4/9] landlock: Add IOCTL access right
Date: Sun, 26 Nov 2023 15:23:26 +0800	[thread overview]
Message-ID: <202311261403.9hYewImp-lkp@intel.com> (raw)
In-Reply-To: <20231124173026.3257122-5-gnoack@google.com>

Hi Günther,

kernel test robot noticed the following build errors:

[auto build test ERROR on shuah-kselftest/next]
[also build test ERROR on shuah-kselftest/fixes linus/master v6.7-rc2]
[cannot apply to next-20231124]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/G-nther-Noack/selftests-landlock-Rename-permitted-to-allowed-in-ftruncate-tests/20231125-023121
base:   https://git.kernel.org/pub/scm/linux/kernel/git/shuah/linux-kselftest.git next
patch link:    https://lore.kernel.org/r/20231124173026.3257122-5-gnoack%40google.com
patch subject: [PATCH v6 4/9] landlock: Add IOCTL access right
config: powerpc64-randconfig-r123-20231126 (https://download.01.org/0day-ci/archive/20231126/202311261403.9hYewImp-lkp@intel.com/config)
compiler: clang version 14.0.6 (https://github.com/llvm/llvm-project.git f28c006a5895fc0e329fe15fead81e37457cb1d1)
reproduce: (https://download.01.org/0day-ci/archive/20231126/202311261403.9hYewImp-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202311261403.9hYewImp-lkp@intel.com/

All errors (new ones prefixed by >>):

>> security/landlock/fs.c:195:16: error: static_assert expression is not an integral constant expression
           static_assert((ioctl_groups & LANDLOCK_MASK_ACCESS_FS) == ioctl_groups);
           ~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/build_bug.h:77:50: note: expanded from macro 'static_assert'
   #define static_assert(expr, ...) __static_assert(expr, ##__VA_ARGS__, #expr)
                                    ~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/build_bug.h:78:56: note: expanded from macro '__static_assert'
   #define __static_assert(expr, msg, ...) _Static_assert(expr, msg)
                                                          ^~~~
   1 error generated.

vim +195 security/landlock/fs.c

   181	
   182	/**
   183	 * landlock_expand_access_fs() - Returns @access with the synthetic IOCTL group
   184	 * flags enabled if necessary.
   185	 *
   186	 * @handled: Handled FS access rights.
   187	 * @access: FS access rights to expand.
   188	 *
   189	 * Returns: @access expanded by the necessary flags for the synthetic IOCTL
   190	 * access rights.
   191	 */
   192	static access_mask_t landlock_expand_access_fs(const access_mask_t handled,
   193						       const access_mask_t access)
   194	{
 > 195		static_assert((ioctl_groups & LANDLOCK_MASK_ACCESS_FS) == ioctl_groups);
   196	
   197		return access |
   198		       expand_ioctl(handled, access, LANDLOCK_ACCESS_FS_WRITE_FILE,
   199				    LANDLOCK_ACCESS_FS_IOCTL_GROUP1 |
   200					    LANDLOCK_ACCESS_FS_IOCTL_GROUP2 |
   201					    LANDLOCK_ACCESS_FS_IOCTL_GROUP4) |
   202		       expand_ioctl(handled, access, LANDLOCK_ACCESS_FS_READ_FILE,
   203				    LANDLOCK_ACCESS_FS_IOCTL_GROUP1 |
   204					    LANDLOCK_ACCESS_FS_IOCTL_GROUP2 |
   205					    LANDLOCK_ACCESS_FS_IOCTL_GROUP3) |
   206		       expand_ioctl(handled, access, LANDLOCK_ACCESS_FS_READ_DIR,
   207				    LANDLOCK_ACCESS_FS_IOCTL_GROUP1);
   208	}
   209	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki