All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] platform/mellanox: Add a null pointer check in mlxbf_pmc_create_groups
@ 2023-11-27  6:34 Kunwu Chan
  2023-11-27 12:24 ` Hans de Goede
                   ` (2 more replies)
  0 siblings, 3 replies; 7+ messages in thread
From: Kunwu Chan @ 2023-11-27  6:34 UTC (permalink / raw)
  To: hdegoede, ilpo.jarvinen, vadimp, jiri, shravankr
  Cc: kunwu.chan, platform-driver-x86, linux-kernel, Kunwu Chan

devm_kasprintf() returns a pointer to dynamically allocated memory
which can be NULL upon failure.

Fixes: 1a218d312e65 ("platform/mellanox: mlxbf-pmc: Add Mellanox BlueField PMC driver")
Signed-off-by: Kunwu Chan <chentao@kylinos.cn>
---
 drivers/platform/mellanox/mlxbf-pmc.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/drivers/platform/mellanox/mlxbf-pmc.c b/drivers/platform/mellanox/mlxbf-pmc.c
index 0b427fc24a96..59bbe5e13f6b 100644
--- a/drivers/platform/mellanox/mlxbf-pmc.c
+++ b/drivers/platform/mellanox/mlxbf-pmc.c
@@ -1882,6 +1882,8 @@ static int mlxbf_pmc_create_groups(struct device *dev, int blk_num)
 	pmc->block[blk_num].block_attr_grp.attrs = pmc->block[blk_num].block_attr;
 	pmc->block[blk_num].block_attr_grp.name = devm_kasprintf(
 		dev, GFP_KERNEL, pmc->block_name[blk_num]);
+	if (!pmc->block[blk_num].block_attr_grp.name)
+		return -ENOMEM;
 	pmc->groups[pmc->group_num] = &pmc->block[blk_num].block_attr_grp;
 	pmc->group_num++;
 
-- 
2.34.1


^ permalink raw reply related	[flat|nested] 7+ messages in thread

end of thread, other threads:[~2023-12-01  3:21 UTC | newest]

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-27  6:34 [PATCH] platform/mellanox: Add a null pointer check in mlxbf_pmc_create_groups Kunwu Chan
2023-11-27 12:24 ` Hans de Goede
2023-11-28  9:51 ` Ilpo Järvinen
     [not found] ` <1701224213463629.329.seg@mailgw>
2023-11-30  9:43   ` Kunwu Chan
2023-11-30 15:25     ` Ilpo Järvinen
2023-11-30 16:01       ` Vadim Pasternak
2023-12-01  3:20         ` Kunwu Chan

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.