All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: netdev <netdev@vger.kernel.org>
Cc: Linus Walleij <linus.walleij@linaro.org>,
	Christian Marangi <ansuelsmth@gmail.com>,
	Vladimir Oltean <vladimir.oltean@nxp.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	Andrew Lunn <andrew@lunn.ch>
Subject: [PATCH RFC net-next 0/8] DSA LED infrastructure, mv88e6xxx and QCA8K
Date: Wed, 29 Nov 2023 00:21:27 +0100	[thread overview]
Message-ID: <20231128232135.358638-1-andrew@lunn.ch> (raw)

This patchset extends the DSA core to add support for port LEDs being
controlled via sys/class/leds, and offloading blinking via
ledtrig-netdev. The core parses the device tree binding, and registers
LEDs. The DSA switch ops structure is extended with the needed
functions.

The mv88e6xxx support is partially added. Support for setting the
brightness and blinking is provided, but offloading of blinking is not
yet available. To demonstrate this, the wrt1900ac device tree is
extended with LEDs.

The existing QCA8K code is refactored to make use of this shared code.

RFC:

Linus, can you rework your code into this for offloading blinking ?
And test with ports 5 & 6.

Christian: Please test QCA8K. I would not be surprised if there is an
off-by-one.

This code can also be found in

https://github.com/lunn/ v6.7-rc2-net-next-mv88e6xxx-leds

Andrew Lunn (8):
  net: dsa: mv88e6xxx: Add helpers for 6352 LED blink and brightness
  net: dsa: mv88e6xxx: Tie the low level LED functions to device ops
  net: dsa: Plumb LED brightnes and blink into switch API
  dsa: Create port LEDs based on DT binding
  dsa: Plumb in LED calls needed for hardware offload
  dsa: mv88e6xxx: Plumb in LED offload functions
  arm: boot: dts: mvebu: linksys-mamba: Add Ethernet LEDs
  dsa: qca8k: Use DSA common code for LEDs

 .../dts/marvell/armada-xp-linksys-mamba.dts   |  66 +++++
 drivers/net/dsa/mv88e6xxx/chip.c              | 103 +++++++
 drivers/net/dsa/mv88e6xxx/chip.h              |  14 +
 drivers/net/dsa/mv88e6xxx/port.c              |  99 +++++++
 drivers/net/dsa/mv88e6xxx/port.h              |  76 +++++-
 drivers/net/dsa/qca/qca8k-8xxx.c              |  11 +-
 drivers/net/dsa/qca/qca8k-leds.c              | 255 +++---------------
 drivers/net/dsa/qca/qca8k.h                   |   9 -
 drivers/net/dsa/qca/qca8k_leds.h              |  21 +-
 include/net/dsa.h                             |  17 ++
 net/dsa/dsa.c                                 | 190 +++++++++++++
 11 files changed, 620 insertions(+), 241 deletions(-)

-- 
2.42.0


             reply	other threads:[~2023-11-28 23:21 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-11-28 23:21 Andrew Lunn [this message]
2023-11-28 23:21 ` [PATCH RFC net-next 1/8] net: dsa: mv88e6xxx: Add helpers for 6352 LED blink and brightness Andrew Lunn
2023-11-28 23:21 ` [PATCH RFC net-next 2/8] net: dsa: mv88e6xxx: Tie the low level LED functions to device ops Andrew Lunn
2023-11-28 23:21 ` [PATCH RFC net-next 3/8] net: dsa: Plumb LED brightnes and blink into switch API Andrew Lunn
2023-11-28 23:21 ` [PATCH RFC net-next 4/8] dsa: Create port LEDs based on DT binding Andrew Lunn
2023-11-29  1:46   ` Christian Marangi
2023-11-29 19:40   ` Simon Horman
2023-11-29 20:07     ` Andrew Lunn
2023-11-28 23:21 ` [PATCH RFC net-next 5/8] dsa: Plumb in LED calls needed for hardware offload Andrew Lunn
2023-11-28 23:21 ` [PATCH RFC net-next 6/8] dsa: mv88e6xxx: Plumb in LED offload functions Andrew Lunn
2023-11-28 23:21 ` [PATCH RFC net-next 7/8] arm: boot: dts: mvebu: linksys-mamba: Add Ethernet LEDs Andrew Lunn
2023-11-28 23:21 ` [PATCH RFC net-next 8/8] dsa: qca8k: Use DSA common code for LEDs Andrew Lunn
2023-11-29  1:55   ` Christian Marangi
2023-11-29  2:16     ` Andrew Lunn
2023-11-29  2:23       ` Christian Marangi
2023-11-29  1:57 ` [PATCH RFC net-next 0/8] DSA LED infrastructure, mv88e6xxx and QCA8K Christian Marangi
2023-11-29 12:38 ` Vladimir Oltean
2023-11-29 15:13   ` Andrew Lunn
2023-11-29 15:43     ` Vladimir Oltean
2023-11-29 16:27       ` Andrew Lunn
2023-11-29 16:44         ` Vladimir Oltean
2023-11-29 21:51 ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231128232135.358638-1-andrew@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=ansuelsmth@gmail.com \
    --cc=f.fainelli@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=netdev@vger.kernel.org \
    --cc=vladimir.oltean@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.