From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ziepe.ca header.i=@ziepe.ca header.b="TGmOsoon" Received: from mail-oa1-x2d.google.com (mail-oa1-x2d.google.com [IPv6:2001:4860:4864:20::2d]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id AA1371B3 for ; Wed, 29 Nov 2023 16:46:05 -0800 (PST) Received: by mail-oa1-x2d.google.com with SMTP id 586e51a60fabf-1f9e0e44fecso168269fac.3 for ; Wed, 29 Nov 2023 16:46:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1701305165; x=1701909965; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=DGfesKWk6hIGgQDOksuxdOXdV/4i0gK7DjvWJInD9Kc=; b=TGmOsoongOJ3mRPh4D7y7BkjcC+Ovj+n8PtFRQ5xqzhbN6VxHK1FYnmCON6QSr1KrS YHDqY7Ux1uRrcyuQF8GIbPifdXJriHEkq0awWaZJvwFPB2KJc1hgqhB9i3dretRTqaK+ fv8XVoDFy7vPm1MQRjreU2JAQbgzEhfWbhfoAYIF4prP1euOnnbZ1i43DkEhaiseCCid pGk+EP4XiHzMfE6K8D4Nfv44zVAHM+2NEea5duFO59VyeKGP9yucR71saRuDwllsa5Fx Dxhe+GOb2B3Hhk5jytTjcAaHg9/b+vqs0AcwJR2sOnaPvhKAVBTfQH0PhZMDYnPd2uc8 j6HA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701305165; x=1701909965; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DGfesKWk6hIGgQDOksuxdOXdV/4i0gK7DjvWJInD9Kc=; b=nCUDE/nOBK6XPaqhdIIFem8qHZOdkdBUdWhek3RhvVTiaISnlcTeWc4hLOaBYVUJni JMx/tTT/1BGCCx4Ks/wYCFjzC2/Qfz9csUJoAtqEwQ2jR5hw6k5O3a6nPtTp274qbxQZ IT3a4DcCGXf/4RFxrwcb0fCmh8M/Ef6UwWZ1Y1ln5aQZhzrst/hhiBvjAy/LeNHBo1kn m5pqSkydPoB2ObvotWTpEZU+ZlytH9v7gFEfxUq4xgOhbHq2KA4v4eV+4XSFK/f63rkP 1Jt10LlubaN66+2vDSXIAQzO6QVFVC2L5j6OTe8lXuurBM6L4s5TlPIHI9TIWY9pzQs/ gdmg== X-Gm-Message-State: AOJu0YxZ44rrF0MlHVzn8CdkkgMiYCBDlwgkNoj2TPiczfIxf8EnOpQh H378/ZVD7BAxtkZkjM6LirbZ9g== X-Google-Smtp-Source: AGHT+IH0QnaZj4Srt21JiVw/aqbEQCLMM8IUp7yXueL4iz88oaZRnRpsZVc5esr77Xqw2FDtMOcfOA== X-Received: by 2002:a05:6870:3326:b0:1fa:2b51:cc8b with SMTP id x38-20020a056870332600b001fa2b51cc8bmr18739526oae.32.1701305164620; Wed, 29 Nov 2023 16:46:04 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-134-23-187.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.134.23.187]) by smtp.gmail.com with ESMTPSA id mn13-20020a0568700c8d00b001fa3ab0a3bdsm2224484oab.31.2023.11.29.16.46.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 16:46:04 -0800 (PST) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1r8VBr-005r2g-CG; Wed, 29 Nov 2023 20:46:03 -0400 Date: Wed, 29 Nov 2023 20:46:03 -0400 From: Jason Gunthorpe To: Robin Murphy Cc: Joerg Roedel , Christoph Hellwig , Vineet Gupta , Russell King , Catalin Marinas , Will Deacon , Huacai Chen , WANG Xuerui , Thomas Bogendoerfer , Paul Walmsley , Palmer Dabbelt , Albert Ou , Lorenzo Pieralisi , Hanjun Guo , Sudeep Holla , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Suravee Suthikulpanit , David Woodhouse , Lu Baolu , Niklas Schnelle , Matthew Rosato , Gerald Schaefer , Jean-Philippe Brucker , Rob Herring , Frank Rowand , Marek Szyprowski , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, iommu@lists.linux.dev, devicetree@vger.kernel.org Subject: Re: [PATCH 2/7] OF: Simplify DMA range calculations Message-ID: <20231130004603.GB1394392@ziepe.ca> References: <73becf4a75f15662b2dda5fba7cfeacdf3d866f8.1701268753.git.robin.murphy@arm.com> Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <73becf4a75f15662b2dda5fba7cfeacdf3d866f8.1701268753.git.robin.murphy@arm.com> On Wed, Nov 29, 2023 at 05:42:59PM +0000, Robin Murphy wrote: > Juggling start, end, and size values for a range is somewhat redundant > and a little hard to follow. Consolidate down to just using inclusive > start and end, which saves us worrying about size overflows for full > 64-bit ranges (note that passing a potentially-overflowed value through > to arch_setup_dma_ops() is benign for all current implementations, and > this is working towards removing that anyway). In iommu code I've been trying to use consistent language with other parts of the kernel like interval tree and maple tree: * In this file the term 'last' indicates an inclusive and closed interval, eg * [0,0] refers to a single PFN. 'end' means an open range, eg [0,0) refers to * no PFNs. Here I think you've swapped end to mean last? Regardless the change looks correct Reviewed-by: Jason Gunthorpe Jason From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E49A1C4167B for ; Thu, 30 Nov 2023 00:46:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=f1FzSeOyXgxBaS81ezHiD0EPuWTc2NoknRe1DgpnasQ=; b=QiY/jG4cVsxMV/ Rg67cAFnN0cpjt9bSpHLA8RE625ZXuxobvEhbObvwbWcm9z6lItgiY/1K89AI1TBzS0MJwgeH3lTz CbUsPjQalAqpz12qO4D8KyEe7FJ9hC3j9BIfLqNGsay8U1BzixYmWq5dffpk3VDnWfQsGWw8tdKaq sLlXrsOde5JEqt57LH4jU65VyY5Raxlwfh887XYFjorYXUEkI7VVWZvpcG+xwujb06qX1AwH99kE+ ihcqmuzsgbAToqimxJAE4P+XR+t8RvkkDv0YCEDh9dNnvPpFmFmBzAefBXRoh2oFdCHYfIux9kZ4b XOyNFu+F09tJww9JLXwg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r8VBx-009bBs-02; Thu, 30 Nov 2023 00:46:09 +0000 Received: from mail-oo1-xc2d.google.com ([2607:f8b0:4864:20::c2d]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r8VBu-009bBG-2t for linux-arm-kernel@lists.infradead.org; Thu, 30 Nov 2023 00:46:08 +0000 Received: by mail-oo1-xc2d.google.com with SMTP id 006d021491bc7-58d12b53293so270768eaf.0 for ; Wed, 29 Nov 2023 16:46:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1701305165; x=1701909965; darn=lists.infradead.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=DGfesKWk6hIGgQDOksuxdOXdV/4i0gK7DjvWJInD9Kc=; b=PHmLraX9MnS9xVoBdLbgh0BkPa6muE5awjJl/0blscB5pvIc+mDHxSKN/7fkEVxdhZ uJv6DNCJ52jPZK1aUjttdVyfgaomezhGmZbEVLgUyonCj4yMzJH7xZeX7TgmvoaGl0Vw VbW1sanQ3GsZtSdOSbo3Oqx9WvyrevDxaFoGWEnRbAluc3krUPaXOYIZk/bpUfesTJGW iLKLA+3a+s99xu7m4R8ittq81TyTo4+2aiXdPMZ66KRuvyJ9qZbAMbKTDypqz0E/PVyP WmQ6dDP2LQOtThouP8Q91xX1X/Ko9An2OvtNDwA3ttr56tiPL7Dml8FtKziMSA3aaLYe Cb3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1701305165; x=1701909965; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=DGfesKWk6hIGgQDOksuxdOXdV/4i0gK7DjvWJInD9Kc=; b=ndyPbmWxi0h2nTmMcvz9ohJG0RhCyn99WeqcXT8CEpMWz0nYwEe1rjVLJXWKR9v0VE IoZgR2fODWsNVjq6x7CwK9PsOVPqMNJHufljeQKRQr0dc1rWtDk9nmS5BZ0Rbf5KYHOt EekcNAmcDq0hjA3+yHZjc9/N93tjIbHJYc9hBJbR88Lji/OsjpIXYuaYIu1Re3neYSgs Jm2YbxEEuHLJhgiQPzgQPSrX+UA+qVk+yD/h9TCc4VCcVqyETpUTjOQFvHG4QverqYE+ 0iB/dXORosmGFk67Z2hNbO8Yot52+gBY/hNbNqtBDfkaYHglFLAJJp+AQp69RwS30Lsh mpVw== X-Gm-Message-State: AOJu0Yw4KzQQXNZ0Y8SBWikRtLgoZsN32zAUvOWws0ISluAhw0bcLfrr C1Z45zuSy2l5FhPrzU7wwmmehg== X-Google-Smtp-Source: AGHT+IH0QnaZj4Srt21JiVw/aqbEQCLMM8IUp7yXueL4iz88oaZRnRpsZVc5esr77Xqw2FDtMOcfOA== X-Received: by 2002:a05:6870:3326:b0:1fa:2b51:cc8b with SMTP id x38-20020a056870332600b001fa2b51cc8bmr18739526oae.32.1701305164620; Wed, 29 Nov 2023 16:46:04 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-134-23-187.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.134.23.187]) by smtp.gmail.com with ESMTPSA id mn13-20020a0568700c8d00b001fa3ab0a3bdsm2224484oab.31.2023.11.29.16.46.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 29 Nov 2023 16:46:04 -0800 (PST) Received: from jgg by wakko with local (Exim 4.95) (envelope-from ) id 1r8VBr-005r2g-CG; Wed, 29 Nov 2023 20:46:03 -0400 Date: Wed, 29 Nov 2023 20:46:03 -0400 From: Jason Gunthorpe To: Robin Murphy Cc: Joerg Roedel , Christoph Hellwig , Vineet Gupta , Russell King , Catalin Marinas , Will Deacon , Huacai Chen , WANG Xuerui , Thomas Bogendoerfer , Paul Walmsley , Palmer Dabbelt , Albert Ou , Lorenzo Pieralisi , Hanjun Guo , Sudeep Holla , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Suravee Suthikulpanit , David Woodhouse , Lu Baolu , Niklas Schnelle , Matthew Rosato , Gerald Schaefer , Jean-Philippe Brucker , Rob Herring , Frank Rowand , Marek Szyprowski , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, iommu@lists.linux.dev, devicetree@vger.kernel.org Subject: Re: [PATCH 2/7] OF: Simplify DMA range calculations Message-ID: <20231130004603.GB1394392@ziepe.ca> References: <73becf4a75f15662b2dda5fba7cfeacdf3d866f8.1701268753.git.robin.murphy@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <73becf4a75f15662b2dda5fba7cfeacdf3d866f8.1701268753.git.robin.murphy@arm.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231129_164606_936458_E6446509 X-CRM114-Status: GOOD ( 14.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Nov 29, 2023 at 05:42:59PM +0000, Robin Murphy wrote: > Juggling start, end, and size values for a range is somewhat redundant > and a little hard to follow. Consolidate down to just using inclusive > start and end, which saves us worrying about size overflows for full > 64-bit ranges (note that passing a potentially-overflowed value through > to arch_setup_dma_ops() is benign for all current implementations, and > this is working towards removing that anyway). In iommu code I've been trying to use consistent language with other parts of the kernel like interval tree and maple tree: * In this file the term 'last' indicates an inclusive and closed interval, eg * [0,0] refers to a single PFN. 'end' means an open range, eg [0,0) refers to * no PFNs. Here I think you've swapped end to mean last? Regardless the change looks correct Reviewed-by: Jason Gunthorpe Jason _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel