From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4467D184; Mon, 4 Dec 2023 00:44:44 -0800 (PST) Received: by verein.lst.de (Postfix, from userid 2407) id E167F68AFE; Mon, 4 Dec 2023 09:44:40 +0100 (CET) Date: Mon, 4 Dec 2023 09:44:40 +0100 From: Christoph Hellwig To: Robin Murphy Cc: Joerg Roedel , Christoph Hellwig , Vineet Gupta , Russell King , Catalin Marinas , Will Deacon , Huacai Chen , WANG Xuerui , Thomas Bogendoerfer , Paul Walmsley , Palmer Dabbelt , Albert Ou , Lorenzo Pieralisi , Hanjun Guo , Sudeep Holla , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Suravee Suthikulpanit , David Woodhouse , Lu Baolu , Niklas Schnelle , Matthew Rosato , Gerald Schaefer , Jean-Philippe Brucker , Rob Herring , Frank Rowand , Marek Szyprowski , Jason Gunthorpe , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, iommu@lists.linux.dev, devicetree@vger.kernel.org Subject: Re: [PATCH 7/7] dma-mapping: Simplify arch_setup_dma_ops() Message-ID: <20231204084440.GB919@lst.de> References: <590a4a1b7d10fb9bb1c42ca6cd438e98e6cc94a7.1701268753.git.robin.murphy@arm.com> Precedence: bulk X-Mailing-List: linux-acpi@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <590a4a1b7d10fb9bb1c42ca6cd438e98e6cc94a7.1701268753.git.robin.murphy@arm.com> User-Agent: Mutt/1.5.17 (2007-11-01) On Wed, Nov 29, 2023 at 05:43:04PM +0000, Robin Murphy wrote: > The dma_base, size and iommu arguments are only used by ARM, and can > now easily be deduced from the device itself, so there's no need to pass > them through the callchain as well. This looks even better than the patch form Jason that only removed the iommu argument: Reviewed-by: Christoph Hellwig I wonder if it makes sense to also remove the coherent argument by setting up dev->dma_coherent in the caller. That would require a pretty careful audit as we're doing a few weird things in that area, though. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B3161C4167B for ; Mon, 4 Dec 2023 08:45:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TwAEW1ATXk6kw0wzGipPNWS955ODwFTPPxLgr7l7U8A=; b=FhJ748yTmEihj6 fVZggCueG7iyF6mW4seNdUYiqlo0XwenMZw5jaEya+S0G1p3y8faE7FZn7URXI7iY6a7xa77BwDHj qvD9G3gdnAsLnX1jgfkCWuduHHhoTqBSU+NtUX8F1nvx2KUwFBQ2MN/y28luvcbjd8e5/GQTJtUxY CK8TfAboQ4p2mG/zHSJv4DEs5VyqudghypWA1nVqGMzgKtwZGjGRQJ+neHwtod/jJgJi7T+a+UCXz ZVDz6/JoFSH0IempcYpyzcG14EqNg8BRPO/j3COqzyVH8Yt14g1VOlKcdmsQCqPycOc6IiyoxuPrK 5CmUrruOvcNBQW5Nr9Xw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rA4ZP-003Jrz-39; Mon, 04 Dec 2023 08:44:51 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rA4ZH-003JoH-2Y for linux-arm-kernel@lists.infradead.org; Mon, 04 Dec 2023 08:44:49 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id E167F68AFE; Mon, 4 Dec 2023 09:44:40 +0100 (CET) Date: Mon, 4 Dec 2023 09:44:40 +0100 From: Christoph Hellwig To: Robin Murphy Cc: Joerg Roedel , Christoph Hellwig , Vineet Gupta , Russell King , Catalin Marinas , Will Deacon , Huacai Chen , WANG Xuerui , Thomas Bogendoerfer , Paul Walmsley , Palmer Dabbelt , Albert Ou , Lorenzo Pieralisi , Hanjun Guo , Sudeep Holla , "K. Y. Srinivasan" , Haiyang Zhang , Wei Liu , Dexuan Cui , Suravee Suthikulpanit , David Woodhouse , Lu Baolu , Niklas Schnelle , Matthew Rosato , Gerald Schaefer , Jean-Philippe Brucker , Rob Herring , Frank Rowand , Marek Szyprowski , Jason Gunthorpe , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-acpi@vger.kernel.org, iommu@lists.linux.dev, devicetree@vger.kernel.org Subject: Re: [PATCH 7/7] dma-mapping: Simplify arch_setup_dma_ops() Message-ID: <20231204084440.GB919@lst.de> References: <590a4a1b7d10fb9bb1c42ca6cd438e98e6cc94a7.1701268753.git.robin.murphy@arm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <590a4a1b7d10fb9bb1c42ca6cd438e98e6cc94a7.1701268753.git.robin.murphy@arm.com> User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231204_004444_239614_CA7EEB31 X-CRM114-Status: GOOD ( 17.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Nov 29, 2023 at 05:43:04PM +0000, Robin Murphy wrote: > The dma_base, size and iommu arguments are only used by ARM, and can > now easily be deduced from the device itself, so there's no need to pass > them through the callchain as well. This looks even better than the patch form Jason that only removed the iommu argument: Reviewed-by: Christoph Hellwig I wonder if it makes sense to also remove the coherent argument by setting up dev->dma_coherent in the caller. That would require a pretty careful audit as we're doing a few weird things in that area, though. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel