Re: [PATCH v2 2/2] iio: light: Add support for APDS9306 Light Sensor

From: Jonathan Cameron <jic23@kernel.org>
To: Matti Vaittinen <mazziesaccount@gmail.com>
Cc: Subhajit Ghosh <subhajit.ghosh@tweaklogic.com>,
	Lars-Peter Clausen <lars@metafoo.de>,
	Rob Herring <robh+dt@kernel.org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Paul Gazzillo <paul@pgazz.com>, Matt Ranostay <matt@ranostay.sg>,
	Stefan Windfeldt-Prytz <stefan.windfeldt-prytz@axis.com>,
	linux-iio@vger.kernel.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] iio: light: Add support for APDS9306 Light Sensor
Date: Mon, 4 Dec 2023 09:51:08 +0000	[thread overview]
Message-ID: <20231204095108.22f89718@jic23-huawei> (raw)
In-Reply-To: <e995ee76-7dc3-4a4a-80a3-fca1ac7c5a9f@gmail.com>

On Mon, 6 Nov 2023 14:10:43 +0200
Matti Vaittinen <mazziesaccount@gmail.com> wrote:

> On 11/6/23 14:04, Subhajit Ghosh wrote:
> > On 6/11/23 21:43, Jonathan Cameron wrote:  
> >> On Tue, 31 Oct 2023 19:08:08 +1030
> >> Subhajit Ghosh <subhajit.ghosh@tweaklogic.com> wrote:
> >>  
> >>>> Scale on the intensity channel is interesting...  What are the units?
> >>>> There tend not to be any well defined units for intensity (as opposed
> >>>> to illuminance).  There may be gain on the signal, but it won't be 
> >>>> in untils
> >>>> that map directly to a scale userspace should apply.  This is one of 
> >>>> the
> >>>> rare reasons for using the HARDWARE_GAIN element of the ABI.
> >>>>
> >>>> A tricky corner however as relationship between raw value and 
> >>>> hardwaregain
> >>>> is not tightly defined (as it can be really weird!)  
> >>> Hi Jonathan,
> >>>
> >>> Thank you for taking time for reviewing and clearing all my tiny 
> >>> doubts and
> >>> queries especially for the dt and versioning part. Much appreciated.
> >>>
> >>> In the above case, should I not expose scale for the "clear" channel? 
> >>> Rather,
> >>> how should I expose the "clear" channel to userspace?  
> >> What is the scale?  What units to you get after applying it?  
> > The scale is in Lux. The output after applying is Lux.  
> 
> Hi Subhajit,
> 
> I am by no means an expert here but maybe you could check if the channel 
> should be of type 'illuminance'? (To me 'Lux' sounds like an unit of 
> illuminance rather than intensity).

Absolutely. Light measurements are 'weird'. Lux is a measurement of
light as if the human eye were looking at it. Unfortunately light sensors
don't have the same sensitivity curves as the eye so instead they tend
to do it either by some careful choice of filters, a horrible approximation
based on assumption of day light, or most commonly by combining the inputs
of several different light sensors.

Clear normally means sensitive to both visible light and infrared which
means you need to remove the infrared part to get closer to human
eye response.   Thus in other light sensors, we can't assign standard
units to the intensity channels (and so don't provide a scale).
We just don't have enough information to work out what they are measuring.
In theory we could provide the full sensitivity curve (usually somewhere
in the datasheet) but they can be complex multi-peak things so we don't
so far.

Jonathan

> 
> Yours,
> 	-- Matti
> 