All of
 help / color / mirror / Atom feed
From: Jialu Xu <>
Subject: Re: [PATCH v2] fix path resolve with symlinks in it
Date: Wed,  6 Dec 2023 09:20:34 +0800	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <20231205165648.GA391810@dev-arch.thelio-3990X>

Hi Nathan,

>On Tue, Dec 05, 2023 at 10:15:26AM +0800, Jialu Xu wrote:
>> When symbolic links are involved in the path, os.path.abspath might not
>> resolve the symlinks and instead return the absolute path with the
>> symlinks intact.
>> Use pathlib.Path resolve() instead of os.path.abspath()
>> Signed-off-by: Jialu Xu <>
>Thanks for the clarification in your previous message [1], I suppose
>that makes sense as to why nobody has reported this to us because that
>is a rather odd situation that the upstream kernel would not experience.
>I think that some of those details should be in the commit message,
>along with a short example like you provided, so that we know exactly
>what the situation was and how this patch resolves it.
>Perhaps something like (please feel free to correct or reword as you
>feel necessary):
>"When a path contains relative symbolic links, os.path.abspath() might
>not follow the symlinks and instead return the absolute path with just
>the relative paths resolved, resulting in an incorrect path.
><broken example>
>Use pathlib.Path.resolve(), which resolves the symlinks and normalizes
>the paths correctly.
><working example>"
>The actual fix seems fine to me. Feel free to add
>  Reviewed-by: Nathan Chancellor <>
>to the subsequent submission and please include both
>  Masahiro Yamada <>
>on it in addition to the people you have here, as he is the one who
>actually applies changes (I am going to send a
>MAINTAINERS change for this).

Thanks for the very detailed help!

Patch update as v3.


  reply	other threads:[~2023-12-06  1:23 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-04 10:41 [PATCH] fix path resolve with symlinks in it Jialu Xu
2023-12-04 16:59 ` Nathan Chancellor
2023-12-05  2:15   ` Jialu Xu
2023-12-05  2:15   ` [PATCH v2] fix path resolve with symlinks in it Jialu Xu
2023-12-05 16:56     ` Nathan Chancellor
2023-12-06  1:20       ` Jialu Xu [this message]
2023-12-06  1:20       ` [PATCH v3] " Jialu Xu
2023-12-06  1:24       ` [PATCH v4] " Jialu Xu
2023-12-07 22:54         ` Justin Stitt
2023-12-10  5:52         ` Masahiro Yamada
2023-12-10  7:05           ` Jialu Xu
2023-12-10  7:05             ` [PATCH v5] " Jialu Xu
2023-12-11 17:53               ` Masahiro Yamada

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.