From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f171.google.com (mail-oi1-f171.google.com [209.85.167.171]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8D9D29C; Wed, 13 Dec 2023 14:11:27 -0800 (PST) Received: by mail-oi1-f171.google.com with SMTP id 5614622812f47-3ba2dd905f9so313433b6e.2; Wed, 13 Dec 2023 14:11:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702505487; x=1703110287; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=AgTgho1a4LA/XjrrePxUmui9LuYj0rwstzK1KGu7248=; b=IMOdCTBYRRbRReNvThP/IthfKDyEycuBWJ2p5+YXsrp6tIPSvBf1h4tn3PPsU2obm7 UpTMqDdTQTW5MmKHd6Wo0FCc/O6JLWLVruzay5/RxcI9R1FfbGZ3oRi6+uIAQChboBIl 2aKolWYZQXhD0aK3W4mTou0lyLy9JQhQN05xk+XOE7toUrc4pa8usbnqI8zNs9Ye21Dt fIABmmUfThbUT0YTunzXrzJ5G3oOempjphTxm/Z+jlIC+ZnAPBn8NwTnn3XQ317CPC/x kjnp3Dz97l/rSuQpycw2PVcAKZ8b8psKCN3QEucCIq8Kh47X9qKkyO4hKvFyOznEXQgw hVsw== X-Gm-Message-State: AOJu0YyHyH+Hc8OFkS2RtWR5Zz0F8PLl4ABVbKUmEcvgplWCFFo9+5Pm ZB3JHFt3pTmCiJjq1RHSCQ== X-Google-Smtp-Source: AGHT+IHX5L5W/V5kcRHCZGCX9tUxlzQHF1lIwCR9ERJ7ag6EqOQsYnbBD4efejagEgtQrlmcp0mZLw== X-Received: by 2002:a05:6808:6493:b0:3ba:667:9e4f with SMTP id fh19-20020a056808649300b003ba06679e4fmr7673479oib.113.1702505486877; Wed, 13 Dec 2023 14:11:26 -0800 (PST) Received: from herring.priv (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id bh20-20020a056808181400b003b83c516e62sm3102354oib.51.2023.12.13.14.11.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 14:11:26 -0800 (PST) Received: (nullmailer pid 2156812 invoked by uid 1000); Wed, 13 Dec 2023 22:11:24 -0000 Date: Wed, 13 Dec 2023 16:11:24 -0600 From: Rob Herring To: Mark Hasemeyer Cc: LKML , Raul Rangel , Alim Akhtar , Andre Przywara , Andy Gross , AngeloGioacchino Del Regno , Baruch Siach , Bjorn Andersson , Claudiu Beznea , Conor Dooley , Heiko Stuebner , Jesper Nilsson , Jisheng Zhang , Jonathan Hunter , Konrad Dybcio , Krzysztof Kozlowski , Matthias Brugger , Michal Simek , Paul Barker , Sudeep Holla , Thierry Reding , cros-qcom-dts-watchers@chromium.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org Subject: Re: [PATCH v1 2/6] arm: arm64: dts: Enable cros-ec-spi as wake source Message-ID: <20231213221124.GB2115075-robh@kernel.org> References: <20231213110009.v1.1.Ifd0903f1c351e84376d71dbdadbd43931197f5ea@changeid> <20231213110009.v1.2.I274b2d2255eb539cc9d251c9d65a385cc4014c79@changeid> Precedence: bulk X-Mailing-List: linux-tegra@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231213110009.v1.2.I274b2d2255eb539cc9d251c9d65a385cc4014c79@changeid> On Wed, Dec 13, 2023 at 11:00:20AM -0700, Mark Hasemeyer wrote: > The cros_ec driver currently assumes that cros-ec-spi compatible device > nodes are a wakeup-source even though the wakeup-source property is not > defined. If a device knows it is wakeup capable, why do you need a property too? I haven't looked closely enough, but it smells like after patch 6, these properties would be required for wakeup? That would be an ABI break. Rob From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7706FC4167B for ; Wed, 13 Dec 2023 22:11:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TtiQRuV9/yR6atyK0PADX305GiMj7/zWSnRFCXEiR3A=; b=dleE9u8jS3CVxB +oieQs35ebfG+tWOuC63UFjKVIgAund7fbLvv39qyGGP/aXEJ5rcYQGONE7XaXF9zLso1hKtdYzaV ZV5G4FQQT8hyj1D0nXk4SC4pg48XChY3Ci1pRTEJgO6pSqwo3GBpUE2+2vS7Tw0Rky+dngrD6ZLDf GdZUSWnYbbtgScNWqMSg7A+wcRGJapu8i4Kob2eu6GVFBq2CN2zn78T+rs6Yv3RB7NGzHXcBdjzUD /E2GghZRNssPz1E9augzxI66oFN34wJbQPGkO+WJcvuNfGXsiEpfSKy5A8M87ENT1BFTzNdSWzukt ABLeZWd8OzUJ1qtx+Q9w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rDXS0-00G6MG-1o; Wed, 13 Dec 2023 22:11:32 +0000 Received: from mail-oi1-f172.google.com ([209.85.167.172]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rDXRx-00G6LN-01; Wed, 13 Dec 2023 22:11:30 +0000 Received: by mail-oi1-f172.google.com with SMTP id 5614622812f47-3b9f111c114so3834019b6e.1; Wed, 13 Dec 2023 14:11:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702505487; x=1703110287; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=AgTgho1a4LA/XjrrePxUmui9LuYj0rwstzK1KGu7248=; b=isgq4EuM35NFY8Qyy8HcS4cgXP7l7VsIC0CxY6QUepbCHEGPcZfalMXKY4Cxf857s3 xsvvd+EOuDvqOaBT19PouWsg/qQJGDe9iJJ5PvwhvErX67J4UZi4fySnptOFjQBtF7KA 2jLCbRvpPEooYH+K8yMZOdd6WujCyCS83sQx/8T9yTDcsx6kOUt+At86Wo8rRPb2E7d3 elusAN/gPefk+TImoJ+bbf38GZizTXKlBLoMIls6kWrCqK/AGIRltGDBkRDGlpllXnBC wFQ9f1KS3vfABF+/IggURzOwyTQ3ZSW8FNi3+L4cUiNr2c6cNNk4QaHTxwCMlTc81TzZ Z3EQ== X-Gm-Message-State: AOJu0Yy8/6mCwZ6y/4IvzA1uA3QY4CwBELnN9GSpQtqN+4DIZkJi7BCP fcnlgoi6+pOTZp/yMb3LMA== X-Google-Smtp-Source: AGHT+IHX5L5W/V5kcRHCZGCX9tUxlzQHF1lIwCR9ERJ7ag6EqOQsYnbBD4efejagEgtQrlmcp0mZLw== X-Received: by 2002:a05:6808:6493:b0:3ba:667:9e4f with SMTP id fh19-20020a056808649300b003ba06679e4fmr7673479oib.113.1702505486877; Wed, 13 Dec 2023 14:11:26 -0800 (PST) Received: from herring.priv (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id bh20-20020a056808181400b003b83c516e62sm3102354oib.51.2023.12.13.14.11.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 14:11:26 -0800 (PST) Received: (nullmailer pid 2156812 invoked by uid 1000); Wed, 13 Dec 2023 22:11:24 -0000 Date: Wed, 13 Dec 2023 16:11:24 -0600 From: Rob Herring To: Mark Hasemeyer Cc: LKML , Raul Rangel , Alim Akhtar , Andre Przywara , Andy Gross , AngeloGioacchino Del Regno , Baruch Siach , Bjorn Andersson , Claudiu Beznea , Conor Dooley , Heiko Stuebner , Jesper Nilsson , Jisheng Zhang , Jonathan Hunter , Konrad Dybcio , Krzysztof Kozlowski , Matthias Brugger , Michal Simek , Paul Barker , Sudeep Holla , Thierry Reding , cros-qcom-dts-watchers@chromium.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org Subject: Re: [PATCH v1 2/6] arm: arm64: dts: Enable cros-ec-spi as wake source Message-ID: <20231213221124.GB2115075-robh@kernel.org> References: <20231213110009.v1.1.Ifd0903f1c351e84376d71dbdadbd43931197f5ea@changeid> <20231213110009.v1.2.I274b2d2255eb539cc9d251c9d65a385cc4014c79@changeid> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231213110009.v1.2.I274b2d2255eb539cc9d251c9d65a385cc4014c79@changeid> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231213_141129_064121_4AEC44F1 X-CRM114-Status: UNSURE ( 9.47 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-rockchip@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: Upstream kernel work for Rockchip platforms List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "Linux-rockchip" Errors-To: linux-rockchip-bounces+linux-rockchip=archiver.kernel.org@lists.infradead.org On Wed, Dec 13, 2023 at 11:00:20AM -0700, Mark Hasemeyer wrote: > The cros_ec driver currently assumes that cros-ec-spi compatible device > nodes are a wakeup-source even though the wakeup-source property is not > defined. If a device knows it is wakeup capable, why do you need a property too? I haven't looked closely enough, but it smells like after patch 6, these properties would be required for wakeup? That would be an ABI break. Rob _______________________________________________ Linux-rockchip mailing list Linux-rockchip@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-rockchip From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 663F1C4332F for ; Wed, 13 Dec 2023 22:11:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UXZu00wutl4l147i7kq1Zg4PCTfRJ3jRQmRrbV4Q63U=; b=gS8kMNEwqNPNZ8 hv17Aq57ZWKi44uanLe7WWNCItBrEKcg1ZFMTtdFeW7NezIpMavQieu/QzWGLU77QSeMnE+ExOHO8 9LLbdX9D5bhzaNYKr2D/2E7AGdfYUItZWlHSesmAt6DddJdK9HQCMOYtAI2BczpiWKbpdfXwCNlgP hdHUt5V6leaRn+S7G2wQ1W+BySspMrqqqmiJplmb6FuA3620L/FSUztI1wjYB0fWHEu0pVUs7AEZp 0w7EM/IfddOS11h6RStU9uHl+ZzIkLdyUJXnA4HuGI1JfVdlpQ8MeJbZorkLoY+rNv8ARG5BX+hlg BErDJnGhdd4Z5cIJbxQw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rDXRz-00G6M7-2G; Wed, 13 Dec 2023 22:11:31 +0000 Received: from mail-oi1-f172.google.com ([209.85.167.172]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rDXRx-00G6LN-01; Wed, 13 Dec 2023 22:11:30 +0000 Received: by mail-oi1-f172.google.com with SMTP id 5614622812f47-3b9f111c114so3834019b6e.1; Wed, 13 Dec 2023 14:11:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702505487; x=1703110287; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=AgTgho1a4LA/XjrrePxUmui9LuYj0rwstzK1KGu7248=; b=isgq4EuM35NFY8Qyy8HcS4cgXP7l7VsIC0CxY6QUepbCHEGPcZfalMXKY4Cxf857s3 xsvvd+EOuDvqOaBT19PouWsg/qQJGDe9iJJ5PvwhvErX67J4UZi4fySnptOFjQBtF7KA 2jLCbRvpPEooYH+K8yMZOdd6WujCyCS83sQx/8T9yTDcsx6kOUt+At86Wo8rRPb2E7d3 elusAN/gPefk+TImoJ+bbf38GZizTXKlBLoMIls6kWrCqK/AGIRltGDBkRDGlpllXnBC wFQ9f1KS3vfABF+/IggURzOwyTQ3ZSW8FNi3+L4cUiNr2c6cNNk4QaHTxwCMlTc81TzZ Z3EQ== X-Gm-Message-State: AOJu0Yy8/6mCwZ6y/4IvzA1uA3QY4CwBELnN9GSpQtqN+4DIZkJi7BCP fcnlgoi6+pOTZp/yMb3LMA== X-Google-Smtp-Source: AGHT+IHX5L5W/V5kcRHCZGCX9tUxlzQHF1lIwCR9ERJ7ag6EqOQsYnbBD4efejagEgtQrlmcp0mZLw== X-Received: by 2002:a05:6808:6493:b0:3ba:667:9e4f with SMTP id fh19-20020a056808649300b003ba06679e4fmr7673479oib.113.1702505486877; Wed, 13 Dec 2023 14:11:26 -0800 (PST) Received: from herring.priv (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id bh20-20020a056808181400b003b83c516e62sm3102354oib.51.2023.12.13.14.11.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Dec 2023 14:11:26 -0800 (PST) Received: (nullmailer pid 2156812 invoked by uid 1000); Wed, 13 Dec 2023 22:11:24 -0000 Date: Wed, 13 Dec 2023 16:11:24 -0600 From: Rob Herring To: Mark Hasemeyer Cc: LKML , Raul Rangel , Alim Akhtar , Andre Przywara , Andy Gross , AngeloGioacchino Del Regno , Baruch Siach , Bjorn Andersson , Claudiu Beznea , Conor Dooley , Heiko Stuebner , Jesper Nilsson , Jisheng Zhang , Jonathan Hunter , Konrad Dybcio , Krzysztof Kozlowski , Matthias Brugger , Michal Simek , Paul Barker , Sudeep Holla , Thierry Reding , cros-qcom-dts-watchers@chromium.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-arm-msm@vger.kernel.org, linux-mediatek@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-tegra@vger.kernel.org Subject: Re: [PATCH v1 2/6] arm: arm64: dts: Enable cros-ec-spi as wake source Message-ID: <20231213221124.GB2115075-robh@kernel.org> References: <20231213110009.v1.1.Ifd0903f1c351e84376d71dbdadbd43931197f5ea@changeid> <20231213110009.v1.2.I274b2d2255eb539cc9d251c9d65a385cc4014c79@changeid> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231213110009.v1.2.I274b2d2255eb539cc9d251c9d65a385cc4014c79@changeid> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231213_141129_064121_4AEC44F1 X-CRM114-Status: UNSURE ( 9.47 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, Dec 13, 2023 at 11:00:20AM -0700, Mark Hasemeyer wrote: > The cros_ec driver currently assumes that cros-ec-spi compatible device > nodes are a wakeup-source even though the wakeup-source property is not > defined. If a device knows it is wakeup capable, why do you need a property too? I haven't looked closely enough, but it smells like after patch 6, these properties would be required for wakeup? That would be an ABI break. Rob _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel