All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>,
	llvm@lists.linux.dev, intel-xe@lists.freedesktop.org,
	oe-kbuild-all@lists.linux.dev
Subject: [drm-xe:drm-xe-next 989/1016] drivers/gpu/drm/xe/xe_wait_user_fence.c:46:2: warning: variable 'passed' is used uninitialized whenever switch default is taken
Date: Sun, 17 Dec 2023 03:28:47 +0800	[thread overview]
Message-ID: <202312170357.KPSinwPs-lkp@intel.com> (raw)

tree:   https://gitlab.freedesktop.org/drm/xe/kernel.git drm-xe-next
head:   c54005fdd0347a17088e7ff78070a55bf9103bc4
commit: ad7d86415578e1a5deedb0ceed5c281f7367d66d [989/1016] drm/xe: Enable W=1 warnings by default
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20231217/202312170357.KPSinwPs-lkp@intel.com/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231217/202312170357.KPSinwPs-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312170357.KPSinwPs-lkp@intel.com/

All warnings (new ones prefixed by >>):

   warning: unknown warning option '-Wrestrict' [-Wunknown-warning-option]
   warning: unknown warning option '-Wpacked-not-aligned'; did you mean '-Wpacked-non-pod'? [-Wunknown-warning-option]
   warning: unknown warning option '-Wformat-overflow'; did you mean '-Wshift-overflow'? [-Wunknown-warning-option]
   warning: unknown warning option '-Wformat-truncation' [-Wunknown-warning-option]
   warning: unknown warning option '-Wstringop-overflow'; did you mean '-Wshift-overflow'? [-Wunknown-warning-option]
   warning: unknown warning option '-Wstringop-truncation'; did you mean '-Wstring-concatenation'? [-Wunknown-warning-option]
>> drivers/gpu/drm/xe/xe_wait_user_fence.c:46:2: warning: variable 'passed' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized]
           default:
           ^~~~~~~
   drivers/gpu/drm/xe/xe_wait_user_fence.c:50:9: note: uninitialized use occurs here
           return passed ? 0 : 1;
                  ^~~~~~
   drivers/gpu/drm/xe/xe_wait_user_fence.c:21:13: note: initialize the variable 'passed' to silence this warning
           bool passed;
                      ^
                       = 0
   7 warnings generated.


vim +/passed +46 drivers/gpu/drm/xe/xe_wait_user_fence.c

dd08ebf6c3525a Matthew Brost   2023-03-30  16  
dd08ebf6c3525a Matthew Brost   2023-03-30  17  static int do_compare(u64 addr, u64 value, u64 mask, u16 op)
dd08ebf6c3525a Matthew Brost   2023-03-30  18  {
dd08ebf6c3525a Matthew Brost   2023-03-30  19  	u64 rvalue;
dd08ebf6c3525a Matthew Brost   2023-03-30  20  	int err;
dd08ebf6c3525a Matthew Brost   2023-03-30  21  	bool passed;
dd08ebf6c3525a Matthew Brost   2023-03-30  22  
dd08ebf6c3525a Matthew Brost   2023-03-30  23  	err = copy_from_user(&rvalue, u64_to_user_ptr(addr), sizeof(rvalue));
dd08ebf6c3525a Matthew Brost   2023-03-30  24  	if (err)
dd08ebf6c3525a Matthew Brost   2023-03-30  25  		return -EFAULT;
dd08ebf6c3525a Matthew Brost   2023-03-30  26  
dd08ebf6c3525a Matthew Brost   2023-03-30  27  	switch (op) {
76d52e37187b73 Rodrigo Vivi    2023-11-14  28  	case DRM_XE_UFENCE_WAIT_OP_EQ:
dd08ebf6c3525a Matthew Brost   2023-03-30  29  		passed = (rvalue & mask) == (value & mask);
dd08ebf6c3525a Matthew Brost   2023-03-30  30  		break;
76d52e37187b73 Rodrigo Vivi    2023-11-14  31  	case DRM_XE_UFENCE_WAIT_OP_NEQ:
dd08ebf6c3525a Matthew Brost   2023-03-30  32  		passed = (rvalue & mask) != (value & mask);
dd08ebf6c3525a Matthew Brost   2023-03-30  33  		break;
76d52e37187b73 Rodrigo Vivi    2023-11-14  34  	case DRM_XE_UFENCE_WAIT_OP_GT:
dd08ebf6c3525a Matthew Brost   2023-03-30  35  		passed = (rvalue & mask) > (value & mask);
dd08ebf6c3525a Matthew Brost   2023-03-30  36  		break;
76d52e37187b73 Rodrigo Vivi    2023-11-14  37  	case DRM_XE_UFENCE_WAIT_OP_GTE:
dd08ebf6c3525a Matthew Brost   2023-03-30  38  		passed = (rvalue & mask) >= (value & mask);
dd08ebf6c3525a Matthew Brost   2023-03-30  39  		break;
76d52e37187b73 Rodrigo Vivi    2023-11-14  40  	case DRM_XE_UFENCE_WAIT_OP_LT:
dd08ebf6c3525a Matthew Brost   2023-03-30  41  		passed = (rvalue & mask) < (value & mask);
dd08ebf6c3525a Matthew Brost   2023-03-30  42  		break;
76d52e37187b73 Rodrigo Vivi    2023-11-14  43  	case DRM_XE_UFENCE_WAIT_OP_LTE:
dd08ebf6c3525a Matthew Brost   2023-03-30  44  		passed = (rvalue & mask) <= (value & mask);
dd08ebf6c3525a Matthew Brost   2023-03-30  45  		break;
dd08ebf6c3525a Matthew Brost   2023-03-30 @46  	default:
5e0e3070659519 Francois Dugast 2023-07-27  47  		XE_WARN_ON("Not possible");
dd08ebf6c3525a Matthew Brost   2023-03-30  48  	}
dd08ebf6c3525a Matthew Brost   2023-03-30  49  
dd08ebf6c3525a Matthew Brost   2023-03-30  50  	return passed ? 0 : 1;
dd08ebf6c3525a Matthew Brost   2023-03-30  51  }
dd08ebf6c3525a Matthew Brost   2023-03-30  52  

:::::: The code at line 46 was first introduced by commit
:::::: dd08ebf6c3525a7ea2186e636df064ea47281987 drm/xe: Introduce a new DRM driver for Intel GPUs

:::::: TO: Matthew Brost <matthew.brost@intel.com>
:::::: CC: Rodrigo Vivi <rodrigo.vivi@intel.com>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

WARNING: multiple messages have this Message-ID (diff)
From: kernel test robot <lkp@intel.com>
To: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
	intel-xe@lists.freedesktop.org,
	Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: [drm-xe:drm-xe-next 989/1016] drivers/gpu/drm/xe/xe_wait_user_fence.c:46:2: warning: variable 'passed' is used uninitialized whenever switch default is taken
Date: Sun, 17 Dec 2023 03:28:47 +0800	[thread overview]
Message-ID: <202312170357.KPSinwPs-lkp@intel.com> (raw)

tree:   https://gitlab.freedesktop.org/drm/xe/kernel.git drm-xe-next
head:   c54005fdd0347a17088e7ff78070a55bf9103bc4
commit: ad7d86415578e1a5deedb0ceed5c281f7367d66d [989/1016] drm/xe: Enable W=1 warnings by default
config: x86_64-allyesconfig (https://download.01.org/0day-ci/archive/20231217/202312170357.KPSinwPs-lkp@intel.com/config)
compiler: clang version 16.0.4 (https://github.com/llvm/llvm-project.git ae42196bc493ffe877a7e3dff8be32035dea4d07)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231217/202312170357.KPSinwPs-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202312170357.KPSinwPs-lkp@intel.com/

All warnings (new ones prefixed by >>):

   warning: unknown warning option '-Wrestrict' [-Wunknown-warning-option]
   warning: unknown warning option '-Wpacked-not-aligned'; did you mean '-Wpacked-non-pod'? [-Wunknown-warning-option]
   warning: unknown warning option '-Wformat-overflow'; did you mean '-Wshift-overflow'? [-Wunknown-warning-option]
   warning: unknown warning option '-Wformat-truncation' [-Wunknown-warning-option]
   warning: unknown warning option '-Wstringop-overflow'; did you mean '-Wshift-overflow'? [-Wunknown-warning-option]
   warning: unknown warning option '-Wstringop-truncation'; did you mean '-Wstring-concatenation'? [-Wunknown-warning-option]
>> drivers/gpu/drm/xe/xe_wait_user_fence.c:46:2: warning: variable 'passed' is used uninitialized whenever switch default is taken [-Wsometimes-uninitialized]
           default:
           ^~~~~~~
   drivers/gpu/drm/xe/xe_wait_user_fence.c:50:9: note: uninitialized use occurs here
           return passed ? 0 : 1;
                  ^~~~~~
   drivers/gpu/drm/xe/xe_wait_user_fence.c:21:13: note: initialize the variable 'passed' to silence this warning
           bool passed;
                      ^
                       = 0
   7 warnings generated.


vim +/passed +46 drivers/gpu/drm/xe/xe_wait_user_fence.c

dd08ebf6c3525a Matthew Brost   2023-03-30  16  
dd08ebf6c3525a Matthew Brost   2023-03-30  17  static int do_compare(u64 addr, u64 value, u64 mask, u16 op)
dd08ebf6c3525a Matthew Brost   2023-03-30  18  {
dd08ebf6c3525a Matthew Brost   2023-03-30  19  	u64 rvalue;
dd08ebf6c3525a Matthew Brost   2023-03-30  20  	int err;
dd08ebf6c3525a Matthew Brost   2023-03-30  21  	bool passed;
dd08ebf6c3525a Matthew Brost   2023-03-30  22  
dd08ebf6c3525a Matthew Brost   2023-03-30  23  	err = copy_from_user(&rvalue, u64_to_user_ptr(addr), sizeof(rvalue));
dd08ebf6c3525a Matthew Brost   2023-03-30  24  	if (err)
dd08ebf6c3525a Matthew Brost   2023-03-30  25  		return -EFAULT;
dd08ebf6c3525a Matthew Brost   2023-03-30  26  
dd08ebf6c3525a Matthew Brost   2023-03-30  27  	switch (op) {
76d52e37187b73 Rodrigo Vivi    2023-11-14  28  	case DRM_XE_UFENCE_WAIT_OP_EQ:
dd08ebf6c3525a Matthew Brost   2023-03-30  29  		passed = (rvalue & mask) == (value & mask);
dd08ebf6c3525a Matthew Brost   2023-03-30  30  		break;
76d52e37187b73 Rodrigo Vivi    2023-11-14  31  	case DRM_XE_UFENCE_WAIT_OP_NEQ:
dd08ebf6c3525a Matthew Brost   2023-03-30  32  		passed = (rvalue & mask) != (value & mask);
dd08ebf6c3525a Matthew Brost   2023-03-30  33  		break;
76d52e37187b73 Rodrigo Vivi    2023-11-14  34  	case DRM_XE_UFENCE_WAIT_OP_GT:
dd08ebf6c3525a Matthew Brost   2023-03-30  35  		passed = (rvalue & mask) > (value & mask);
dd08ebf6c3525a Matthew Brost   2023-03-30  36  		break;
76d52e37187b73 Rodrigo Vivi    2023-11-14  37  	case DRM_XE_UFENCE_WAIT_OP_GTE:
dd08ebf6c3525a Matthew Brost   2023-03-30  38  		passed = (rvalue & mask) >= (value & mask);
dd08ebf6c3525a Matthew Brost   2023-03-30  39  		break;
76d52e37187b73 Rodrigo Vivi    2023-11-14  40  	case DRM_XE_UFENCE_WAIT_OP_LT:
dd08ebf6c3525a Matthew Brost   2023-03-30  41  		passed = (rvalue & mask) < (value & mask);
dd08ebf6c3525a Matthew Brost   2023-03-30  42  		break;
76d52e37187b73 Rodrigo Vivi    2023-11-14  43  	case DRM_XE_UFENCE_WAIT_OP_LTE:
dd08ebf6c3525a Matthew Brost   2023-03-30  44  		passed = (rvalue & mask) <= (value & mask);
dd08ebf6c3525a Matthew Brost   2023-03-30  45  		break;
dd08ebf6c3525a Matthew Brost   2023-03-30 @46  	default:
5e0e3070659519 Francois Dugast 2023-07-27  47  		XE_WARN_ON("Not possible");
dd08ebf6c3525a Matthew Brost   2023-03-30  48  	}
dd08ebf6c3525a Matthew Brost   2023-03-30  49  
dd08ebf6c3525a Matthew Brost   2023-03-30  50  	return passed ? 0 : 1;
dd08ebf6c3525a Matthew Brost   2023-03-30  51  }
dd08ebf6c3525a Matthew Brost   2023-03-30  52  

:::::: The code at line 46 was first introduced by commit
:::::: dd08ebf6c3525a7ea2186e636df064ea47281987 drm/xe: Introduce a new DRM driver for Intel GPUs

:::::: TO: Matthew Brost <matthew.brost@intel.com>
:::::: CC: Rodrigo Vivi <rodrigo.vivi@intel.com>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

             reply	other threads:[~2023-12-16 19:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-16 19:28 kernel test robot [this message]
2023-12-16 19:28 ` [drm-xe:drm-xe-next 989/1016] drivers/gpu/drm/xe/xe_wait_user_fence.c:46:2: warning: variable 'passed' is used uninitialized whenever switch default is taken kernel test robot
2023-12-18 18:57 ` Nathan Chancellor
2023-12-18 18:57   ` Nathan Chancellor
2023-12-18 20:28   ` Lucas De Marchi
2023-12-18 20:28     ` Lucas De Marchi
2023-12-19  1:03   ` Philip Li
2023-12-19  1:03     ` Philip Li

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202312170357.KPSinwPs-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=llvm@lists.linux.dev \
    --cc=lucas.demarchi@intel.com \
    --cc=oe-kbuild-all@lists.linux.dev \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.