All of lore.kernel.org
 help / color / mirror / Atom feed
From: Miri Korenblit <miriam.rachel.korenblit@intel.com>
To: johannes@sipsolutions.net
Cc: linux-wireless@vger.kernel.org,
	Johannes Berg <johannes.berg@intel.com>,
	Luciano Coelho <luciano.coelho@intel.com>
Subject: [PATCH 01/14] iwlwifi: mvm: set siso/mimo chains to 1 in FW SMPS request
Date: Tue, 19 Dec 2023 21:58:49 +0200	[thread overview]
Message-ID: <20231219215605.7f031f1a127f.Idc816e0f604b07d22a9d5352bc23c445512fad14@changeid> (raw)
In-Reply-To: <20231219195902.3336105-1-miriam.rachel.korenblit@intel.com>

From: Johannes Berg <johannes.berg@intel.com>

The firmware changed their mind, don't set the chains to zero,
instead set them to 1 as we normally would for connections to
APs that don't use MIMO.

Fixes: 2a7ce54ccc23 ("iwlwifi: mvm: honour firmware SMPS requests")
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
Reviewed-by: Luciano Coelho <luciano.coelho@intel.com>
Signed-off-by: Miri Korenblit <miriam.rachel.korenblit@intel.com>
---
 drivers/net/wireless/intel/iwlwifi/mvm/phy-ctxt.c | 11 -----------
 1 file changed, 11 deletions(-)

diff --git a/drivers/net/wireless/intel/iwlwifi/mvm/phy-ctxt.c b/drivers/net/wireless/intel/iwlwifi/mvm/phy-ctxt.c
index 4e1fccff3987..334d1f59f6e4 100644
--- a/drivers/net/wireless/intel/iwlwifi/mvm/phy-ctxt.c
+++ b/drivers/net/wireless/intel/iwlwifi/mvm/phy-ctxt.c
@@ -99,17 +99,6 @@ static void iwl_mvm_phy_ctxt_set_rxchain(struct iwl_mvm *mvm,
 		active_cnt = 2;
 	}
 
-	/*
-	 * If the firmware requested it, then we know that it supports
-	 * getting zero for the values to indicate "use one, but pick
-	 * which one yourself", which means it can dynamically pick one
-	 * that e.g. has better RSSI.
-	 */
-	if (mvm->fw_static_smps_request && active_cnt == 1 && idle_cnt == 1) {
-		idle_cnt = 0;
-		active_cnt = 0;
-	}
-
 	*rxchain_info = cpu_to_le32(iwl_mvm_get_valid_rx_ant(mvm) <<
 					PHY_RX_CHAIN_VALID_POS);
 	*rxchain_info |= cpu_to_le32(idle_cnt << PHY_RX_CHAIN_CNT_POS);
-- 
2.34.1


  reply	other threads:[~2023-12-19 19:59 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-12-19 19:58 [PATCH 00/14] wifi: iwlwifi: updates - 2023-12-06 Miri Korenblit
2023-12-19 19:58 ` Miri Korenblit [this message]
2023-12-19 19:58 ` [PATCH 02/14] wifi: iwlwifi: mvm: Allow DFS concurrent operation Miri Korenblit
2023-12-20 19:42   ` kernel test robot
2023-12-20 20:02   ` kernel test robot
2023-12-19 19:58 ` [PATCH 03/14] wifi: iwlwifi: Don't mark DFS channels as NO-IR Miri Korenblit
2023-12-19 19:58 ` [PATCH 04/14] wifi: iwlwifi: mvm: send TX path flush in rfkill Miri Korenblit
2023-12-19 19:58 ` [PATCH 05/14] wifi: iwlwifi: mvm: d3: avoid intermediate/early mutex unlock Miri Korenblit
2023-12-19 19:58 ` [PATCH 06/14] wifi: iwlwifi: mvm: Do not warn if valid link pair was not found Miri Korenblit
2023-12-19 19:58 ` [PATCH 07/14] wifi: iwlwifi: fix out of bound copy_from_user Miri Korenblit
2023-12-19 19:58 ` [PATCH 08/14] wifi: iwlwifi: assign phy_ctxt before eSR activation Miri Korenblit
2023-12-19 19:58 ` [PATCH 09/14] wifi: iwlwifi: cleanup BT Shared Single Antenna code Miri Korenblit
2023-12-19 19:58 ` [PATCH 10/14] wifi: iwlwifi: Add rf_mapping of new wifi7 devices Miri Korenblit
2023-12-19 19:58 ` [PATCH 11/14] wifi: iwlwifi: mvm: add US/Canada MCC to API Miri Korenblit
2023-12-19 19:59 ` [PATCH 12/14] wifi: iwlwifi: mvm: disallow puncturing in US/Canada Miri Korenblit
2023-12-19 19:59 ` [PATCH 13/14] wifi: iwlwifi: mvm: use the new command to clear the internal buffer Miri Korenblit
2023-12-19 19:59 ` [PATCH 14/14] wifi: iwlwifi: replace ENOTSUPP with EOPNOTSUPP Miri Korenblit
2023-12-20 13:24 [PATCH 00/14] wifi: iwlwifi: updates - 2023-12-19 Miri Korenblit
2023-12-20 13:24 ` [PATCH 01/14] iwlwifi: mvm: set siso/mimo chains to 1 in FW SMPS request Miri Korenblit
2023-12-20 13:29 [PATCH 00/14] wifi: iwlwifi: updates - 2023-12-19 Miri Korenblit
2023-12-20 13:29 ` [PATCH 01/14] iwlwifi: mvm: set siso/mimo chains to 1 in FW SMPS request Miri Korenblit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20231219215605.7f031f1a127f.Idc816e0f604b07d22a9d5352bc23c445512fad14@changeid \
    --to=miriam.rachel.korenblit@intel.com \
    --cc=johannes.berg@intel.com \
    --cc=johannes@sipsolutions.net \
    --cc=linux-wireless@vger.kernel.org \
    --cc=luciano.coelho@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.