From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bmailout1.hostsharing.net (bmailout1.hostsharing.net [83.223.95.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E8CD118E02; Wed, 20 Dec 2023 08:14:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=wunner.de Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=h08.hostsharing.net Received: from h08.hostsharing.net (h08.hostsharing.net [83.223.95.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "*.hostsharing.net", Issuer "RapidSSL TLS RSA CA G1" (verified OK)) by bmailout1.hostsharing.net (Postfix) with ESMTPS id 218AE300002D8; Wed, 20 Dec 2023 09:14:02 +0100 (CET) Received: by h08.hostsharing.net (Postfix, from userid 100393) id 10C0DAEC0; Wed, 20 Dec 2023 09:14:02 +0100 (CET) Date: Wed, 20 Dec 2023 09:14:02 +0100 From: Lukas Wunner To: rentao.bupt@gmail.com Cc: Rob Herring , Joel Stanley , Andrew Jeffery , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org, taoren@fb.com Subject: Re: [PATCH v2 3/6] ARM: dts: aspeed: Common dtsi for Facebook AST2600 Network BMCs Message-ID: <20231220081402.GA3831@wunner.de> References: <20210805222818.8391-1-rentao.bupt@gmail.com> <20210805222818.8391-4-rentao.bupt@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210805222818.8391-4-rentao.bupt@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) On Thu, Aug 05, 2021 at 03:28:15PM -0700, rentao.bupt@gmail.com wrote: > This common descirption is included by all Facebook AST2600 Network BMC > platforms to minimize duplicated device entries across Facebook Network > BMC device trees. [...] > --- /dev/null > +++ b/arch/arm/boot/dts/ast2600-facebook-netbmc-common.dtsi [...] > + tpmdev@0 { > + compatible = "tcg,tpm_tis-spi"; What's the chip used on this board? Going forward, the DT schema for TPMs requires the exact chip name in addition to the generic "tcg,tpm_tis-spi". > + spi-max-frequency = <33000000>; > + reg = <0>; > + }; From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from lists.ozlabs.org (lists.ozlabs.org [112.213.38.117]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 8B571C46CD2 for ; Tue, 2 Jan 2024 22:47:48 +0000 (UTC) Received: from boromir.ozlabs.org (localhost [IPv6:::1]) by lists.ozlabs.org (Postfix) with ESMTP id 4T4Sfp3JV6z3bpt for ; Wed, 3 Jan 2024 09:47:46 +1100 (AEDT) Authentication-Results: lists.ozlabs.org; spf=none (no SPF record) smtp.mailfrom=h08.hostsharing.net (client-ip=2a01:37:1000::53df:5f64:0; helo=bmailout1.hostsharing.net; envelope-from=foo00@h08.hostsharing.net; receiver=lists.ozlabs.org) X-Greylist: delayed 460 seconds by postgrey-1.37 at boromir; Wed, 20 Dec 2023 19:21:54 AEDT Received: from bmailout1.hostsharing.net (bmailout1.hostsharing.net [IPv6:2a01:37:1000::53df:5f64:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 4Sw63k1QKzz30RS; Wed, 20 Dec 2023 19:21:54 +1100 (AEDT) Received: from h08.hostsharing.net (h08.hostsharing.net [83.223.95.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "*.hostsharing.net", Issuer "RapidSSL TLS RSA CA G1" (verified OK)) by bmailout1.hostsharing.net (Postfix) with ESMTPS id 218AE300002D8; Wed, 20 Dec 2023 09:14:02 +0100 (CET) Received: by h08.hostsharing.net (Postfix, from userid 100393) id 10C0DAEC0; Wed, 20 Dec 2023 09:14:02 +0100 (CET) Date: Wed, 20 Dec 2023 09:14:02 +0100 From: Lukas Wunner To: rentao.bupt@gmail.com Subject: Re: [PATCH v2 3/6] ARM: dts: aspeed: Common dtsi for Facebook AST2600 Network BMCs Message-ID: <20231220081402.GA3831@wunner.de> References: <20210805222818.8391-1-rentao.bupt@gmail.com> <20210805222818.8391-4-rentao.bupt@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20210805222818.8391-4-rentao.bupt@gmail.com> User-Agent: Mutt/1.10.1 (2018-07-13) X-Mailman-Approved-At: Wed, 03 Jan 2024 09:46:15 +1100 X-BeenThere: openbmc@lists.ozlabs.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Development list for OpenBMC List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: devicetree@vger.kernel.org, linux-aspeed@lists.ozlabs.org, Andrew Jeffery , taoren@fb.com, openbmc@lists.ozlabs.org, linux-kernel@vger.kernel.org, Rob Herring , Joel Stanley , linux-arm-kernel@lists.infradead.org Errors-To: openbmc-bounces+openbmc=archiver.kernel.org@lists.ozlabs.org Sender: "openbmc" On Thu, Aug 05, 2021 at 03:28:15PM -0700, rentao.bupt@gmail.com wrote: > This common descirption is included by all Facebook AST2600 Network BMC > platforms to minimize duplicated device entries across Facebook Network > BMC device trees. [...] > --- /dev/null > +++ b/arch/arm/boot/dts/ast2600-facebook-netbmc-common.dtsi [...] > + tpmdev@0 { > + compatible = "tcg,tpm_tis-spi"; What's the chip used on this board? Going forward, the DT schema for TPMs requires the exact chip name in addition to the generic "tcg,tpm_tis-spi". > + spi-max-frequency = <33000000>; > + reg = <0>; > + };