Hi Al, On Wed, 20 Dec 2023 01:34:02 +0000 Al Viro wrote: > > My suggested resolution had been wrong, actually - the way it's written, > link count drop should be conditional on old_is_dir, cross-directory or > not. > > I think the right solution is > if (old_dir_entry) > f2fs_set_link(old_inode, old_dir_entry, old_dir_page, new_dir); > if (old_is_dir) > f2fs_i_links_write(old_dir, false); Ok, I will fix it up. -- Cheers, Stephen Rothwell