Re: [PATCH v3 0/4] dt-bindings: tpm: Clean all the things

From: Rob Herring <robh@kernel.org>
To: Lukas Wunner <lukas@wunner.de>
Cc: Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Jarkko Sakkinen <jarkko@kernel.org>,
	Peter Huewe <peterhuewe@gmx.de>, Jason Gunthorpe <jgg@ziepe.ca>,
	devicetree@vger.kernel.org, linux-integrity@vger.kernel.org,
	Lino Sanfilippo <LinoSanfilippo@gmx.de>,
	Nayna Jain <nayna@linux.ibm.com>,
	Thirupathaiah Annapureddy <thiruan@microsoft.com>,
	Sasha Levin <sashal@kernel.org>,
	Andrey Pronin <apronin@chromium.org>,
	Alexander Steffen <Alexander.Steffen@infineon.com>,
	Johannes Holland <Johannes.Holland@infineon.com>,
	Amir Mizinski <amirmizi6@gmail.com>,
	Benoit HOUYERE <benoit.houyere@st.com>,
	Peter Delevoryas <peter@pjd.dev>,
	Ninad Palsule <ninad@linux.ibm.com>,
	Guenter Roeck <linux@roeck-us.net>,
	Francesco Dolcini <francesco@dolcini.it>,
	Nishanth Menon <nm@ti.com>
Subject: Re: [PATCH v3 0/4] dt-bindings: tpm: Clean all the things
Date: Wed, 20 Dec 2023 10:04:22 -0600	[thread overview]
Message-ID: <20231220160422.GA282877-robh@kernel.org> (raw)
In-Reply-To: <cover.1702806810.git.lukas@wunner.de>

On Sun, Dec 17, 2023 at 11:13:30AM +0100, Lukas Wunner wrote:
> TPM dt-bindings cleanup, take three.
> 
> The existing devicetrees in arch/arm and arch/arm64 contain a few
> violations of the schemas contained herein.  E.g. the nodename is
> not "tpm@..." but "tpmdev@..." in some cases.  I've got patches
> lined up to fix these issues and will submit them separately.
> 
> Changes v2 -> v3:
> * [PATCH 1/4]:
>   * Drop clock-frequency property from tcg,tpm-tis-i2c.yaml.
>     It doesn't exist at the peripheral level, only at the
>     controller level.  Document maximum clock frequency for
>     infineon,slb9635tt and infineon,slb9645tt in textual form
>     (as was previously done in trivial-devices.yaml).
>   * Document reset-gpios property as used by:
>     arch/arm64/boot/dts/freescale/imx8mp-beacon-kit.dts
> 
> * [PATCH 2/4]:
>   * Introduce new schema specifically for google,cr50 (Rob).
>     Note that I can't use "oneOf" for SPI and I²C properties
>     because a node with only a "reg" property is a valid SPI
>     and I²C node and would match both subschemas.
>     So "anyOf" it is.
> 
> * [PATCH 4/4]:
>   * Use "const" instead of "enum" for singleton compatible string.
> 
> Link to v2:
> https://lore.kernel.org/linux-devicetree/cover.1701093036.git.lukas@wunner.de/
> 
> 
> Lukas Wunner (4):
>   dt-bindings: tpm: Consolidate TCG TIS bindings
>   dt-bindings: tpm: Convert Google Cr50 bindings to DT schema
>   dt-bindings: tpm: Convert IBM vTPM bindings to DT schema
>   dt-bindings: tpm: Document Microsoft fTPM bindings

Reviewed-by: Rob Herring <robh@kernel.org>

Great to have this done finally! Thanks for picking it up. If the TPM 
maintainers don't pick it up for 6.8, I will.

Rob