From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D9CA71BDCE; Tue, 16 Jan 2024 00:23:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="hL9eZ5PL" Received: by smtp.kernel.org (Postfix) with ESMTPSA id CFC84C433C7; Tue, 16 Jan 2024 00:23:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705364625; bh=K4xgG6Zt6TW6EJG0eRUViQAzIY/jyHuCmxXtXWtqEng=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hL9eZ5PLPijE7Qm3JfMhxQuAH8pL+6JOHT29+CzgGLSlpSNzMeS1bj3CPTn9PEVFX GVal0UkQTheWrE1CRCDslZUj1YoT6LS5Fha0WNfr0pA15Ibb5d4vbc+N7pAsYdp5HS PkswocltFGLIefhdSK1HeGmfFbMlT85TH68vWLGWzhU1+HL9RnMlZOH9S3Wj+EdW+b XcYIKFuNEx5AwxlhPP2yPU/r93D05RHhn5PQJaHEwKNWY/MePe7+A80cJdErGFhgyc 0++vZLl5jHSPTtdrayWR3IJAEPOHL2DjlcPjbotpJ94h2zZu2MZmrybYQYulfuaKOP w0dEPTv4PAzwA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Thomas Bourgoin , kernel test robot , Dan Carpenter , Herbert Xu , Sasha Levin , davem@davemloft.net, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, ebiggers@google.com, u.kleine-koenig@pengutronix.de, linux-crypto@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: [PATCH AUTOSEL 6.7 14/19] crypto: stm32/crc32 - fix parsing list of devices Date: Mon, 15 Jan 2024 19:22:50 -0500 Message-ID: <20240116002311.214705-14-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240116002311.214705-1-sashal@kernel.org> References: <20240116002311.214705-1-sashal@kernel.org> Precedence: bulk X-Mailing-List: linux-crypto@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.7 Content-Transfer-Encoding: 8bit From: Thomas Bourgoin [ Upstream commit 0eaef675b94c746900dcea7f6c41b9a103ed5d53 ] smatch warnings: drivers/crypto/stm32/stm32-crc32.c:108 stm32_crc_get_next_crc() warn: can 'crc' even be NULL? Use list_first_entry_or_null instead of list_first_entry to retrieve the first device registered. The function list_first_entry always return a non NULL pointer even if the list is empty. Hence checking if the pointer returned is NULL does not tell if the list is empty or not. Reported-by: kernel test robot Closes: https://lore.kernel.org/r/202311281111.ou2oUL2i-lkp@intel.com/ Reported-by: Dan Carpenter Closes: https://lore.kernel.org/r/202311281111.ou2oUL2i-lkp@intel.com/ Signed-off-by: Thomas Bourgoin Signed-off-by: Herbert Xu Signed-off-by: Sasha Levin --- drivers/crypto/stm32/stm32-crc32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/stm32/stm32-crc32.c b/drivers/crypto/stm32/stm32-crc32.c index b2d5c8921ab3..b0cf6d2fd352 100644 --- a/drivers/crypto/stm32/stm32-crc32.c +++ b/drivers/crypto/stm32/stm32-crc32.c @@ -104,7 +104,7 @@ static struct stm32_crc *stm32_crc_get_next_crc(void) struct stm32_crc *crc; spin_lock_bh(&crc_list.lock); - crc = list_first_entry(&crc_list.dev_list, struct stm32_crc, list); + crc = list_first_entry_or_null(&crc_list.dev_list, struct stm32_crc, list); if (crc) list_move_tail(&crc->list, &crc_list.dev_list); spin_unlock_bh(&crc_list.lock); -- 2.43.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 92486C3DA79 for ; Tue, 16 Jan 2024 00:24:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=cidBFzhZrP85zPUb1l+yPcY7mORZtkURkpCmtiQZuT8=; b=Q4/B6be1Hc75Gp x0Q7glvVFBZP5CS0bVrrIAjGcnSwQaKzFzYDDt5aV4b0qpM6vrA43KokqCwnbsgKsFCK+HwtPTINl VGp5Ji42k/qaHpfRLvF09SU9pURTqRK+0KjUPxS0GFrpyQhvz2aqbDr2SWzJt/JBjB9y290GhJlb2 3IpTZawwDj4l4NKpOktXmLpl0vP7EDTbeLuVgqmJ1VuZMQbaxErZU+XeNI1xXjI2u+g6HLaRRAp8M CqGIOVnntCZrvw41chNBbDckbKM3aW8OB0Mu68sjwKvxuu8gZlsSGiLwRMWq0rS9QinnBEy6v+FCX eF6iCg2GOvE9XE4KIpnA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1rPXFC-00AUpF-0a; Tue, 16 Jan 2024 00:23:54 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1rPXF8-00AUm5-0N for linux-arm-kernel@lists.infradead.org; Tue, 16 Jan 2024 00:23:52 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by sin.source.kernel.org (Postfix) with ESMTP id 1E1AFCE18C8; Tue, 16 Jan 2024 00:23:46 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id CFC84C433C7; Tue, 16 Jan 2024 00:23:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1705364625; bh=K4xgG6Zt6TW6EJG0eRUViQAzIY/jyHuCmxXtXWtqEng=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hL9eZ5PLPijE7Qm3JfMhxQuAH8pL+6JOHT29+CzgGLSlpSNzMeS1bj3CPTn9PEVFX GVal0UkQTheWrE1CRCDslZUj1YoT6LS5Fha0WNfr0pA15Ibb5d4vbc+N7pAsYdp5HS PkswocltFGLIefhdSK1HeGmfFbMlT85TH68vWLGWzhU1+HL9RnMlZOH9S3Wj+EdW+b XcYIKFuNEx5AwxlhPP2yPU/r93D05RHhn5PQJaHEwKNWY/MePe7+A80cJdErGFhgyc 0++vZLl5jHSPTtdrayWR3IJAEPOHL2DjlcPjbotpJ94h2zZu2MZmrybYQYulfuaKOP w0dEPTv4PAzwA== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Thomas Bourgoin , kernel test robot , Dan Carpenter , Herbert Xu , Sasha Levin , davem@davemloft.net, mcoquelin.stm32@gmail.com, alexandre.torgue@foss.st.com, ebiggers@google.com, u.kleine-koenig@pengutronix.de, linux-crypto@vger.kernel.org, linux-stm32@st-md-mailman.stormreply.com, linux-arm-kernel@lists.infradead.org Subject: [PATCH AUTOSEL 6.7 14/19] crypto: stm32/crc32 - fix parsing list of devices Date: Mon, 15 Jan 2024 19:22:50 -0500 Message-ID: <20240116002311.214705-14-sashal@kernel.org> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20240116002311.214705-1-sashal@kernel.org> References: <20240116002311.214705-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-stable-base: Linux 6.7 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240115_162350_331170_6849E184 X-CRM114-Status: GOOD ( 12.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Thomas Bourgoin [ Upstream commit 0eaef675b94c746900dcea7f6c41b9a103ed5d53 ] smatch warnings: drivers/crypto/stm32/stm32-crc32.c:108 stm32_crc_get_next_crc() warn: can 'crc' even be NULL? Use list_first_entry_or_null instead of list_first_entry to retrieve the first device registered. The function list_first_entry always return a non NULL pointer even if the list is empty. Hence checking if the pointer returned is NULL does not tell if the list is empty or not. Reported-by: kernel test robot Closes: https://lore.kernel.org/r/202311281111.ou2oUL2i-lkp@intel.com/ Reported-by: Dan Carpenter Closes: https://lore.kernel.org/r/202311281111.ou2oUL2i-lkp@intel.com/ Signed-off-by: Thomas Bourgoin Signed-off-by: Herbert Xu Signed-off-by: Sasha Levin --- drivers/crypto/stm32/stm32-crc32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/stm32/stm32-crc32.c b/drivers/crypto/stm32/stm32-crc32.c index b2d5c8921ab3..b0cf6d2fd352 100644 --- a/drivers/crypto/stm32/stm32-crc32.c +++ b/drivers/crypto/stm32/stm32-crc32.c @@ -104,7 +104,7 @@ static struct stm32_crc *stm32_crc_get_next_crc(void) struct stm32_crc *crc; spin_lock_bh(&crc_list.lock); - crc = list_first_entry(&crc_list.dev_list, struct stm32_crc, list); + crc = list_first_entry_or_null(&crc_list.dev_list, struct stm32_crc, list); if (crc) list_move_tail(&crc->list, &crc_list.dev_list); spin_unlock_bh(&crc_list.lock); -- 2.43.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel