From: Steven Rostedt <rostedt@goodmis.org>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux Trace Kernel <linux-trace-kernel@vger.kernel.org>,
Masami Hiramatsu <mhiramat@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Mathieu Desnoyers <mathieu.desnoyers@efficios.com>,
Christian Brauner <brauner@kernel.org>,
Al Viro <viro@zeniv.linux.org.uk>,
Ajay Kaher <ajay.kaher@broadcom.com>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>,
kernel test robot <oliver.sang@intel.com>
Subject: Re: [PATCH v2 2/2] eventfs: Create list of files and directories at dir open
Date: Tue, 16 Jan 2024 17:01:54 -0500 [thread overview]
Message-ID: <20240116170154.5bf0a250@gandalf.local.home> (raw)
In-Reply-To: <CAHk-=wgjSuapZoWfQZMyFi80wJE6a=vjOdgpy_k+YaWwbX9Pig@mail.gmail.com>
On Tue, 16 Jan 2024 13:39:38 -0800
Linus Torvalds <torvalds@linux-foundation.org> wrote:
> I don't understand why your still insist on this pointless open wrapper.
I just liked the consistency of it.
>
> Just do this all at iterate time. No open wrappers. No nothing. Just
> iterate over the days structures your have.
>
> IOW, instead of iterating in open to create the array, just iterate in -
> look, it's in the *name* for chrissake - iterate_shared.
>
> No array. No random allocation for said array.
>
> If you can iterate at open time, you can iterate at iterate_shared time.
> Stop creating a list that your already have.
>
> And nobody cares if you do a readdir at the same time as modifying the
> directory. This isn't a real filesystem with strict POSIX semantics.
OK, I can do that.
-- Steve
prev parent reply other threads:[~2024-01-16 22:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-01-16 21:12 [PATCH v2 0/2] eventfs: Create dentries and inodes at dir open Steven Rostedt
2024-01-16 21:12 ` [PATCH v2 1/2] eventfs: Have the inodes all for files and directories all be the same Steven Rostedt
2024-01-16 21:12 ` [PATCH v2 2/2] eventfs: Create list of files and directories at dir open Steven Rostedt
[not found] ` <CAHk-=wgjSuapZoWfQZMyFi80wJE6a=vjOdgpy_k+YaWwbX9Pig@mail.gmail.com>
2024-01-16 22:01 ` Steven Rostedt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240116170154.5bf0a250@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=ajay.kaher@broadcom.com \
--cc=brauner@kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=oliver.sang@intel.com \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.