All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH v4 0/4] ASoC: qcom: volume fixes and codec cleanups
@ 2024-01-19 11:24 Johan Hovold
  2024-01-19 11:24 ` [PATCH v4 1/4] ASoC: codecs: wsa883x: fix PA volume control Johan Hovold
                   ` (4 more replies)
  0 siblings, 5 replies; 17+ messages in thread
From: Johan Hovold @ 2024-01-19 11:24 UTC (permalink / raw)
  To: Mark Brown
  Cc: Srinivas Kandagatla, Banajit Goswami, Liam Girdwood,
	Jaroslav Kysela, Takashi Iwai, alsa-devel, linux-sound,
	linux-kernel, Johan Hovold

To reduce the risk of speaker damage the PA gain needs to be limited on
machines like the Lenovo Thinkpad X13s until we have active speaker
protection in place.

Limit the gain to the current default setting provided by the UCM
configuration which most user have so far been using (due to a bug in
the configuration files which prevented hardware volume control [1]).

The wsa883x PA volume control also turned out to be broken, which meant
that the default setting used by UCM configuration is actually the
lowest level (-3 dB). With the codec driver fixed, hardware volume
control also works as expected.

Note that the new wsa884x driver most likely suffers from a similar bug,
I'll send a fix for that once I've got that confirmed.

Included is also a related fix for the LPASS WSA macro driver, which
was changing the digital gain setting behind the back of user space and
which can result in excessive (or too low) digital gain.

There are further Qualcomm codec drivers that similarly appear to
manipulate various gain settings, but on closer inspection it turns out
that they only write back the current settings. Tests reveal that these
writes are indeed needed for any prior updates to take effect (at least
for the WSA and RX macros).

Johan

[1] https://github.com/alsa-project/alsa-ucm-conf/pull/382


Changes in v4
 - keep the full PA volume control range and only fix the exported dB
   values
 - use a combined -3 dB machine limit as limiting just the PA volume
   confuses PulseAudio
 - drop the PA gain initialisation which is no longer needed

Changes in v3
 - fix the wsa883x PA volume control and update the machine limits
   accordingly

Changes in v2
 - keep the volume register write on power-on in lpass-wsa-macro
 - drop the other patches removing volume register writes on DAPM events
 - only drop the constant-zero gain offsets in wcd9335


Johan Hovold (4):
  ASoC: codecs: wsa883x: fix PA volume control
  ASoC: qcom: sc8280xp: limit speaker volumes
  ASoC: codecs: lpass-wsa-macro: fix compander volume hack
  ASoC: codecs: wcd9335: drop unused gain hack remnant

 sound/soc/codecs/lpass-wsa-macro.c |  7 -------
 sound/soc/codecs/wcd9335.c         |  4 ----
 sound/soc/codecs/wsa883x.c         |  6 +++++-
 sound/soc/qcom/sc8280xp.c          | 12 +++++++-----
 4 files changed, 12 insertions(+), 17 deletions(-)

-- 
2.41.0


^ permalink raw reply	[flat|nested] 17+ messages in thread

end of thread, other threads:[~2024-01-23 13:57 UTC | newest]

Thread overview: 17+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-01-19 11:24 [PATCH v4 0/4] ASoC: qcom: volume fixes and codec cleanups Johan Hovold
2024-01-19 11:24 ` [PATCH v4 1/4] ASoC: codecs: wsa883x: fix PA volume control Johan Hovold
2024-01-19 11:24 ` [PATCH v4 2/4] ASoC: qcom: sc8280xp: limit speaker volumes Johan Hovold
2024-01-19 15:26   ` Johan Hovold
2024-01-22  0:03   ` Mark Brown
2024-01-22  7:41     ` Johan Hovold
2024-01-22 16:05       ` Mark Brown
2024-01-22 17:29         ` Johan Hovold
2024-01-22 18:06           ` Mark Brown
2024-01-22 18:21             ` Johan Hovold
2024-01-19 11:24 ` [PATCH v4 3/4] ASoC: codecs: lpass-wsa-macro: fix compander volume hack Johan Hovold
2024-01-19 11:24 ` [PATCH v4 4/4] ASoC: codecs: wcd9335: drop unused gain hack remnant Johan Hovold
2024-01-22 21:54 ` [PATCH v4 0/4] ASoC: qcom: volume fixes and codec cleanups Mark Brown
2024-01-23  7:58   ` Johan Hovold
2024-01-23 13:05     ` Mark Brown
2024-01-23 13:30       ` Johan Hovold
2024-01-23 13:57         ` Mark Brown

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.