From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AD0383D56C for ; Wed, 31 Jan 2024 05:23:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706678620; cv=none; b=dYUIxp/oIZHDSuX8e8UZm1y8Ue8hUKAPRgK9GAxKWpfORggNqRk3ofh/yD2W9lCUe2JEVkg49ij02x8Fbk0+N0bkb8meeJt81IChkvFPCzISid3vY1E1NXFrtABk/2IzVmKJB+/KVgdX7VWy89gMbY6pmixEuI1kLUuCGtUFVnw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706678620; c=relaxed/simple; bh=L0p7ixoYzTuLRVQ7tvm91KGfjN08Kl6GBFk8OqLI6OE=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=qzL3Mq5vyh3KiZW5A8gF+tE6fR72cs/+GrP5yE1oWDeCTw6ybUdqzCpIAhgzM/T7ND6un0xzHheDwx8fOBgX0EAyjTjPF7kCHbTeElwLRf/arKDLnahI8Gam6jAMfqyPu6lHnk+AYLp9qvkswQaF9TPD47nWHxCWki0qb7nuFBg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=Yzzl1MsB; arc=none smtp.client-ip=209.85.216.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="Yzzl1MsB" Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-29041136f73so2522028a91.0 for ; Tue, 30 Jan 2024 21:23:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1706678618; x=1707283418; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=cB/uX9Ocu3GZVsO7k6nFsrnvwZVXV/HVGYWM4rZmpjk=; b=Yzzl1MsBjGDQhRf1Dxixh/bOPYher167GDaQePCdnp9NSjqghUeBE8t88T0NYzOETv Akm9YZxh5tBZQbKeTFge/lPlbtj2lBuxZBY3vIJCL9SdkC2AME1nMNJRIcVmkcISIqPs kQzVZllpW/bmjsEKKsEc3+CeNKmakaiM0+di5WpTKiaRrvP9R0KZm1O0kxOKL0Jf0zf0 6vEQcrmwCDSUWEgTYVbXgixe1RJ1OpSHmMb5D5iTVGZBjZljmzTJkRwWR8irhntnDlX5 H2xQA8dPggf4KQoB5DEq4UOYyfBe82s0rhcxaNOFu7DABBdIbvnx+lpvRGot3es/beDr 4xAg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1706678618; x=1707283418; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=cB/uX9Ocu3GZVsO7k6nFsrnvwZVXV/HVGYWM4rZmpjk=; b=A3x6GIN+3rtSMRqui2V2I2P2ZWZMUMcAN48PHiZC6hshs2uqqFPe3tfnez7re0rxaj /HVbqtT7E54Yk0HlfRgat054tYO2hLdm9L/gVpOrGlsfdTwuUCSOemrF4pDEERmfsJwX s7w3sjpzuUdBmssrm0q5NJq8y3LN8ERoRTZFPNLjw7N/j9EjmN14g/GVspgAtUG/iVLJ jXESUB7i7US0+Z3TmEinDPHWppOjmaXQgRBFKNa46OuhCsgBvYHdH3UjGa9O1qedvkCo LjBsrD7DYfh87P48EQWi9cq++RZFjQfq8NTAD7IDcgfz8u7uDXg2cPKLLx4uYdJBPXj9 R4Uw== X-Gm-Message-State: AOJu0YyZ5sWiGcIGjNL7R6eMe6gWc/Ixo6hgblTMpkc+v/sWfjblfqyK zNpceukGoBjnZoZ1o4xFaefKCi/jBE67qp6/1OHq42SW1ZtW+AJZt2MlxQXEdW3YqTnAPfq+6zR B X-Google-Smtp-Source: AGHT+IFVUXicyliLtZJ8DOMkazOx8shXzWZk/TfrCAd+7gzTLSrdbtiAadd8bgzl+WwpG8GaYqrLiw== X-Received: by 2002:a17:90b:507:b0:295:bea4:a16e with SMTP id r7-20020a17090b050700b00295bea4a16emr723201pjz.23.1706678617971; Tue, 30 Jan 2024 21:23:37 -0800 (PST) Received: from localhost ([122.172.83.95]) by smtp.gmail.com with ESMTPSA id rm13-20020a17090b3ecd00b0029494384eaasm393119pjb.43.2024.01.30.21.23.37 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 30 Jan 2024 21:23:37 -0800 (PST) Date: Wed, 31 Jan 2024 10:53:35 +0530 From: Viresh Kumar To: Manivannan Sadhasivam Cc: Krishna chaitanya chundru , Bjorn Andersson , Konrad Dybcio , Bjorn Helgaas , Lorenzo Pieralisi , Krzysztof =?utf-8?Q?Wilczy=C5=84ski?= , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Rob Herring , Johan Hovold , Brian Masney , Georgi Djakov , linux-arm-msm@vger.kernel.org, vireshk@kernel.org, quic_vbadigan@quicinc.com, quic_skananth@quicinc.com, quic_nitegupt@quicinc.com, linux-pci@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v6 5/6] arm64: dts: qcom: sm8450: Add opp table support to PCIe Message-ID: <20240131052335.6nqpmccgr64voque@vireshk-i7> References: <20240112-opp_support-v6-0-77bbf7d0cc37@quicinc.com> <20240112-opp_support-v6-5-77bbf7d0cc37@quicinc.com> <20240129160420.GA27739@thinkpad> <20240130061111.eeo2fzaltpbh35sj@vireshk-i7> <20240130071449.GG32821@thinkpad> <20240130083619.lqbj47fl7aa5j3k5@vireshk-i7> <20240130094804.GD83288@thinkpad> <20240130095508.zgufudflizrpxqhy@vireshk-i7> <20240130131625.GA2554@thinkpad> Precedence: bulk X-Mailing-List: linux-arm-msm@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240130131625.GA2554@thinkpad> On 30-01-24, 18:46, Manivannan Sadhasivam wrote: > Agree. But what I'm saying is, right now there is no DT property in the > interconnect consumer nodes to specificy the bw requirements. This is all > hardcoded in the respective ICC consumer drivers. I thought there are a lot of users already in there.. $ git grep -i opp.*bps arch/arm64/boot/dts/ | wc -l 864 > But when we use OPP to control bw, the bw requirements come from DT. This is > what I see as a difference. Because, only nodes making use of OPP will specify > bw in DT and other nodes making use of just ICC will not. > > Maybe I'm worrying too much about these details... But it looks like > inconsistency to me. Right. So is there inconsistency right now ? Yes, there is. The important question we need to answer is where do we want to see all these drivers (specially new ones) in the future. What's the right thing to do eventually ? Hardcode stuff ? Or Move it to DT ? The answer is DT for me, so the code can be generic enough to be reused. This is just one step in the right direction I guess. Eventually the drivers must get simplified, which they are I guess. -- viresh