From: Kees Cook <keescook@chromium.org>
To: Andy Shevchenko <andy@kernel.org>
Cc: Kees Cook <keescook@chromium.org>,
Rasmus Villemoes <rasmus.villemoes@prevas.dk>,
"Gustavo A. R. Silva" <gustavoars@kernel.org>,
Marco Elver <elver@google.com>,
Eric Biggers <ebiggers@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org, linux-hardening@vger.kernel.org
Subject: [PATCH v5 0/3] overflow: Introduce wrapping helpers
Date: Wed, 7 Feb 2024 07:24:17 -0800 [thread overview]
Message-ID: <20240207152317.do.560-kees@kernel.org> (raw)
v5: drop redundant checks (gustavo)
v4: https://lore.kernel.org/linux-hardening/20240206102354.make.081-kees@kernel.org/
v3: https://lore.kernel.org/all/20240205090854.make.507-kees@kernel.org/
v2: https://lore.kernel.org/all/20240130220218.it.154-kees@kernel.org/
v1: https://lore.kernel.org/lkml/20240129182845.work.694-kees@kernel.org/
Hi,
In preparation for gaining instrumentation for signed[1], unsigned[2], and
pointer[3] wrap-around, expand the overflow header to include wrap-around
helpers that can be used to annotate arithmetic where wrapped calculations
are expected (e.g. atomics).
After spending time getting the unsigned integer wrap-around sanitizer
running warning-free on a basic x86_64 boot[4], I think the add/sub/mul
helpers first argument being the output type makes the most sense (as
suggested by Rasmus).
-Kees
Kees Cook (3):
overflow: Adjust check_*_overflow() kern-doc to reflect results
overflow: Introduce wrapping_add(), wrapping_sub(), and wrapping_mul()
overflow: Introduce wrapping_inc() and wrapping_dec()
include/linux/overflow.h | 98 +++++++++++++++++++++++++++++++++++-----
lib/overflow_kunit.c | 67 +++++++++++++++++++++++++--
2 files changed, 149 insertions(+), 16 deletions(-)
--
2.34.1
next reply other threads:[~2024-02-07 15:24 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-07 15:24 Kees Cook [this message]
2024-02-07 15:24 ` [PATCH v5 1/3] overflow: Adjust check_*_overflow() kern-doc to reflect results Kees Cook
2024-02-07 15:24 ` [PATCH v5 2/3] overflow: Introduce wrapping_add(), wrapping_sub(), and wrapping_mul() Kees Cook
2024-02-07 18:06 ` Marco Elver
2024-02-07 15:24 ` [PATCH v5 3/3] overflow: Introduce wrapping_inc() and wrapping_dec() Kees Cook
2024-02-07 15:31 ` Andy Shevchenko
2024-02-07 16:08 ` Kees Cook
2024-02-07 16:34 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240207152317.do.560-kees@kernel.org \
--to=keescook@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=andy@kernel.org \
--cc=ebiggers@kernel.org \
--cc=elver@google.com \
--cc=gustavoars@kernel.org \
--cc=linux-hardening@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=rasmus.villemoes@prevas.dk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.