Re: [PATCH] net/nfp: add support of UDP fragmentation offload

From: Stephen Hemminger <stephen@networkplumber.org>
To: Chaoyong He <chaoyong.he@corigine.com>
Cc: dev@dpdk.org, oss-drivers@corigine.com,
	Long Wu <long.wu@corigine.com>,
	Peng Zhang <peng.zhang@corigine.com>
Subject: Re: [PATCH] net/nfp: add support of UDP fragmentation offload
Date: Sat, 17 Feb 2024 08:47:25 -0800	[thread overview]
Message-ID: <20240217084725.5a1c6f34@hermes.local> (raw)
In-Reply-To: <20240217015410.2163102-1-chaoyong.he@corigine.com>

On Sat, 17 Feb 2024 09:54:10 +0800
Chaoyong He <chaoyong.he@corigine.com> wrote:

> Add the support of UDP fragmentation offload feature.
> 
> Signed-off-by: Chaoyong He <chaoyong.he@corigine.com>
> Reviewed-by: Long Wu <long.wu@corigine.com>
> Reviewed-by: Peng Zhang <peng.zhang@corigine.com>
> ---
>  drivers/common/nfp/nfp_common_ctrl.h | 1 +
>  drivers/net/nfp/nfd3/nfp_nfd3_dp.c   | 7 ++++++-
>  drivers/net/nfp/nfdk/nfp_nfdk_dp.c   | 8 +++++---
>  drivers/net/nfp/nfp_net_common.c     | 8 ++++++--
>  4 files changed, 18 insertions(+), 6 deletions(-)

Looks like this depends on earlier patch, it does not apply directly to main branch.

> -	if ((ol_flags & RTE_MBUF_F_TX_TCP_SEG) == 0)
> +	if ((ol_flags & RTE_MBUF_F_TX_TCP_SEG) == 0 &&
> +			(ol_flags & RTE_MBUF_F_TX_UDP_SEG) == 0)
>  		goto clean_txd;

That is odd indentation style.
Should be:

	if ((ol_flags & RTE_MBUF_F_TX_TCP_SEG) == 0 &&
	    (ol_flags & RTE_MBUF_F_TX_UDP_SEG) == 0)
		goto clean_txd;