From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <buildroot-bounces@buildroot.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by smtp.lore.kernel.org (Postfix) with ESMTPS id E7231C48BF8
	for <buildroot@archiver.kernel.org>; Tue, 20 Feb 2024 02:00:20 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
	by smtp4.osuosl.org (Postfix) with ESMTP id 1A5AF405A0;
	Tue, 20 Feb 2024 02:00:20 +0000 (UTC)
X-Virus-Scanned: amavisd-new at osuosl.org
Received: from smtp4.osuosl.org ([127.0.0.1])
	by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)
	with ESMTP id dR5sp0eXfjBL; Tue, 20 Feb 2024 02:00:19 +0000 (UTC)
X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=buildroot-bounces@buildroot.org; receiver=<UNKNOWN> 
DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org DA19940598
Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34])
	by smtp4.osuosl.org (Postfix) with ESMTP id DA19940598;
	Tue, 20 Feb 2024 02:00:18 +0000 (UTC)
Received: from smtp3.osuosl.org (smtp3.osuosl.org [140.211.166.136])
 by ash.osuosl.org (Postfix) with ESMTP id 832FA1BF330
 for <buildroot@lists.busybox.net>; Tue, 20 Feb 2024 02:00:17 +0000 (UTC)
Received: from localhost (localhost [127.0.0.1])
 by smtp3.osuosl.org (Postfix) with ESMTP id 7EC3860747
 for <buildroot@lists.busybox.net>; Tue, 20 Feb 2024 02:00:17 +0000 (UTC)
X-Virus-Scanned: amavisd-new at osuosl.org
Received: from smtp3.osuosl.org ([127.0.0.1])
 by localhost (smtp3.osuosl.org [127.0.0.1]) (amavisd-new, port 10024)
 with ESMTP id BGwPYw8jas16 for <buildroot@lists.busybox.net>;
 Tue, 20 Feb 2024 02:00:16 +0000 (UTC)
Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=198.47.23.248;
 helo=lelv0143.ext.ti.com; envelope-from=dannenberg@ti.com; receiver=<UNKNOWN> 
DMARC-Filter: OpenDMARC Filter v1.4.2 smtp3.osuosl.org 6B3B1606A9
DKIM-Filter: OpenDKIM Filter v2.11.0 smtp3.osuosl.org 6B3B1606A9
Received: from lelv0143.ext.ti.com (lelv0143.ext.ti.com [198.47.23.248])
 by smtp3.osuosl.org (Postfix) with ESMTPS id 6B3B1606A9
 for <buildroot@buildroot.org>; Tue, 20 Feb 2024 02:00:15 +0000 (UTC)
Received: from fllv0035.itg.ti.com ([10.64.41.0])
 by lelv0143.ext.ti.com (8.15.2/8.15.2) with ESMTP id 41K20BdR062627;
 Mon, 19 Feb 2024 20:00:11 -0600
Received: from DLEE114.ent.ti.com (dlee114.ent.ti.com [157.170.170.25])
 by fllv0035.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 41K20Bsi092210
 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL);
 Mon, 19 Feb 2024 20:00:11 -0600
Received: from DLEE105.ent.ti.com (157.170.170.35) by DLEE114.ent.ti.com
 (157.170.170.25) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23; Mon, 19
 Feb 2024 20:00:11 -0600
Received: from lelvsmtp5.itg.ti.com (10.180.75.250) by DLEE105.ent.ti.com
 (157.170.170.35) with Microsoft SMTP Server (version=TLS1_2,
 cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.23 via
 Frontend Transport; Mon, 19 Feb 2024 20:00:11 -0600
Received: from dasso (dasso.dhcp.ti.com [128.247.79.182])
 by lelvsmtp5.itg.ti.com (8.15.2/8.15.2) with ESMTP id 41K20B5l037779;
 Mon, 19 Feb 2024 20:00:11 -0600
Date: Mon, 19 Feb 2024 20:00:11 -0600
To: Romain Naour <romain.naour@smile.fr>
Message-ID: <20240220020011.x7mfxcs5oxbr5s3d@dasso>
References: <20240217160244.1320482-1-dario.binacchi@amarulasolutions.com>
 <20240217160244.1320482-15-dario.binacchi@amarulasolutions.com>
 <95a8a71f608575339cd61ba5ed09b93d8714c01c.camel@gmail.com>
 <20240219205157.5ukm426gmzbvn33f@dasso>
 <63d28259-ff96-4450-bdc5-e1bc209d8e59@smile.fr>
MIME-Version: 1.0
Content-Disposition: inline
In-Reply-To: <63d28259-ff96-4450-bdc5-e1bc209d8e59@smile.fr>
X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180
X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=ti.com; s=ti-com-17Q1; t=1708394411;
 bh=9Td5qYxyywjrE1Fsz3f9qxK/6AAvAXw6CP2lydh89yg=;
 h=Date:From:To:CC:Subject:References:In-Reply-To;
 b=Au8sUhZ2zfI2B+gxqjAsW2vh3gQFdnUULtJnNPa+Vac5PmCvEoOhHfckg+zOLTX8K
 CB9sEEcMUWGztT8v2Ygh3KBCuDM0obefiisQmhiOrdlpcgZEHhRokbY+yyJlHZwBpM
 tp4w0IXYK1d9Ld4F2sRS5DDo0Zlaa6hJ24DiI2Qg=
X-Mailman-Original-Authentication-Results: smtp3.osuosl.org;
 dmarc=pass (p=quarantine dis=none)
 header.from=ti.com
X-Mailman-Original-Authentication-Results: smtp3.osuosl.org;
 dkim=pass (1024-bit key,
 unprotected) header.d=ti.com header.i=@ti.com header.a=rsa-sha256
 header.s=ti-com-17Q1 header.b=Au8sUhZ2
Subject: Re: [Buildroot] [PATCH v4 14/20] boot/uboot: set BINMAN_INDIRS for
 TI K3 DM
X-BeenThere: buildroot@buildroot.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: Discussion and development of buildroot <buildroot.buildroot.org>
List-Unsubscribe: <https://lists.buildroot.org/mailman/options/buildroot>,
 <mailto:buildroot-request@buildroot.org?subject=unsubscribe>
List-Archive: <http://lists.buildroot.org/pipermail/buildroot/>
List-Post: <mailto:buildroot@buildroot.org>
List-Help: <mailto:buildroot-request@buildroot.org?subject=help>
List-Subscribe: <https://lists.buildroot.org/mailman/listinfo/buildroot>,
 <mailto:buildroot-request@buildroot.org?subject=subscribe>
From: Andreas Dannenberg via buildroot <buildroot@buildroot.org>
Reply-To: Andreas Dannenberg <dannenberg@ti.com>
Cc: michael@amarulasolutions.com, linux-amarula@amarulasolutions.com,
 Asaf Kahlon <asafka7@gmail.com>, Xuanhao Shi <X15000177@gmail.com>,
 James Hilliard <james.hilliard1@gmail.com>,
 Thomas Petazzoni <thomas.petazzoni@bootlin.com>, buildroot@buildroot.org,
 Dario Binacchi <dario.binacchi@amarulasolutions.com>,
 Alexander Sverdlin <alexander.sverdlin@gmail.com>, bryce@redpinelabs.com,
 Anand Gadiyar <gadiyar@ti.com>
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Errors-To: buildroot-bounces@buildroot.org
Sender: "buildroot" <buildroot-bounces@buildroot.org>

On Mon, Feb 19, 2024 at 10:34:52PM +0100, Romain Naour wrote:
> Hello Andreas,
> =

> Le 19/02/2024 =E0 21:51, Andreas Dannenberg a =E9crit=A0:
> > On Sat, Feb 17, 2024 at 09:44:29PM +0100, Alexander Sverdlin wrote:
> >> Hi Dario,
> >>
> >> On Sat, 2024-02-17 at 17:02 +0100, Dario Binacchi wrote:
> >>> As explained in [1], adding support for AM62x LP SK in U-Boot, requir=
es
> >>> binman for building bootloader images. The BINMAN_INDIRS environment
> >>> variable is used to provide a space-separated list of directories to
> >>> search for binary blobs.
> >>>
> >>> [1] https://patchwork.ozlabs.org/project/uboot/patch/20231030110138.1=
347603-3-n-yadav@ti.com/
> >>> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> >>>
> >>> ---
> >>>
> >>> no changes since v1:
> >>>
> >>> Signed-off-by: Dario Binacchi <dario.binacchi@amarulasolutions.com>
> >>> ---
> >>> =A0boot/uboot/uboot.mk | 3 ++-
> >>> =A01 file changed, 2 insertions(+), 1 deletion(-)
> >>>
> >>> diff --git a/boot/uboot/uboot.mk b/boot/uboot/uboot.mk
> >>> index dda606a88059..cf70f86a4132 100644
> >>> --- a/boot/uboot/uboot.mk
> >>> +++ b/boot/uboot/uboot.mk
> >>> @@ -189,7 +189,8 @@ endif
> >>> =A0ifeq ($(BR2_TARGET_UBOOT_NEEDS_TI_K3_DM),y)
> >>> =A0UBOOT_TI_K3_DM_SOCNAME =3D $(call qstrip,$(BR2_TARGET_UBOOT_TI_K3_=
DM_SOCNAME))
> >>> =A0UBOOT_DEPENDENCIES +=3D ti-k3-boot-firmware
> >>> -UBOOT_MAKE_OPTS +=3D DM=3D$(BINARIES_DIR)/ti-dm/$(UBOOT_TI_K3_DM_SOC=
NAME)/ipc_echo_testb_mcu1_0_release_strip.xer5f
> >>> +UBOOT_MAKE_OPTS +=3D DM=3D$(BINARIES_DIR)/ti-dm/$(UBOOT_TI_K3_DM_SOC=
NAME)/ipc_echo_testb_mcu1_0_release_strip.xer5f \
> >>
> >> Is the above actually still required with binman?
> >> The names are hardcoded in U-Boot in arch/arm/dts/k3-am625-sk-binman.d=
tsi
> >>
> >>> +	BINMAN_INDIRS=3D$(BINARIES_DIR)
> >>
> >> This seems to be the only required part.
> > =

> > Correct. 'DM=3D' is no longer used, also see the official U-Boot build
> > instructions for TI platforms in the SDK documentation [1] (technically
> > speaking this documentation is for the U-Boot vendor tree, but the same
> > principle applies to upstream U-Boot builds).
> > =

> > Reviewed-by: Andreas Dannenberg <dannenberg@ti.com>
> > =

> > [1] https://software-dl.ti.com/processor-sdk-linux/esd/AM62X/09_01_00_0=
8/exports/docs/linux/Foundational_Components/U-Boot/UG-General-Info.html
> =

> It means that we can remove BR2_TARGET_UBOOT_NEEDS_TI_K3_DM and
> UBOOT_TI_K3_DM_SOCNAME too.
> =

> meta-ti still use DM=3D but probably to support u-boot-ti-staging_2023.04=
 that is
> still available [1].
> =

> The u-boot documentation also contains a similar note [2].

Yes you are right, this option is still available as an override. But
best will be to standardize on the new way of doing things, which is
BINMAN_INDIRS.

> In the end we only need an option to select which SoC type we want to use
> (GP,HS,HS-FS).

Yes. There's one small twist to that, technically for HS devices (a.k.a.
"HS-SE" devices), which is what an HS-FS device turns into _after_ the
fuses are burned with a custom key, the end user will need to provide
their own key for signing the boot image, which will then be used
instead of './board/ti/keys/custMpk.pem' in the U-Boot tree. Let me
think about some more if there isn't a good way that can be done through
Builroot, based on how actual end customers manage their private keys
(which can be very elaborate, even involving HSMs in some cases). It
might be helpful to expose such an override using a config option that
can be used to point to an external key. Anyways just food for thought,
this shouldn't gate anything on Dario's series here.


--
Andreas Dannenberg
Texas Instruments Inc



> =

> [1]
> https://git.yoctoproject.org/meta-ti/tree/meta-ti-bsp/recipes-bsp/u-boot/=
u-boot-ti.inc?h=3Dcicd.master.202402130100#n52
> =

> [2]
> https://gitlab.com/u-boot/u-boot/-/blob/master/doc/board/ti/k3.rst?ref_ty=
pe=3Dheads&plain=3D1#L372
> =

> Best regards,
> Romain
> =

> > =

> > =

> > =

> >>
> >>> =A0endif
> >>> =A0
> >>> =A0ifeq ($(BR2_TARGET_UBOOT_NEEDS_OPENSBI),y)
> >>
> >> -- =

> >> Alexander Sverdlin.
> >>
> =

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot