From: kernel test robot <lkp@intel.com>
To: Kamel Bouhara <kamel.bouhara@bootlin.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Henrik Rydberg <rydberg@bitmath.org>,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org,
Marco Felsch <m.felsch@pengutronix.de>,
Jeff LaBundy <jeff@labundy.com>
Cc: llvm@lists.linux.dev, oe-kbuild-all@lists.linux.dev,
catalin.popescu@leica-geosystems.com,
mark.satterthwaite@touchnetix.com,
Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
Gregory Clement <gregory.clement@bootlin.com>,
bsp-development.geo@leica-geosystems.com,
Kamel Bouhara <kamel.bouhara@bootlin.com>
Subject: Re: [PATCH v8 3/3] Input: Add TouchNetix axiom i2c touchscreen driver
Date: Tue, 20 Feb 2024 11:28:43 +0800 [thread overview]
Message-ID: <202402201157.BKo97uWl-lkp@intel.com> (raw)
In-Reply-To: <20240219101221.129750-4-kamel.bouhara@bootlin.com>
Hi Kamel,
kernel test robot noticed the following build errors:
[auto build test ERROR on dtor-input/next]
[also build test ERROR on dtor-input/for-linus robh/for-next krzk-dt/for-next linus/master v6.8-rc5 next-20240219]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Kamel-Bouhara/dt-bindings-vendor-prefixes-Add-TouchNetix-AS/20240219-181550
base: https://git.kernel.org/pub/scm/linux/kernel/git/dtor/input.git next
patch link: https://lore.kernel.org/r/20240219101221.129750-4-kamel.bouhara%40bootlin.com
patch subject: [PATCH v8 3/3] Input: Add TouchNetix axiom i2c touchscreen driver
config: arm64-randconfig-002-20240220 (https://download.01.org/0day-ci/archive/20240220/202402201157.BKo97uWl-lkp@intel.com/config)
compiler: clang version 19.0.0git (https://github.com/llvm/llvm-project 36adfec155de366d722f2bac8ff9162289dcf06c)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240220/202402201157.BKo97uWl-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202402201157.BKo97uWl-lkp@intel.com/
All errors (new ones prefixed by >>):
>> drivers/input/touchscreen/touchnetix_axiom.c:332:18: error: use of undeclared identifier 'slot'; did you mean 'sget'?
332 | target->index, slot, target->present,
| ^~~~
| sget
include/linux/dev_printk.h:163:47: note: expanded from macro 'dev_dbg'
163 | dev_printk(KERN_DEBUG, dev, dev_fmt(fmt), ##__VA_ARGS__); \
| ^
include/linux/dev_printk.h:129:34: note: expanded from macro 'dev_printk'
129 | _dev_printk(level, dev, fmt, ##__VA_ARGS__); \
| ^
include/linux/fs.h:2272:21: note: 'sget' declared here
2272 | struct super_block *sget(struct file_system_type *type,
| ^
1 error generated.
vim +332 drivers/input/touchscreen/touchnetix_axiom.c
289
290 /*
291 * Support function to axiom_process_u41_report.
292 * Generates input-subsystem events for every target.
293 * After calling this function the caller shall issue
294 * a Sync to the input sub-system.
295 */
296 static bool axiom_process_u41_report_target(struct axiom_data *ts,
297 struct axiom_target_report *target)
298 {
299 struct input_dev *input_dev = ts->input_dev;
300 struct axiom_u41_target *target_prev_state;
301 enum axiom_target_state current_state;
302 int id;
303
304 /* Verify the target index */
305 if (target->index >= AXIOM_U41_MAX_TARGETS) {
306 dev_err(ts->dev, "Invalid target index! %u\n", target->index);
307 return false;
308 }
309
310 target_prev_state = &ts->targets[target->index];
311
312 current_state = AXIOM_TARGET_STATE_NOT_PRESENT;
313
314 if (target->present) {
315 if (target->z >= 0)
316 current_state = AXIOM_TARGET_STATE_TOUCHING;
317 else if (target->z > AXIOM_PROX_LEVEL && target->z < 0)
318 current_state = AXIOM_TARGET_STATE_HOVER;
319 else if (target->z == AXIOM_PROX_LEVEL)
320 current_state = AXIOM_TARGET_STATE_PROX;
321 }
322
323 if (target_prev_state->state == current_state &&
324 target_prev_state->x == target->x &&
325 target_prev_state->y == target->y &&
326 target_prev_state->z == target->z)
327 return false;
328
329 id = target->index;
330
331 dev_dbg(ts->dev, "U41 Target T%u, slot:%u present:%u, x:%u, y:%u, z:%d\n",
> 332 target->index, slot, target->present,
333 target->x, target->y, target->z);
334
335 switch (current_state) {
336 case AXIOM_TARGET_STATE_NOT_PRESENT:
337 case AXIOM_TARGET_STATE_PROX:
338 if (!target_prev_state->insert)
339 break;
340 target_prev_state->insert = false;
341
342 if (!id)
343 input_report_key(input_dev, BTN_TOUCH, 0);
344
345 input_mt_report_slot_inactive(input_dev);
346 /*
347 * make sure the previous coordinates are
348 * all off screen when the finger comes back
349 */
350 target->x = 65535;
351 target->y = 65535;
352 target->z = AXIOM_PROX_LEVEL;
353 break;
354 case AXIOM_TARGET_STATE_HOVER:
355 case AXIOM_TARGET_STATE_TOUCHING:
356 target_prev_state->insert = true;
357 input_report_abs(input_dev, ABS_MT_TRACKING_ID, id);
358 input_report_abs(input_dev, ABS_MT_POSITION_X, target->x);
359 input_report_abs(input_dev, ABS_MT_POSITION_Y, target->y);
360
361 if (current_state == AXIOM_TARGET_STATE_TOUCHING) {
362 input_report_abs(input_dev, ABS_MT_DISTANCE, 0);
363 input_report_abs(input_dev, ABS_DISTANCE, 0);
364 input_report_abs(input_dev, ABS_MT_PRESSURE, target->z);
365 input_report_abs(input_dev, ABS_PRESSURE, target->z);
366 } else {
367 input_report_abs(input_dev, ABS_MT_DISTANCE, -target->z);
368 input_report_abs(input_dev, ABS_DISTANCE, -target->z);
369 input_report_abs(input_dev, ABS_MT_PRESSURE, 0);
370 input_report_abs(input_dev, ABS_PRESSURE, 0);
371 }
372
373 if (!id)
374 input_report_key(input_dev, BTN_TOUCH, (current_state ==
375 AXIOM_TARGET_STATE_TOUCHING));
376 break;
377 default:
378 break;
379 }
380
381 target_prev_state->state = current_state;
382 target_prev_state->x = target->x;
383 target_prev_state->y = target->y;
384 target_prev_state->z = target->z;
385
386 return true;
387 }
388
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
prev parent reply other threads:[~2024-02-20 3:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-19 10:12 [PATCH v8 0/3] Input: Add TouchNetix axiom touchscreen driver Kamel Bouhara
2024-02-19 10:12 ` [PATCH v8 1/3] dt-bindings: vendor-prefixes: Add TouchNetix AS Kamel Bouhara
2024-02-19 10:12 ` [PATCH v8 2/3] dt-bindings: input: Add TouchNetix axiom touchscreen Kamel Bouhara
2024-02-19 10:12 ` [PATCH v8 3/3] Input: Add TouchNetix axiom i2c touchscreen driver Kamel Bouhara
2024-02-19 10:58 ` SHUKLA Mamta Ramendra
2024-02-19 12:49 ` Kamel Bouhara
2024-02-20 0:20 ` kernel test robot
2024-02-20 3:28 ` kernel test robot [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202402201157.BKo97uWl-lkp@intel.com \
--to=lkp@intel.com \
--cc=bsp-development.geo@leica-geosystems.com \
--cc=catalin.popescu@leica-geosystems.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=gregory.clement@bootlin.com \
--cc=jeff@labundy.com \
--cc=kamel.bouhara@bootlin.com \
--cc=krzk@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=llvm@lists.linux.dev \
--cc=m.felsch@pengutronix.de \
--cc=mark.satterthwaite@touchnetix.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=robh+dt@kernel.org \
--cc=rydberg@bitmath.org \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.