From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 9E5ADC48BC3 for ; Tue, 20 Feb 2024 12:05:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=kzYRd/VbAv3Aep+ZDlmlt8xLxvkh76FcUJJINvloX28=; b=i46L2z9ARsoqgv EjNuGDfUksb90v/TIa6/2I0zBshqCpcNwVf6sKBQ5rmBkSIEhzJ7prRSdfZt0zJNQKurk3DcajZxF ebaQd5KwkqNQkewGWxNnnJR/+7ytd+4mp5kDygKkr7xW6sTI8BoppOvOhxA/ecV4FlvYJn8cKz2I+ oAHgehq8bgHdvH1RUYc502f8g7Sy8zs6IohzGu5Z7yInX1yCLJOFA6MQKG32pAqFGA7UaiqSmWt5g xNQqEL+mpCT9F9xrIozjNGPLnRAg3wCG7T40xeWAiK4BAkb/wxclE0LK2brrdeIkL6DP8k+CM0Ada mknEs6ebkn32TJ0QEZHg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rcOsV-0000000Eakv-2Xqm; Tue, 20 Feb 2024 12:05:39 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rcOsS-0000000Eaka-3iiT for linux-arm-kernel@lists.infradead.org; Tue, 20 Feb 2024 12:05:38 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 4075160ED2; Tue, 20 Feb 2024 12:05:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D1B58C433C7; Tue, 20 Feb 2024 12:05:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708430735; bh=uFhQeV0G5kKC+gS0p2qQ4txoQzbH3NaU3HXRPdCBUI0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qJ0KtNMMu9CPBiN4yK5l4EUJ1JY73SfqBKLLpqsSUWWjkKMH7h3m9ng5R6huJQpJs 599ouKRCIN7NddfvXPghuzZFq9v9dRp4BTfq7t6M35+MKx6kLvfG+IqmBpZ0mzTLYx Plk20+upJx1xNjr4JZgS//FVLUETCwzM6u2IKcAROPCIZBpD49zGa5W5WXZJP2w8nb uWx0AHEs1PmcAjUNrQTbaLM7Yotq2Ww98b/tsY0KUxWvr+pLYpcOz5nGnI0hjXE8cP kUyUpMNZdQAqpZHGmDoA4q37P/6MJQ/NGqXf+tx8k+xgLmFgtkQ5dqufkoOQUKJ81a D14m+iX7xJ3Zg== Date: Tue, 20 Feb 2024 12:05:30 +0000 From: Will Deacon To: Ard Biesheuvel Cc: Geert Uytterhoeven , Arnd Bergmann , Fangrui Song , Catalin Marinas , linux-arm-kernel@lists.infradead.org, Jisheng Zhang , Dave Martin , Peter Smith , llvm@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] arm64: jump_label: use constraints "Si" instead of "i" Message-ID: <20240220120529.GA5613@willie-the-truck> References: <20240206074552.541154-1-maskray@google.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240220_040536_993159_78D09A61 X-CRM114-Status: GOOD ( 21.52 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Feb 19, 2024 at 04:41:03PM +0100, Ard Biesheuvel wrote: > On Mon, 19 Feb 2024 at 15:43, Geert Uytterhoeven wrote: > > > > > > Changes from > > > > > > arm64: jump_label: use constraint "S" instead of "i" (https://lore.kernel.org/all/20240131065322.1126831-1-maskray@google.com/) > > > > > > > > > > > > * Use "Si" as Ard suggested to support Clang<19 > > > > > > * Make branch a separate operand > > > > > > > > > > > > Changes from v1: > > > > > > > > > > > > * Use asmSymbolicName for readability > > > > > > > > > > But it still fails on gcc-5: > > > > > > > > > > arch/arm64/include/asm/jump_label.h:25:2: error: invalid 'asm': > > > > > invalid operand > > > > > asm goto( > > > > > ^ > > > > > > > > > > http://kisskb.ellerman.id.au/kisskb/buildresult/15129281/ > > > > > > > > > > > > > How odd. godbolt.org has 5.4 and it seems perfectly happy with it. > > > > > https://godbolt.org/z/GTnf3vPaT > > > > I could reproduce the issue on v6.8-rc5 using arm64 defconfig > > and x86_64-gcc-5.5.0-nolibc-aarch64-linux.tar.xz from > > https://cdn.kernel.org/pub/tools/crosstool/files/bin/x86_64/5.5.0/: > > > > OK, I managed to do so as well. > > And GCC 6.4 from the same source works correctly. > > Not sure whether there are any plans to bump the minimal GCC version > any time soon (cc'ing Arnd), but we should probably drop this change > until that happens. Yup, makes sense to me. I'll revert the original change and we can bring it back later if we decide to bump the minimum GCC version. Cheers, Will _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7557267A0D; Tue, 20 Feb 2024 12:05:36 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708430736; cv=none; b=aLNVwxAB7ZSdaxZlC5yCQPMvyz1blzyvas5rVTrvh8OXB6bNeR+0bMFvO4+0UUORiEkVuO7RP9qaohDxSYZAbL9Gesk57YRV/xjdCxcZD5WF6h0/o8G8UgHcmvbkf9khB9gklRDG/Ce45hNDLK/QfBAhMZGj/XgDBKBT7qqbLBI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708430736; c=relaxed/simple; bh=uFhQeV0G5kKC+gS0p2qQ4txoQzbH3NaU3HXRPdCBUI0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=JroSxubeWYhdJYQcjESrfMTJnvuJSvTshICpnz74/ov8CyjhdWYoRWpPB7LLF+CK33j9jrUNwTxHLY2oNloy5bDqzCy9rPVLli0BSXGeG75q2LpR7xTvEexsNB40hqBi3VuMwFkkiGl6qpPIlBCzdQmRUVzbdbu4V08WpblRxTY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=qJ0KtNMM; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="qJ0KtNMM" Received: by smtp.kernel.org (Postfix) with ESMTPSA id D1B58C433C7; Tue, 20 Feb 2024 12:05:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708430735; bh=uFhQeV0G5kKC+gS0p2qQ4txoQzbH3NaU3HXRPdCBUI0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=qJ0KtNMMu9CPBiN4yK5l4EUJ1JY73SfqBKLLpqsSUWWjkKMH7h3m9ng5R6huJQpJs 599ouKRCIN7NddfvXPghuzZFq9v9dRp4BTfq7t6M35+MKx6kLvfG+IqmBpZ0mzTLYx Plk20+upJx1xNjr4JZgS//FVLUETCwzM6u2IKcAROPCIZBpD49zGa5W5WXZJP2w8nb uWx0AHEs1PmcAjUNrQTbaLM7Yotq2Ww98b/tsY0KUxWvr+pLYpcOz5nGnI0hjXE8cP kUyUpMNZdQAqpZHGmDoA4q37P/6MJQ/NGqXf+tx8k+xgLmFgtkQ5dqufkoOQUKJ81a D14m+iX7xJ3Zg== Date: Tue, 20 Feb 2024 12:05:30 +0000 From: Will Deacon To: Ard Biesheuvel Cc: Geert Uytterhoeven , Arnd Bergmann , Fangrui Song , Catalin Marinas , linux-arm-kernel@lists.infradead.org, Jisheng Zhang , Dave Martin , Peter Smith , llvm@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] arm64: jump_label: use constraints "Si" instead of "i" Message-ID: <20240220120529.GA5613@willie-the-truck> References: <20240206074552.541154-1-maskray@google.com> Precedence: bulk X-Mailing-List: llvm@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) On Mon, Feb 19, 2024 at 04:41:03PM +0100, Ard Biesheuvel wrote: > On Mon, 19 Feb 2024 at 15:43, Geert Uytterhoeven wrote: > > > > > > Changes from > > > > > > arm64: jump_label: use constraint "S" instead of "i" (https://lore.kernel.org/all/20240131065322.1126831-1-maskray@google.com/) > > > > > > > > > > > > * Use "Si" as Ard suggested to support Clang<19 > > > > > > * Make branch a separate operand > > > > > > > > > > > > Changes from v1: > > > > > > > > > > > > * Use asmSymbolicName for readability > > > > > > > > > > But it still fails on gcc-5: > > > > > > > > > > arch/arm64/include/asm/jump_label.h:25:2: error: invalid 'asm': > > > > > invalid operand > > > > > asm goto( > > > > > ^ > > > > > > > > > > http://kisskb.ellerman.id.au/kisskb/buildresult/15129281/ > > > > > > > > > > > > > How odd. godbolt.org has 5.4 and it seems perfectly happy with it. > > > > > https://godbolt.org/z/GTnf3vPaT > > > > I could reproduce the issue on v6.8-rc5 using arm64 defconfig > > and x86_64-gcc-5.5.0-nolibc-aarch64-linux.tar.xz from > > https://cdn.kernel.org/pub/tools/crosstool/files/bin/x86_64/5.5.0/: > > > > OK, I managed to do so as well. > > And GCC 6.4 from the same source works correctly. > > Not sure whether there are any plans to bump the minimal GCC version > any time soon (cc'ing Arnd), but we should probably drop this change > until that happens. Yup, makes sense to me. I'll revert the original change and we can bring it back later if we decide to bump the minimum GCC version. Cheers, Will