From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6722E1AACD; Mon, 26 Feb 2024 22:06:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708985214; cv=none; b=f7E/4nLK9Y7zag6t4/UL2qsZsT+NDDhyyXIiWRQ8p5NSLMlDhxCeJiRgAvDUNLGfYIfEHh+ccksFTTHy6vlg/vo/ANDlfZLuttMeMPwm5Av/pcdZS4gBSw0TOZdMdmItumytdSh6V47E7JJGWXfc+KLO4sbFVyuvmNQtbYIN2Co= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708985214; c=relaxed/simple; bh=AhAkCYM47O8dKZ4IHxet9r4VJYofKYTUO2jJeRmXvNI=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=TJ2Jz0m7mrmtw24FMGB1X969T5Sn87zlQVTGVeu1a0cmV5pSWyTOTFfGuHuXWyDrsQtdmiz0v85s9P8uWEWPGYXiQ1NEmaRvhpE1GcwdcvFa6X656LQlQaW/v3XIGMTAsCHpGDvoqGVnSioChIVFuGU9GKsOYa8/+c5mRhgATpU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=sQoy0Wb3; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="sQoy0Wb3" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 46901C433F1; Mon, 26 Feb 2024 22:06:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708985213; bh=AhAkCYM47O8dKZ4IHxet9r4VJYofKYTUO2jJeRmXvNI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=sQoy0Wb3pbFwWi3l8cO0Qvzmaa0DZej3NmaCW4Jvq2S5oSoBZ9TQs90YRXIKOKwji gTaTZbZmlXLHdR3k6qBAC8JdTMwGbBdnCpd5AxjK9VdPh/QijxSq2TWBFryB7ZOBxG 4PWHDZvR08tUOpi7o+7UHrzZuLFoa2vVC42hYh0ZDGw8ON/d7N4b++9y2wfakJGJsG yK3XM1YFRiIxLzCxmYNYrXwNszp3FM/H6uKRyj7lQZ9p4lWqNmiHVdaldYs6Dn4hGs Xqhqm2EiKhofgwXmNwlk8Nh1SzH4PMbXn6aXtgdWseilZAm8oASqOyrYlPB6eiftTp mclBdC8x7im5w== Date: Mon, 26 Feb 2024 22:06:37 +0000 From: Jonathan Cameron To: Conor Dooley Cc: "Peng Fan (OSS)" , haibo.chen@nxp.com, lars@metafoo.de, robh@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan Subject: Re: [PATCH 1/2] dt-bindings: iio: adc: imx93: drop the 4th interrupt Message-ID: <20240226220637.7bc64b95@jic23-huawei> In-Reply-To: <20240226-rectangle-pacifist-633ae3b801c7@spud> References: <20240226130826.3824251-1-peng.fan@oss.nxp.com> <20240226-germinate-anymore-fb85ca9bb226@spud> <20240226192055.54b4a6b1@jic23-huawei> <20240226-rectangle-pacifist-633ae3b801c7@spud> X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Mon, 26 Feb 2024 21:17:06 +0000 Conor Dooley wrote: > On Mon, Feb 26, 2024 at 07:20:55PM +0000, Jonathan Cameron wrote: > > On Mon, 26 Feb 2024 16:24:47 +0000 > > Conor Dooley wrote: > > > > > On Mon, Feb 26, 2024 at 09:08:25PM +0800, Peng Fan (OSS) wrote: > > > > From: Peng Fan > > > > > > > > Per i.MX93 Reference Mannual Rev.4, 12/2013, there is no interrupt 268, > > > > so drop it. > > > > > > Don't just remove it from the example, drop it from the binding too? > > > It does permit a 4th "self testing" interrupt. > > > > I'm missing something. See below... > > > > > > Thanks, > > > Conor. > > > > > > > > > > > Signed-off-by: Peng Fan > > > > --- > > > > Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml | 4 +--- > > > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > > > > > diff --git a/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml > > > > index dacc526dc695..dfc3f512918f 100644 > > > > --- a/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml > > > > +++ b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml > > > > @@ -31,7 +31,6 @@ properties: > > > > - description: normal conversion, include EOC (End of Conversion), > > > > ECH (End of Chain), JEOC (End of Injected Conversion) and > > > > JECH (End of injected Chain). > > > > - - description: Self-testing Interrupts. > > > > Eyes skipped over this maybe? The 4th interrupt is removed from binding here... > > Huh, wonder how I missed that. I thought I double checked... > Acked-by: Conor Dooley > > Cheers, > Conor. Happens to us all! Applied patch 1 to the togreg branch of iio.git and pushed it out as testing so 0-day can poke at it. Thanks, Jonathan From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 66012C48BF6 for ; Mon, 26 Feb 2024 22:07:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=GXdWG6IXYoWsbcHAgfZx9NiARKQcGZG2NHR9QkbaWLA=; b=BXtKETAhtabE27 5RT4fLxQPiKxIYBJBg1EATvD785TYgUKF058gpXZESXGNQv6rd5jgt0xfUkLgyFPDAjznuQt3JZjW kUhM8HEPd/4OKB4f/Qyno7evW897ggUl36aANmu5AwnSOFI52l1iZKVItzKWf26JvS2n5cXZQeHdY sYzlmC/vtIrJFKcr5LN+Zf6e8Qw7XImEy4/Zax59EyB7Crul/Gm8AfRe+65L5PgU/KF3oorQU6KM4 6VBerEWOdyVOdmHBpZg1mSab6pb3r2Qnr+61J4H7ze1GDiNfTAxOnlC3cf02fQ2ASFO8qvA7Ml7e+ f3wKpBs39ZuWY1UFEudg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rej7l-00000002nJC-2fuL; Mon, 26 Feb 2024 22:07:01 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rej7e-00000002nHd-3GF6 for linux-arm-kernel@lists.infradead.org; Mon, 26 Feb 2024 22:06:57 +0000 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 31F0461355; Mon, 26 Feb 2024 22:06:54 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 46901C433F1; Mon, 26 Feb 2024 22:06:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1708985213; bh=AhAkCYM47O8dKZ4IHxet9r4VJYofKYTUO2jJeRmXvNI=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=sQoy0Wb3pbFwWi3l8cO0Qvzmaa0DZej3NmaCW4Jvq2S5oSoBZ9TQs90YRXIKOKwji gTaTZbZmlXLHdR3k6qBAC8JdTMwGbBdnCpd5AxjK9VdPh/QijxSq2TWBFryB7ZOBxG 4PWHDZvR08tUOpi7o+7UHrzZuLFoa2vVC42hYh0ZDGw8ON/d7N4b++9y2wfakJGJsG yK3XM1YFRiIxLzCxmYNYrXwNszp3FM/H6uKRyj7lQZ9p4lWqNmiHVdaldYs6Dn4hGs Xqhqm2EiKhofgwXmNwlk8Nh1SzH4PMbXn6aXtgdWseilZAm8oASqOyrYlPB6eiftTp mclBdC8x7im5w== Date: Mon, 26 Feb 2024 22:06:37 +0000 From: Jonathan Cameron To: Conor Dooley Cc: "Peng Fan (OSS)" , haibo.chen@nxp.com, lars@metafoo.de, robh@kernel.org, krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org, shawnguo@kernel.org, s.hauer@pengutronix.de, kernel@pengutronix.de, festevam@gmail.com, linux-imx@nxp.com, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Peng Fan Subject: Re: [PATCH 1/2] dt-bindings: iio: adc: imx93: drop the 4th interrupt Message-ID: <20240226220637.7bc64b95@jic23-huawei> In-Reply-To: <20240226-rectangle-pacifist-633ae3b801c7@spud> References: <20240226130826.3824251-1-peng.fan@oss.nxp.com> <20240226-germinate-anymore-fb85ca9bb226@spud> <20240226192055.54b4a6b1@jic23-huawei> <20240226-rectangle-pacifist-633ae3b801c7@spud> X-Mailer: Claws Mail 4.2.0 (GTK 3.24.41; x86_64-pc-linux-gnu) MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240226_140655_545043_0EED1CD7 X-CRM114-Status: GOOD ( 21.67 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 26 Feb 2024 21:17:06 +0000 Conor Dooley wrote: > On Mon, Feb 26, 2024 at 07:20:55PM +0000, Jonathan Cameron wrote: > > On Mon, 26 Feb 2024 16:24:47 +0000 > > Conor Dooley wrote: > > > > > On Mon, Feb 26, 2024 at 09:08:25PM +0800, Peng Fan (OSS) wrote: > > > > From: Peng Fan > > > > > > > > Per i.MX93 Reference Mannual Rev.4, 12/2013, there is no interrupt 268, > > > > so drop it. > > > > > > Don't just remove it from the example, drop it from the binding too? > > > It does permit a 4th "self testing" interrupt. > > > > I'm missing something. See below... > > > > > > Thanks, > > > Conor. > > > > > > > > > > > Signed-off-by: Peng Fan > > > > --- > > > > Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml | 4 +--- > > > > 1 file changed, 1 insertion(+), 3 deletions(-) > > > > > > > > diff --git a/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml > > > > index dacc526dc695..dfc3f512918f 100644 > > > > --- a/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml > > > > +++ b/Documentation/devicetree/bindings/iio/adc/nxp,imx93-adc.yaml > > > > @@ -31,7 +31,6 @@ properties: > > > > - description: normal conversion, include EOC (End of Conversion), > > > > ECH (End of Chain), JEOC (End of Injected Conversion) and > > > > JECH (End of injected Chain). > > > > - - description: Self-testing Interrupts. > > > > Eyes skipped over this maybe? The 4th interrupt is removed from binding here... > > Huh, wonder how I missed that. I thought I double checked... > Acked-by: Conor Dooley > > Cheers, > Conor. Happens to us all! Applied patch 1 to the togreg branch of iio.git and pushed it out as testing so 0-day can poke at it. Thanks, Jonathan _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel