From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A8B9F86275; Thu, 29 Feb 2024 15:28:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709220495; cv=none; b=PoFUfGG8H5LQucI7UbUn7kRd1JpYgB+oPaCCAmmTKEvoQPFSzHsuHk5KnR9wpRrvzkw+QLUJxoYgBqF6aRazq1aJ7UjzmOzVFX9w5dWd1snn3+2IZxlelCfRblCUEmHjeBYRWuOL8BWPJrJTErDn7DbIHVZ8i0N97GFwTJTv504= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709220495; c=relaxed/simple; bh=mBQXZyrRxgzNUolzhgxjlsuqSS7+yHr2XWDMdZUoF8w=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=k0Z+aNOxyUFo3Df5xWuEazDCNAxTqI7umTsfgQ1n13UrCikc+Ilx5keSwGnVq0CWtZ9dRneupiKUG24qW59Nf3TvMMcFLC8rEzvwRTkWyW8UYmVKlKi+yeJK4UPOzbNTR/EyJ9vE5pVjPycOkK5OA1cJUyHUSUWwuWl7SJteT78= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=thFtna3X; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="thFtna3X" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4F2A4C433F1; Thu, 29 Feb 2024 15:28:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709220495; bh=mBQXZyrRxgzNUolzhgxjlsuqSS7+yHr2XWDMdZUoF8w=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=thFtna3XIf74IR8tJBbuB5/fLJRn8cAoY8FRSZp73ZENJF23ybG9GkALI0fbnxSHL TlTNqyFiS/wWRH1GKf4Wx4nVitwEZ8gUAx7cyfZ9ViqQ33HSDZX9/uRch7fB3WVgAY wOcEzvnbucsi0EU+Rpu1jQ/YtlDdps1cmB38pQ3ILD+Bq5MdnJxGtzzFP11C44afAD ELBnWpinULqCORPnTdGK6rQsk8qoBVx98mONgIFfI0iWJ0qwWmHAwBngsS8P8Of3Cs u3h+453um7Kw43U/9RT3YxGeVITfmT/vf+EMEUlSRjJZELbqG0mrxSSKakeAOVECd0 sexdu9ZX7IYEw== Date: Thu, 29 Feb 2024 07:28:13 -0800 From: Jakub Kicinski To: Jiri Pirko Cc: Larysa Zaremba , intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, Mateusz Pacuszka , Tony Nguyen , Lukasz Plachno , Jakub Buchocki , Pawel Kaminski , Przemek Kitszel , Michal Swiatkowski , Mateusz Polchlopek , "David S. Miller" , Eric Dumazet , Paolo Abeni , Pawel Chmielewski , Jesse Brandeburg Subject: Re: [PATCH iwl-net 0/5] ice: LLDP support for VFs Message-ID: <20240229072813.5d7614c3@kernel.org> In-Reply-To: References: <20240228155957.408036-1-larysa.zaremba@intel.com> <20240228084745.2c0fef0e@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Thu, 29 Feb 2024 10:20:05 +0100 Jiri Pirko wrote: > But isn't it a matter of eswitch configuration? I mean, the user should > be free to configure filtering/forwarding of any packet, including LLDP > ones. This is an LLDP agent which runs as part of the NIC FW, AFAIU, not about forwarding or filtering. They already have the priv flag, so best to reuse that. If not possible we can explore options, but as Larysa mentioned herself in the cover letter sysfs is probably low on the preference list :( From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1C3C0C48BF6 for ; Thu, 29 Feb 2024 15:28:37 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id AC89B418D7; Thu, 29 Feb 2024 15:28:36 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 3EOZzDoKeJ-t; Thu, 29 Feb 2024 15:28:36 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=intel-wired-lan-bounces@osuosl.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org 163DF418ED DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=osuosl.org; s=default; t=1709220516; bh=mBQXZyrRxgzNUolzhgxjlsuqSS7+yHr2XWDMdZUoF8w=; h=Date:From:To:In-Reply-To:References:Subject:List-Id: List-Unsubscribe:List-Archive:List-Post:List-Help:List-Subscribe: Cc:From; b=xBZhqHam97mccmmTXkLkv3ZvrHMkj6/PGIdA0m2Lcyxy4xXB0QVfjNhIzh1sNWQXM MT4CVjWDTZ2/1NOR6fSBIDg7AEiqwtts2+vQNfg1L3ld9Jvm8U18eiq+kEydAXb2ll Hz9WHELfRlswmWqjOQ2CnbSHuVyNTVMuSrtyd6y2le7SDZxdNZPCJ7Cju1o9Nz8lSy lWAkZm6w/lro6gvsi1nlooF7ld9A7kbssj4bXo1vu5tyiHcRlzfPB5K14v2chrft/h WOU3GD/RclsWjE3fct+4JlhonDdQ5zrh7WrtS9fNf4WYcfp/vvHDq3HCqLUADpriU3 Rt+CTd5ZSVNOA== Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp4.osuosl.org (Postfix) with ESMTP id 163DF418ED; Thu, 29 Feb 2024 15:28:36 +0000 (UTC) Received: from smtp1.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 651241BF2B4 for ; Thu, 29 Feb 2024 15:28:17 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp1.osuosl.org (Postfix) with ESMTP id 5CB26827C6 for ; Thu, 29 Feb 2024 15:28:17 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp1.osuosl.org ([127.0.0.1]) by localhost (smtp1.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id XdH-Wx6oeJjO for ; Thu, 29 Feb 2024 15:28:16 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2604:1380:4641:c500::1; helo=dfw.source.kernel.org; envelope-from=kuba@kernel.org; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp1.osuosl.org B7B6A827A8 DKIM-Filter: OpenDKIM Filter v2.11.0 smtp1.osuosl.org B7B6A827A8 Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) by smtp1.osuosl.org (Postfix) with ESMTPS id B7B6A827A8 for ; Thu, 29 Feb 2024 15:28:16 +0000 (UTC) Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 7ED2E60C3C; Thu, 29 Feb 2024 15:28:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4F2A4C433F1; Thu, 29 Feb 2024 15:28:14 +0000 (UTC) Date: Thu, 29 Feb 2024 07:28:13 -0800 From: Jakub Kicinski To: Jiri Pirko Message-ID: <20240229072813.5d7614c3@kernel.org> In-Reply-To: References: <20240228155957.408036-1-larysa.zaremba@intel.com> <20240228084745.2c0fef0e@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Mailman-Original-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1709220495; bh=mBQXZyrRxgzNUolzhgxjlsuqSS7+yHr2XWDMdZUoF8w=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=thFtna3XIf74IR8tJBbuB5/fLJRn8cAoY8FRSZp73ZENJF23ybG9GkALI0fbnxSHL TlTNqyFiS/wWRH1GKf4Wx4nVitwEZ8gUAx7cyfZ9ViqQ33HSDZX9/uRch7fB3WVgAY wOcEzvnbucsi0EU+Rpu1jQ/YtlDdps1cmB38pQ3ILD+Bq5MdnJxGtzzFP11C44afAD ELBnWpinULqCORPnTdGK6rQsk8qoBVx98mONgIFfI0iWJ0qwWmHAwBngsS8P8Of3Cs u3h+453um7Kw43U/9RT3YxGeVITfmT/vf+EMEUlSRjJZELbqG0mrxSSKakeAOVECd0 sexdu9ZX7IYEw== X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dmarc=pass (p=none dis=none) header.from=kernel.org X-Mailman-Original-Authentication-Results: smtp1.osuosl.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20201202 header.b=thFtna3X Subject: Re: [Intel-wired-lan] [PATCH iwl-net 0/5] ice: LLDP support for VFs X-BeenThere: intel-wired-lan@osuosl.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Intel Wired Ethernet Linux Kernel Driver Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michal Swiatkowski , Eric Dumazet , Larysa Zaremba , netdev@vger.kernel.org, Mateusz Polchlopek , linux-kernel@vger.kernel.org, Jakub Buchocki , Pawel Chmielewski , Jesse Brandeburg , Lukasz Plachno , "David S. Miller" , Tony Nguyen , Pawel Kaminski , Mateusz Pacuszka , intel-wired-lan@lists.osuosl.org, Paolo Abeni , Przemek Kitszel Errors-To: intel-wired-lan-bounces@osuosl.org Sender: "Intel-wired-lan" On Thu, 29 Feb 2024 10:20:05 +0100 Jiri Pirko wrote: > But isn't it a matter of eswitch configuration? I mean, the user should > be free to configure filtering/forwarding of any packet, including LLDP > ones. This is an LLDP agent which runs as part of the NIC FW, AFAIU, not about forwarding or filtering. They already have the priv flag, so best to reuse that. If not possible we can explore options, but as Larysa mentioned herself in the cover letter sysfs is probably low on the preference list :(