Re: [PATCH v2] PCI: dwc: Enable runtime pm of the host bridge

[Bjorn Helgaas <helgaas@kernel.org>]

On Tue, Mar 05, 2024 at 03:19:01PM +0530, Krishna chaitanya chundru wrote:
> The Controller driver is the parent device of the PCIe host bridge,
> PCI-PCI bridge and PCIe endpoint as shown below.

Nit: add blank line here.

> 	PCIe controller(Top level parent & parent of host bridge)
> 			|
> 			v
> 	PCIe Host bridge(Parent of PCI-PCI bridge)
> 			|
> 			v
> 	PCI-PCI bridge(Parent of endpoint driver)
> 			|
> 			v
> 		PCIe endpoint driver

Nit: use spaces instead of tabs to ensure this still looks good when
"git log" indents this.  In this case it doesn't seem to matter,

> Since runtime PM is disabled for host bridge, the state of the child
> devices under the host bridge is not taken into account by PM framework
> for the top level parent, PCIe controller. So PM framework, allows
> the controller driver to enter runtime PM irrespective of the state
> of the devices under the host bridge.

IIUC this says that we runtime suspend the controller even though
runtime PM is disabled for the host bridge?  I have a hard time
parsing this; can you cite a function that does this or some relevant
documentation about how this part of runtime PM works?

> And this causes the topology breakage and also possible PM issues.

Not sure what this refers to, since you didn't mention topology
breakage earlier.  And "possible PM" issues is too vague to be useful.

> So enable pm runtime for the host bridge, so that controller driver
> goes to suspend only when all child devices goes to runtime suspend.

s/pm runtime/runtime PM/ so all the references match (unless you mean
something different here) (also in subject line)

> Signed-off-by: Krishna chaitanya chundru <quic_krichai@quicinc.com>
> ---
> Changes in v2:
> - Updated commit message as suggested by mani.
> - Link to v1: https://lore.kernel.org/r/20240219-runtime_pm_enable-v1-1-d39660310504@quicinc.com
> ---
>  drivers/pci/controller/dwc/pcie-designware-host.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/drivers/pci/controller/dwc/pcie-designware-host.c b/drivers/pci/controller/dwc/pcie-designware-host.c
> index d5fc31f8345f..57756a73df30 100644
> --- a/drivers/pci/controller/dwc/pcie-designware-host.c
> +++ b/drivers/pci/controller/dwc/pcie-designware-host.c
> @@ -16,6 +16,7 @@
>  #include <linux/of_pci.h>
>  #include <linux/pci_regs.h>
>  #include <linux/platform_device.h>
> +#include <linux/pm_runtime.h>
>  
>  #include "../../pci.h"
>  #include "pcie-designware.h"
> @@ -505,6 +506,9 @@ int dw_pcie_host_init(struct dw_pcie_rp *pp)
>  	if (pp->ops->post_init)
>  		pp->ops->post_init(pp);
>  
> +	pm_runtime_set_active(&bridge->dev);

There are currently no callers of pm_runtime_set_active() in
drivers/pci/controller/.  This adds it to dw_pcie_host_init(), but it
doesn't seem to be a DWC-specific issue, so I assume other drivers and
driver cores like cadence and mobiveil should have this, too?

> +	pm_runtime_enable(&bridge->dev);

There are several existing calls of pci_runtime_enable(), including
from several DWC drivers.  Are they now redundant?

In addition, [1] suggests that pm_runtime_enable() should be called
*after* pm_runtime_set_active(), but these existing calls
(dra7xx_pcie_probe(), ks_pcie_probe(), qcom_pcie_probe(),
rcar_gen4_pcie_prepare(), tegra_pcie_config_rp()) happen *before*
dw_pcie_host_init() calls pm_runtime_set_active().

[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/power/runtime_pm.rst?id=v6.7#n582

>  	return 0;
>  
>  err_stop_link:
> 
> ---
> base-commit: 6613476e225e090cc9aad49be7fa504e290dd33d
> change-id: 20240219-runtime_pm_enable-bdc17914bd50
> 
> Best regards,
> -- 
> Krishna chaitanya chundru <quic_krichai@quicinc.com>
>